- in c3629a24435ad620d03b379b78dbf92f52804661
this change to the rpc error is testing the wrong thing
delta1
/ elements-25-review-notes.md
Last active
February 1, 2024 12:23
elements 25 merge review notes
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| diff --git a/Cargo.toml b/Cargo.toml | |
| index 7b8ec56..bbaa386 100644 | |
| --- a/Cargo.toml | |
| +++ b/Cargo.toml | |
| @@ -39,8 +39,8 @@ num_cpus = "1.12.0" | |
| page_size = "0.4.2" | |
| prometheus = "0.13" | |
| rayon = "1.5.0" | |
| -rocksdb = { version = "0.17.0", optional = true } | |
| -rocksdb-oldcpu = { version = "0.12.4", optional = true, package = "rocksdb" } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 1646386404 2022-03-04T09:33:24+00:00 4fae737f4b Bitcoin Merge bitcoin/bitcoin#24441: fuzz: Limit script_format to 100kB | |
| 1646396903 2022-03-04T07:28:23-05:00 bada9636d7 Bitcoin Merge bitcoin/bitcoin#24043: Add (sorted)multi_a descriptor for k-of-n multisig inside tr | |
| 1646408374 2022-03-04T15:39:34+00:00 cc70f65d21 Bitcoin Merge bitcoin/bitcoin#24460: build: update ax_cxx_compile_stdcxx to serial 14 | |
| 1646497255 2022-03-05T17:20:55+01:00 c8f2817bd6 Bitcoin Merge bitcoin-core/gui#549: refactor: use std::chrono for formatDurationStr() helper | |
| 1646571055 2022-03-06T07:50:55-05:00 4774b753bb Bitcoin Merge bitcoin/bitcoin#24484: guix: use same commit for codesigning time-machine | |
| 1646639225 2022-03-07T08:47:05+01:00 384866e870 Bitcoin Merge bitcoin/bitcoin#24427: refactor: Release cs_main before MaybeSendFeefilter | |
| 1646643653 2022-03-07T10:00:53+01:00 6687bb24ae Bitcoin Merge bitcoin/bitcoin#24306: util: Make ArgsManager::GetPathArg more widely usable | |
| 1646646966 2022-03-07T10:56:06+01:00 3b08427b58 Bitcoin Merge bitcoin/b |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| =============================================================================== | |
| Language Files Lines Code Comments Blanks | |
| =============================================================================== | |
| TypeScript 99 231129 231080 0 49 | |
| C++ 648 187658 146140 18927 22591 | |
| C Header 482 97761 68982 18386 10393 | |
| Python 259 59770 43940 6897 8933 | |
| C 17 10892 8949 910 1033 | |
| JSON 94 7942 7604 0 338 | |
| Shell 74 3749 2582 736 431 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| =============================================================================== | |
| Language Files Lines Code Comments Blanks | |
| =============================================================================== | |
| TypeScript 93 206214 206175 0 39 | |
| C++ 673 206127 160546 20868 24713 | |
| C Header 557 117616 83392 21718 12506 | |
| Python 424 100121 72381 12628 15112 | |
| C 29 39278 36659 1311 1308 | |
| JSON 97 8549 8183 0 366 | |
| Shell 75 3894 2700 750 444 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| static bool CreateTransactionInternal( | |
| CWallet& wallet, | |
| const std::vector<CRecipient>& vecSend, | |
| CTransactionRef& tx, | |
| CAmount& nFeeRet, | |
| int& nChangePosInOut, | |
| bilingual_str& error, | |
| const CCoinControl& coin_control, | |
| FeeCalculation& fee_calc_out, | |
| bool sign, |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| static bool CreateTransactionInternal( | |
| CWallet& wallet, | |
| const std::vector<CRecipient>& vecSend, | |
| CTransactionRef& tx, | |
| CAmount& nFeeRet, | |
| int& nChangePosInOut, | |
| bilingual_str& error, | |
| const CCoinControl& coin_control, | |
| FeeCalculation& fee_calc_out, | |
| bool sign) EXCLUSIVE_LOCKS_REQUIRED(wallet.cs_wallet) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 1685958668 2023-06-05T10:51:08+01:00 f4a8269dfc Bitcoin Merge bitcoin/bitcoin#27801: wallet: Add tracing for sqlite statements | |
| 1685721619 2023-06-02T17:00:19+01:00 7f2019755d Bitcoin Merge bitcoin/bitcoin#27790: walletdb: Add PrefixCursor | |
| 1685719647 2023-06-02T16:27:27+01:00 e43fdfd9ad Bitcoin Merge bitcoin/bitcoin#27225: doc: document json rpc endpoints | |
| 1685719091 2023-06-02T16:18:11+01:00 436c185b05 Bitcoin Merge bitcoin/bitcoin#27256: refactor: rpc: Remove unnecessary uses of ParseNonRFCJSONValue() and rename it | |
| 1685712112 2023-06-02T14:21:52+01:00 b22408df16 Bitcoin Merge bitcoin/bitcoin#27603: test: added coverage to mining_basic.py | |
| 1685699975 2023-06-02T10:59:35+01:00 6a560aceb7 Bitcoin Merge bitcoin/bitcoin#27803: Fuzz: Mitigate timeout in CalculateTotalBumpFees | |
| 1685698925 2023-06-02T10:42:05+01:00 8a972813ba Bitcoin Merge bitcoin/bitcoin#27737: ci: compile Clang and compiler-rt in msan jobs | |
| 1685698081 2023-06-02T10:28:01+01:00 83c7269965 Bitcoin Merge bitcoin/bitcoin#27800: streams: Drop confusing Dat |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 1663603812 2022-09-19T18:10:12+02:00 6e11e20340 Bitcoin Merge bitcoin/bitcoin#26121: build: Bump version to 24.99 | |
| 1663600247 2022-09-19T16:10:47+01:00 9f650062fc Bitcoin Merge bitcoin/bitcoin#26005: Wallet: Fix error handling (copy_file failure in RestoreWallet, and in general via interfaces) | |
| 1663599113 2022-09-19T15:51:53+01:00 55e1deb745 Bitcoin Merge bitcoin/bitcoin#25540: miniscript: avoid wasteful computation, prevent memory blowup when fuzzing | |
| 1663497231 2022-09-18T11:33:51+01:00 a9ffebddbe Bitcoin Merge bitcoin/bitcoin#26075: contrib: remove 32bit linux code from release scripts | |
| 1663336433 2022-09-16T14:53:53+01:00 a688ff9046 Bitcoin Merge bitcoin/bitcoin#26087: build: prune BOOST_CPPFLAGS from libbitcoin_zmq | |
| 1663333393 2022-09-16T15:03:13+02:00 9fefd00d8e Bitcoin Merge bitcoin/bitcoin#26107: [test] only run feature_rbf.py once | |
| 1663326734 2022-09-16T12:12:14+01:00 3d892d8695 Bitcoin Merge bitcoin/bitcoin#26086: build: remove BOOST_CPPFLAGS usage from bitcoin-tx | |
| 1663325808 2022-09-16T11:56:48+01:00 5a72 |
NewerOlder