Skip to content

Instantly share code, notes, and snippets.

@dereknguyen269
Created November 9, 2016 12:50
Show Gist options
  • Save dereknguyen269/1e6f7d33df721fb35a602952d6b4fb40 to your computer and use it in GitHub Desktop.
Save dereknguyen269/1e6f7d33df721fb35a602952d6b4fb40 to your computer and use it in GitHub Desktop.
.github/PULL_REQUEST_TEMPLATE.md
Provide an explanation of **what** these changes are, and provide a
context that helps understand **why** they are made.
---
**Before submitting, check that:**
- [ ] You have added (passing) tests for your code.
- [ ] You have written good* commit messages.
- [ ] You have squashed relevant commits together.
- [ ] You have ensured that RuboCop is passing.
- [ ] Your PR relates to one subject, with a clear title and
description using complete, grammatically correct sentences.
- [ ] If this PR relates to a GitHub issue, you have prefixed the
PR title with `[Fix #n]`.
---
**If your change contains models, ensure that:**
- [ ] You have included an updated screen shot of the ERD.
- [ ] You have added database seeds for the model.
- [ ] You have added working factories for the model.
- [ ] Your validations have corresponding database constraints.
- [ ] You have added the new `schema.rb` after migrating.
---
**If your change contains views, ensure that:**
- [ ] You have included a screenshot of the new view.
---
*If you do not know what makes a good commit message, or why it
is important, please refer to these resources: [1][1], [2][2], [3][3].
[1]: https://robots.thoughtbot.com/5-useful-tips-for-a-better-commit-message
[2]: http://chris.beams.io/posts/git-commit/
[3]: https://github.com/blog/1943-how-to-write-the-perfect-pull-request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment