Vivat PVS-Studio,

errors (GA:1)

www.viva64.com/en/w:1:1: error: Help: The documentation for all analyzer warnings is available here: http://www.viva64.com/en/w/.
/home/develop7/src/pulseaudio-9.0/src/pulsecore/sink-input.c:1969:1: error: V590 Consider inspecting this expression. The expression is excessive or contains a misprint.
/home/develop7/src/pulseaudio-9.0/src/pulsecore/source.c:1854:1: error: V614 Uninitialized variable 'mute' used. Consider checking the fourth actual argument of the 'pa_asyncmsgq_send' function.
/home/develop7/src/pulseaudio-9.0/src/pulsecore/sink.c:2271:1: error: V614 Uninitialized variable 'mute' used. Consider checking the fourth actual argument of the 'pa_asyncmsgq_send' function.
/home/develop7/src/pulseaudio-9.0/src/modules/module-tunnel-sink-new.c:578:1: error: V595 The 'u->thread_mq' pointer was utilized before it was verified against nullptr. Check lines: 578, 582.
/home/develop7/src/pulseaudio-9.0/src/modules/module-tunnel-source-new.c:575:1: error: V595 The 'u->thread_mq' pointer was utilized before it was verified against nullptr. Check lines: 575, 579.
/home/develop7/src/pulseaudio-9.0/src/modules/module-tunnel.c:1026:1: error: V501 There are identical sub-expressions 'pa_tagstruct_gets(t, & s) < 0' to the left and to the right of the '||' operator.
/home/develop7/src/pulseaudio-9.0/src/modules/module-tunnel.c:1225:1: error: V501 There are identical sub-expressions 'pa_tagstruct_get_boolean(t, & b) < 0' to the left and to the right of the '||' operator.
/home/develop7/src/pulseaudio-9.0/src/pulse/stream.c:1960:1: error: V595 The 'o->stream' pointer was utilized before it was verified against nullptr. Check lines: 1960, 1969.
/home/develop7/src/pulseaudio-9.0/src/modules/alsa/alsa-ucm.c:1377:1: error: V595 The 'verb_info[i].id' pointer was utilized before it was verified against nullptr. Check lines: 1377, 1385.
/home/develop7/src/pulseaudio-9.0/src/modules/dbus/iface-device.c:661:1: error: V771 The '?:' operator uses constants from different enums (the second operand is of 'pa_sink_state' type, the third operand is of 'pa_source_state' type).
/home/develop7/src/pulseaudio-9.0/src/modules/dbus/iface-device.c:1176:1: error: V771 The '?:' operator uses constants from different enums (the second operand is of 'pa_sink_state' type, the third operand is of 'pa_source_state' type).
/home/develop7/src/pulseaudio-9.0/src/utils/padsp.c:1226:1: error: V595 The 'i' pointer was utilized before it was verified against nullptr. Check lines: 1226, 1228.
/home/develop7/src/pulseaudio-9.0/src/utils/padsp.c:1395:1: error: V595 The 'i' pointer was utilized before it was verified against nullptr. Check lines: 1395, 1397.
/home/develop7/src/pulseaudio-9.0/src/daemon/main.c:1179:1: error: V595 The 'conf' pointer was utilized before it was verified against nullptr. Check lines: 1179, 1199.

warnings (GA:2)

www.viva64.com/en/w:1:1: error: Help: The documentation for all analyzer warnings is available here: http://www.viva64.com/en/w/.
/home/develop7/src/pulseaudio-9.0/src/pulsecore/source.c:1376:1: warning: V764 Possible incorrect order of arguments passed to 'pa_cvolume_remap' function: 'to' and 'from'.
/home/develop7/src/pulseaudio-9.0/src/pulsecore/sink.c:1802:1: warning: V764 Possible incorrect order of arguments passed to 'pa_cvolume_remap' function: 'to' and 'from'.
/home/develop7/src/pulseaudio-9.0/src/pulsecore/sink.c:3480:1: warning: V547 Expression 'd' is always true.
/home/develop7/src/pulseaudio-9.0/src/utils/pasuspender.c:172:1: warning: V618 It's dangerous to call the 'fprintf' function in such a manner, as the line being passed could contain format specification. The example of the safe code: printf("%s", str);
/home/develop7/src/pulseaudio-9.0/src/utils/pasuspender.c:203:1: warning: V618 It's dangerous to call the 'fprintf' function in such a manner, as the line being passed could contain format specification. The example of the safe code: printf("%s", str);
/home/develop7/src/pulseaudio-9.0/src/utils/pasuspender.c:297:1: warning: V618 It's dangerous to call the 'fprintf' function in such a manner, as the line being passed could contain format specification. The example of the safe code: printf("%s", str);
/home/develop7/src/pulseaudio-9.0/src/utils/pasuspender.c:310:1: warning: V618 It's dangerous to call the 'fprintf' function in such a manner, as the line being passed could contain format specification. The example of the safe code: printf("%s", str);
/home/develop7/src/pulseaudio-9.0/src/utils/pasuspender.c:322:1: warning: V618 It's dangerous to call the 'fprintf' function in such a manner, as the line being passed could contain format specification. The example of the safe code: printf("%s", str);
/home/develop7/src/pulseaudio-9.0/src/utils/pacmd.c:83:1: warning: V618 It's dangerous to call the 'printf' function in such a manner, as the line being passed could contain format specification. The example of the safe code: printf("%s", str);
/home/develop7/src/pulseaudio-9.0/src/utils/pax11publish.c:93:1: warning: V618 It's dangerous to call the 'fprintf' function in such a manner, as the line being passed could contain format specification. The example of the safe code: printf("%s", str);
/home/develop7/src/pulseaudio-9.0/src/utils/pax11publish.c:136:1: warning: V618 It's dangerous to call the 'fprintf' function in such a manner, as the line being passed could contain format specification. The example of the safe code: printf("%s", str);
/home/develop7/src/pulseaudio-9.0/src/utils/pax11publish.c:141:1: warning: V618 It's dangerous to call the 'fprintf' function in such a manner, as the line being passed could contain format specification. The example of the safe code: printf("%s", str);
/home/develop7/src/pulseaudio-9.0/src/utils/pax11publish.c:170:1: warning: V618 It's dangerous to call the 'fprintf' function in such a manner, as the line being passed could contain format specification. The example of the safe code: printf("%s", str);
/home/develop7/src/pulseaudio-9.0/src/utils/pax11publish.c:190:1: warning: V618 It's dangerous to call the 'fprintf' function in such a manner, as the line being passed could contain format specification. The example of the safe code: printf("%s", str);
/home/develop7/src/pulseaudio-9.0/src/utils/pax11publish.c:208:1: warning: V618 It's dangerous to call the 'fprintf' function in such a manner, as the line being passed could contain format specification. The example of the safe code: printf("%s", str);
/home/develop7/src/pulseaudio-9.0/src/utils/pactl.c:103:1: warning: V707 Giving short names to global variables is considered to be bad practice. It is suggested to rename 'nl' variable.
/home/develop7/src/pulseaudio-9.0/src/utils/pactl.c:327:1: warning: V618 It's dangerous to call the 'printf' function in such a manner, as the line being passed could contain format specification. The example of the safe code: printf("%s", str);
/home/develop7/src/pulseaudio-9.0/src/utils/pactl.c:340:1: warning: V618 It's dangerous to call the 'printf' function in such a manner, as the line being passed could contain format specification. The example of the safe code: printf("%s", str);
/home/develop7/src/pulseaudio-9.0/src/utils/pactl.c:433:1: warning: V618 It's dangerous to call the 'printf' function in such a manner, as the line being passed could contain format specification. The example of the safe code: printf("%s", str);
/home/develop7/src/pulseaudio-9.0/src/utils/pactl.c:446:1: warning: V618 It's dangerous to call the 'printf' function in such a manner, as the line being passed could contain format specification. The example of the safe code: printf("%s", str);
/home/develop7/src/pulseaudio-9.0/src/utils/pactl.c:581:1: warning: V618 It's dangerous to call the 'printf' function in such a manner, as the line being passed could contain format specification. The example of the safe code: printf("%s", str);
/home/develop7/src/pulseaudio-9.0/src/utils/pactl.c:594:1: warning: V618 It's dangerous to call the 'printf' function in such a manner, as the line being passed could contain format specification. The example of the safe code: printf("%s", str);
/home/develop7/src/pulseaudio-9.0/src/utils/pactl.c:1586:1: warning: V618 It's dangerous to call the 'printf' function in such a manner, as the line being passed could contain format specification. The example of the safe code: printf("%s", str);
/home/develop7/src/pulseaudio-9.0/src/utils/pactl.c:1589:1: warning: V618 It's dangerous to call the 'printf' function in such a manner, as the line being passed could contain format specification. The example of the safe code: printf("%s", str);
/home/develop7/src/pulseaudio-9.0/src/utils/pactl.c:1790:1: warning: V755 A copy from unsafe data source to a buffer of fixed size. Buffer overflow is possible.
/home/develop7/src/pulseaudio-9.0/src/pulsecore/idxset.c:348:1: warning: V592 The expression was enclosed by parentheses twice: '((!* state &&!s->iterate_list_head))'. One pair of parentheses is unnecessary or misprint is present.
/home/develop7/src/pulseaudio-9.0/src/pulsecore/core-util.c:1039:1: warning: V636 The '(pa_volume_t)(4294967295U) / 2' expression was implicitly cast from 'int' type to 'double' type. Consider utilizing an explicit type cast to avoid the loss of a fractional part. An example: double A = (double)(X) / Y;.
/home/develop7/src/pulseaudio-9.0/src/pulsecore/filter/lfe-filter.c:152:1: warning: V636 The 'new_rate / 2' expression was implicitly cast from 'int' type to 'float' type. Consider utilizing an explicit type cast to avoid the loss of a fractional part. An example: double A = (double)(X) / Y;.
/home/develop7/src/pulseaudio-9.0/src/modules/alsa/alsa-util.c:922:1: warning: V547 Expression 'd' is always true.
/home/develop7/src/pulseaudio-9.0/src/modules/alsa/alsa-mixer.c:3979:1: warning: V547 Expression 'mixer_handle' is always true.
/home/develop7/src/pulseaudio-9.0/src/modules/raop/module-raop-sink.c:356:1: warning: V636 The 'silence_tmp.length / 4096' expression was implicitly cast from 'size_t' type to 'double' type. Consider utilizing an explicit type cast to avoid the loss of a fractional part. An example: double A = (double)(X) / Y;.
/home/develop7/src/pulseaudio-9.0/src/modules/raop/module-raop-sink.c:385:1: warning: V636 The expression was implicitly cast from 'size_t' type to 'double' type. Consider utilizing an explicit type cast to avoid the loss of a fractional part. An example: double A = (double)(X) / Y;.
/home/develop7/src/pulseaudio-9.0/src/daemon/dumpmodules.c:62:1: warning: V618 It's dangerous to call the 'printf' function in such a manner, as the line being passed could contain format specification. The example of the safe code: printf("%s", str);
/home/develop7/src/pulseaudio-9.0/src/daemon/main.c:450:1: warning: V547 Expression '!passed_fds' is always true.