Skip to content

Instantly share code, notes, and snippets.

@digetx
Last active May 19, 2022 04:21
Show Gist options
  • Star 1 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save digetx/60e2b5e0510395b37ebf3fba96d9a24f to your computer and use it in GitHub Desktop.
Save digetx/60e2b5e0510395b37ebf3fba96d9a24f to your computer and use it in GitHub Desktop.
1. You want to upstream these patches:
68e5c4b64765 ASoC: tegra: Add RT5631 machine driver
2bac54936f27 ASoC: dt-bindings: tegra: Add binding for RT5631
2. Create patches
# git format-patch -v1 --cover-letter -2 68e5c4b64765
Now you have these files:
v1-0000-cover-letter.patch
v1-0001-ASoC-dt-bindings-tegra-Add-binding-for-RT5631.patch
v1-0002-ASoC-tegra-Add-RT5631-machine-driver.patch
3. Check patches
# ./scripts/checkpatch.pl --strict v1*
If there are errors and warnings, fix them and go back to 1.
4. Open v1-0000-cover-letter.patch in text editor. Fill the SUBJECT
and give a short description, telling what these patches are doing
and why they are needed.
5. Get a list of email addresses to whom send the patches.
# ./scripts/get_maintainer.pl v1*
You'll get this list:
Liam Girdwood <lgirdwood@gmail.com> (supporter:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...)
Mark Brown <broonie@kernel.org> (supporter:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,commit_signer:7/9=78%,commit_signer:6/8=75%)
Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Thierry Reding <thierry.reding@gmail.com> (supporter:TEGRA ARCHITECTURE SUPPORT,in file)
Jonathan Hunter <jonathanh@nvidia.com> (supporter:TEGRA ARCHITECTURE SUPPORT,commit_signer:1/8=12%,in file)
Jaroslav Kysela <perex@perex.cz> (maintainer:SOUND)
Takashi Iwai <tiwai@suse.com> (maintainer:SOUND)
Sameer Pujar <spujar@nvidia.com> (commit_signer:6/9=67%,authored:6/9=67%,added_lines:65/82=79%,commit_signer:6/8=75%,authored:6/8=75%,added_lines:12/16=75%)
Sergey Larin <cerg2010cerg2010@mail.ru> (commit_signer:3/9=33%,commit_signer:3/8=38%)
Svyatoslav <clamor95@gmail.com> (commit_signer:1/9=11%,authored:1/9=11%,added_lines:8/82=10%,commit_signer:1/8=12%,authored:1/8=12%,added_lines:2/16=12%,commit_signer:1/1=100%,authored:1/1=100%,added_lines:261/261=100%)
Ion Agorria <ion@agorria.com> (commit_signer:1/9=11%,commit_signer:1/1=100%)
"Michał Mirosław" <mirq-linux@rere.qmqm.pl> (authored:1/9=11%,removed_lines:1/1=100%)
ryang <decatf@gmail.com> (authored:1/9=11%,added_lines:9/82=11%,authored:1/8=12%,added_lines:2/16=12%)
Stephen Warren <swarren@nvidia.com> (in file)
alsa-devel@alsa-project.org (moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...)
devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
linux-tegra@vger.kernel.org (open list:TEGRA ARCHITECTURE SUPPORT)
linux-kernel@vger.kernel.org (open list)
You are interested in maintainers, mailing lists and everyone who are directly related
to the patches. Ignore others. Hence you're interested in:
Liam Girdwood <lgirdwood@gmail.com> (supporter:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...)
Mark Brown <broonie@kernel.org> (supporter:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,commit_signer:7/9=78%,commit_signer:6/8=75%)
Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Thierry Reding <thierry.reding@gmail.com> (supporter:TEGRA ARCHITECTURE SUPPORT,in file)
Jonathan Hunter <jonathanh@nvidia.com> (supporter:TEGRA ARCHITECTURE SUPPORT,commit_signer:1/8=12%,in file)
Jaroslav Kysela <perex@perex.cz> (maintainer:SOUND)
Takashi Iwai <tiwai@suse.com> (maintainer:SOUND)
Svyatoslav <clamor95@gmail.com> (commit_signer:1/9=11%,authored:1/9=11%,added_lines:8/82=10%,commit_signer:1/8=12%,authored:1/8=12%,added_lines:2/16=12%,commit_signer:1/1=100%,authored:1/1=100%,added_lines:261/261=100%)
Ion Agorria <ion@agorria.com> (commit_signer:1/9=11%,commit_signer:1/1=100%)
Stephen Warren <swarren@nvidia.com> (in file)
alsa-devel@alsa-project.org (moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...)
devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
linux-tegra@vger.kernel.org (open list:TEGRA ARCHITECTURE SUPPORT)
linux-kernel@vger.kernel.org (open list)
You may add me to the list since I helped you with the patches.
Dmitry Osipenko <digetx@gmail.com>
6. Send patches
I'll use my Gmail for example:
# git send-email --smtp-server=smtp.gmail.com --smtp-user=digetx@gmail.com --smtp-encryption=tls --smtp-server-port=587 --suppress-cc=all --to 'Thierry Reding <thierry.reding@gmail.com>' --to 'Jonathan Hunter <jonathanh@nvidia.com>' --to 'Stephen Warren <swarren@nvidia.com>' --to 'Mark Brown <broonie@kernel.org>' --to 'Takashi Iwai <tiwai@suse.com>' --to 'Jaroslav Kysela <perex@perex.cz>' --to 'Rob Herring <robh+dt@kernel.org>' --to 'Svyatoslav <clamor95@gmail.com>' --to 'Ion Agorria <ion@agorria.com>' --to '' --to 'Dmitry Osipenko <digetx@gmail.com>' --cc 'alsa-devel@alsa-project.org' --cc 'devicetree@vger.kernel.org' --cc 'linux-tegra@vger.kernel.org' --cc 'linux-kernel@vger.kernel.org' --confirm=always v1*
Use "--to" for people and "--cc" for mailing lists.
Git will print out list of email recipients and files to send, check that everything looks okay.
Git asks "Send this email? ([y]es|[n]o|[e]dit|[q]uit|[a]ll):", answer "all".
Enter your email password and wait till all patches are sent out by git. Done.
If everything went okay, you'll see your patches in patchwork of the mailing lists:
https://patchwork.ozlabs.org/project/linux-tegra/list/
https://patchwork.kernel.org/project/alsa-devel/list/
7. Wait for review comments. Depending on a maintainer, it may take couple days, a week or more than a month. Be prepared
that you may not get quick replies, just wait. If nobody answered for more than a month or two, go to 1 and send patches
again.
8. If maintainer requsted to make changes, make them and go back to 1. Use "-v2" for `git format-patch ..` to bump version of
the patches to v2.
9. Maintainer will answer you if everything is okay and patches are applied. Done.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment