Skip to content

Instantly share code, notes, and snippets.

Embed
What would you like to do?
Pull Request Template

Link to story: http://something.somwhere.schmoo

What this PR does:

Explain in a few sentences what functionality changed, and how. Can your changes be seen by a user? Then add a screenshot. Is it an interaction? Perhaps a recording.

Notes

Are there any surprises? Anything that was particularly difficult, or clever, or made you nervous, and should get particular attention during review? Call it out.

Don't forget to add the needs-review label when you're ready!


For the reviewer:

Reviewer tasks (reviewer, please merge this PR when all tasks are complete):

  • I ran the code locally
  • I performed a 5 minute walkthrough of the site looking for oddities
  • I skimmed the code; it makes sense
  • I read the code; it looks good
@egh

This comment has been minimized.

Copy link

@egh egh commented Sep 15, 2015

In our flow the author is responsible for merging - we might want to change

Reviewer tasks (reviewer, please merge this PR when all tasks are complete):

to

Reviewer tasks (author, please merge this PR when all tasks are complete):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment