Skip to content

Instantly share code, notes, and snippets.

@diox
Created February 25, 2014 16:20
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save diox/edf8713381db8fd004c0 to your computer and use it in GitHub Desktop.
Save diox/edf8713381db8fd004c0 to your computer and use it in GitHub Desktop.
diff --git a/mkt/developers/forms.py b/mkt/developers/forms.py
index 3219dbb..201f1da 100644
--- a/mkt/developers/forms.py
+++ b/mkt/developers/forms.py
@@ -928,7 +928,7 @@ class AppFormTechnical(addons.forms.AddonFormBase):
class Meta:
model = Addon
- fields = 'public_stats',
+ fields = ('public_stats',)
def __init__(self, *args, **kw):
super(AppFormTechnical, self).__init__(*args, **kw)
@@ -936,11 +936,11 @@ class AppFormTechnical(addons.forms.AddonFormBase):
def save(self, addon, commit=False):
uses_flash = self.cleaned_data.get('flash')
+ self.instance = super(AppFormTechnical, self).save(commit=True)
af = self.instance.get_latest_file()
if af is not None:
af.update(uses_flash=bool(uses_flash))
-
- return super(AppFormTechnical, self).save(commit=True)
+ return self.instance
class TransactionFilterForm(happyforms.Form):
diff --git a/mkt/developers/views.py b/mkt/developers/views.py
index bfa392b..1a66eb2 100644
--- a/mkt/developers/views.py
+++ b/mkt/developers/views.py
@@ -834,7 +834,6 @@ def addons_section(request, addon_id, addon, section, editable=False,
all_forms.append(additional_form)
if all(not f or f.is_valid() for f in all_forms):
- addon.save()
if cat_form:
cat_form.save()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment