Skip to content

Instantly share code, notes, and snippets.

@diurivj
Last active August 29, 2019 20:40
Show Gist options
  • Save diurivj/4c9b13a408b2906c68940614b048c832 to your computer and use it in GitHub Desktop.
Save diurivj/4c9b13a408b2906c68940614b048c832 to your computer and use it in GitHub Desktop.

Module 2 / Updates / Sandra, Joss, Diego

Week 4

Week4

Week 5

Week5

💡 What is the current problem in lesson X:

Node | Basic Authorization

  • Issues:
    • Complex and abstract / First look of Authorization
  • Solutions:
    • Review materials, (refactor code, syntax, grammar)

Node | Basic Authentication & Sessions

  • Issues:
    • Complex and abstract / First look of cookies
  • Solutions:
    • Review materials, (refactor code, syntax, grammar)

Passport | Sign Up, Login, Logout

  • Issues:
    • A lot of content in one learning
    • Code syntax, a lot of callbacks
    • Very complex terms (serialize and deserialize)
  • Solutions:
    • Potential to do two learnings
    • Refactor to promises and/or async
    • Passport Local Mongoose could remove this learning

Passport | Strategies and Social Login

  • Issues:
    • A lot of content in one learning (Slack and Google strategies)
    • Because GDPR and Facebook, some of this strategies doesn't work anymore, because privacy or are in maintenance
    • Code syntax
    • Some of the methods or strategies are deprecated
  • Solutions:
    • Only use Google Login, nobody uses Slack for login in other account
    • Refactor and review the code
    • Update code for the updated strategies
    • Sometimes we use firebase for social login

LAB | Authentication with passport

  • Issues:
    • Different code syntax between the starter code and the learning content
    • If we do all these changes, we have to refactor the LAB too
  • Solutions:
    • Refactor and review the code, use the same standard and code syntax

Passport | Security & Roles [FIXED] ✅

  • Issues:
    • Different code syntax between the starter code and the learning content
  • Solutions:
    • Refactor and review the code, use the same standard and code syntax

LAB | Passport Roles

💡 Restructure current lessons merge/split in more lessons:

  • Passport | Sign Up, Login, Logout

💡 What are other improvements we have in mind:

ES7 | Async / Await | NEW

  • Why:
    • It was difficult for us understand why async/await instead then/catch
    • It was difficult to know where and when use async await
    • It's difficult to identify the async function
    • We don't understand what are the differences between the async code handlers
    • It's a little bit disgusting to always have to use try/catch blocks for error handling
    • The main objective of this lesson is encourage the use of async/await over other solutions, this optimize the code reading, reduce code and we can write async code with synchronous looking like code. We also use the latest of es+ which was a concurrent commentary in the LT's feedback

Passport | Passport Local Mongoose | NEW

  • Why:
    • Passport Local Mongoose is magic, wonderful 🌈
    • With PLM, we bypass the abstract work of hashing, salting, serializing and deserializing stuff

Mapbox | NEW

  • Why:
    • A lot students uses maps
    • Google API now requests a credit card, even if it is for development purposes only, many students don't want to put their bank information for this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment