Created
June 2, 2023 19:06
-
-
Save dmose/6f6cab27729dece6c2c6cbf4100d8b1f to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diff --git a/browser/components/newtab/metrics.yaml b/browser/components/newtab/metrics.yaml | |
index 22e15feb592aa..e199c9a927ef1 100644 | |
--- a/browser/components/newtab/metrics.yaml | |
+++ b/browser/components/newtab/metrics.yaml | |
@@ -1000,7 +1000,7 @@ messaging_system: | |
- chutten@mozilla.com | |
expires: never | |
send_in_pings: | |
- - metrics | |
+ - messaging-system | |
messaging_system.attribution: | |
@@ -1114,7 +1114,7 @@ messaging_system.attribution: | |
- pmcmanis@mozilla.com | |
expires: never | |
send_in_pings: | |
- - messaging-system | |
+ - metrics | |
ua: | |
type: string | |
diff --git a/browser/components/newtab/test/xpcshell/test_AboutWelcomeTelemetry.js b/browser/components/newtab/test/xpcshell/test_AboutWelcomeTelemetry.js | |
index 5ecc20f8044b2..fe600777a6669 100644 | |
--- a/browser/components/newtab/test/xpcshell/test_AboutWelcomeTelemetry.js | |
+++ b/browser/components/newtab/test/xpcshell/test_AboutWelcomeTelemetry.js | |
@@ -45,7 +45,7 @@ add_task(async function test_pingPayload() { | |
AWTelemetry.pingCentre, | |
"sendStructuredIngestionPing" | |
); | |
- sinon.stub(AWTelemetry, "_createPing").resolves({ event: "MOCHITEST" }); | |
+ sinon.stub(AWTelemetry, "_createPing").resolves({ event: "MOCHITEST", bogus_object: {}}); | |
let pingSubmitted = false; | |
GleanPings.messagingSystem.testBeforeNextSubmit(() => { | |
@@ -54,6 +54,9 @@ add_task(async function test_pingPayload() { | |
}); | |
await AWTelemetry.sendTelemetry(); | |
+ // make sure that "invalid_nested_ping_data" is in the right place | |
+ Assert.ok("invalid_nested_ping_data" in Glean.messagingSystem); | |
+ | |
equal(stub.callCount, 1, "Call was made"); | |
// check the endpoint | |
ok( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment