https://github.com/mitchellh/mapstructure
- docker/cli
- many places in Circle, including a config library
https://github.com/dnephin/demo/blob/master/mapstructure/mapstructure_test.go
Consul config can be specified as HCL or JSON.
Last active
June 12, 2020 15:35
-
-
Save dnephin/48ccdb864ce3f0e2551f95a93da89ed8 to your computer and use it in GitHub Desktop.
mapstructure, and opaque configuration in Consul
-
HCL decodes opaque configuration to an ambiguous structure
-
Configuration fields can have multiple names
lib.TranslateKeyssits betweenlib.PatchSliceOfMapsandmapstructure.Decode
-
https://pkg.go.dev/github.com/mitchellh/mapstructure?tab=doc#DecodeHookFuncType
func(from reflect.Type, to reflect.Type, data interface{}) (interface{}, error)
- https://github.com/hashicorp/consul/blob/c66c533d/agent/config/config.go#L50-L62
- https://github.com/hashicorp/consul/blob/c66c533d/lib/decode/decode.go
- We no longer need to enumerate all of the slices in the Config
- Field aliases are enumerated on the field
- No more panic!
- https://github.com/hashicorp/consul/blob/e11c27a/lib/decode/decode.go#L117-L121
- hashicorp/consul#7935 (comment)
- https://pkg.go.dev/github.com/mitchellh/mapstructure?tab=doc#DecoderConfig
-
Maybe allow opaque config to be a string literal
-
The config checklist is still quite long
A lot more of
agent/configcan be handled by mapstructure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment