from mess to clean - showing a dev how to remove conditional logic

after

def calculate_return(last_trade) 
  send(:"calculate_#{recommendation.to_s}_return", last_trade)
end

before

def calculate_return(last_trade) 
  if long?
      calculate_long_return(last_trade)
    else
      calculate_short_return(last_trade)
    end
end