Skip to content

Instantly share code, notes, and snippets.

@dstogov

dstogov/acc_flags.diff

Created July 25, 2018 14:50
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save dstogov/3b6ae377c17524b219670960cf98f8c1 to your computer and use it in GitHub Desktop.
Save dstogov/3b6ae377c17524b219670960cf98f8c1 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
acc_flags.diff
diff --git a/Zend/zend_compile.h b/Zend/zend_compile.h
index e19702cb9a..a98f74ae20 100644
--- a/Zend/zend_compile.h
+++ b/Zend/zend_compile.h
@@ -198,116 +198,144 @@ typedef struct _zend_oparray_context {
} zend_oparray_context;
/*
- * Function and method flags
- *
* Free flags:
* 0x20
* 0x2000000
*/
-/* method flags (types) */
-#define ZEND_ACC_STATIC 0x01
-#define ZEND_ACC_ABSTRACT 0x02
-#define ZEND_ACC_FINAL 0x04
-#define ZEND_ACC_IMPLEMENTED_ABSTRACT 0x08
-/* Immutable op_array (lazy loading) */
-#define ZEND_ACC_IMMUTABLE 0x10
+/* Class, property and method flags class|meth.|prop.|const*/
+/* | | | */
+/* Common and sahred flags (8 bits) | | | */
+/* ================================ | | | */
+/* | | | */
+/* Visibility flags (public < protected < private) | | | */
+#define ZEND_ACC_PUBLIC (1 << 0) /* | X | X | X */
+#define ZEND_ACC_PROTECTED (1 << 1) /* | X | X | X */
+#define ZEND_ACC_PRIVATE (1 << 2) /* | X | X | X */
+/* | | | */
+/* Special class types | | | */
+#define ZEND_ACC_INTERFACE (1 << 0) /* X | | | */
+#define ZEND_ACC_TRAIT (1 << 1) /* X | | | */
+#define ZEND_ACC_ANON_CLASS (1 << 2) /* X | | | */
+/* | | | */
+/* Staic method or property | | | */
+#define ZEND_ACC_STATIC (1 << 3) /* | X | X | */
+/* | | | */
+/* User class has methods with static variables | | | */
+#define ZEND_HAS_STATIC_IN_METHODS (1 << 3) /* X | | | */
+/* | | | */
+/* Final class or method | | | */
+#define ZEND_ACC_FINAL (1 << 4) /* X | X | | */
+/* | | | */
+/* Shadow of parent's private method/property | | | */
+#define ZEND_ACC_SHADOW (1 << 5) /* | | X | */
+/* | | | */
+/* Abstarct method | | | */
+#define ZEND_ACC_ABSTRACT (1 << 5) /* | X | | */
+/* | | | */
+/* Class is explicitly defined as abstract by using | | | */
+/* the keyword. | | | */
+#define ZEND_ACC_EXPLICIT_ABSTRACT_CLASS (1 << 5) /* X | | | */
+/* | | | */
+/* class is abstarct, since it is set by any | | | */
+/* abstract method | | | */
+#define ZEND_ACC_IMPLICIT_ABSTRACT_CLASS (1 << 6) /* X | | | */
+/* | | | */
+/* TODO: explain the name ??? | | | */
+#define ZEND_ACC_CHANGED (1 << 6) /* | X | X | */
+/* | | | */
+/* Immutable op_array (lazy loading) | | | */
+#define ZEND_ACC_IMMUTABLE (1 << 7) /* ? | X | | */
+/* | | | */
+/* Class Flags | | | */
+/* =========== | | | */
+/* | | | */
+/* Class has magic methods __get/__set/__unset/ | | | */
+/* __isset that use guards | | | */
+#define ZEND_ACC_USE_GUARDS (1 << 8) /* X | | | */
+/* | | | */
+/* Class constants updated | | | */
+#define ZEND_ACC_CONSTANTS_UPDATED (1 << 9) /* X | | | */
+/* | | | */
+/* Bound anonymous class | | | */
+#define ZEND_ACC_ANON_BOUND (1 << 10) /* X | | | */
+/* | | | */
+/* Class extends another class | | | */
+#define ZEND_ACC_INHERITED (1 << 11) /* X | | | */
+/* Class implements interface(s) | | | */
+#define ZEND_ACC_IMPLEMENT_INTERFACES (1 << 12) /* X | | | */
+/* Class uses trait(s) | | | */
+#define ZEND_ACC_IMPLEMENT_TRAITS (1 << 14) /* X | | | */
+/* | | | */
+/* Function Flags | | | */
+/* ============== | | | */
+/* | | | */
+/* deprecation flag | | | */
+#define ZEND_ACC_DEPRECATED (1 << 8) /* | X | | */
+/* | | | */
+/* method flag (bc only), any method that has this | | | */
+/* flag can be used statically and non statically. | | | */
+#define ZEND_ACC_ALLOW_STATIC (1 << 9) /* | X | | */
+/* | | | */
+/* Function with varable number of arguments | | | */
+#define ZEND_ACC_VARIADIC (1 << 10) /* | X | | */
+/* | | | */
+/* Function returning by reference | | | */
+#define ZEND_ACC_RETURN_REFERENCE (1 << 11) /* | X | | */
+/* | | | */
+/* Function has typed arguments | | | */
+#define ZEND_ACC_HAS_TYPE_HINTS (1 << 12) /* | X | | */
+/* | | | */
+/* Function has a return type | | | */
+#define ZEND_ACC_HAS_RETURN_TYPE (1 << 13) /* | X | | */
+/* | | | */
+/* | | | */
+/* call through user function trampoline. e.g. | | | */
+/* __call, __callstatic | | | */
+#define ZEND_ACC_CALL_VIA_TRAMPOLINE (1 << 14) /* | X | | */
+/* | | | */
+/* disable inline caching | | | */
+#define ZEND_ACC_NEVER_CACHE (1 << 15) /* | X | | */
+/* op_array has finally blocks (user only) | | | */
+#define ZEND_ACC_HAS_FINALLY_BLOCK (1 << 16) /* | X | | */
+/* | | | */
+/* internal function is allocated at arena (int only) | | | */
+#define ZEND_ACC_ARENA_ALLOCATED (1 << 16) /* | X | | */
+/* | | | */
+/* "main" op_array with | | | */
+/* ZEND_DECLARE_INHERITED_CLASS_DELAYED opcodes | | | */
+#define ZEND_ACC_EARLY_BINDING (1 << 17) /* | X | | */
+/* | | | */
+#define ZEND_ACC_GENERATOR (1 << 18) /* | X | | */
+#define ZEND_ACC_CLOSURE (1 << 19) /* | X | | */
+#define ZEND_ACC_NO_RT_ARENA (1 << 20) /* | X | | */
+#define ZEND_ACC_FAKE_CLOSURE (1 << 21) /* | X | | */
+/* | | | */
+/* method flag used by Closure::__invoke() | | | */
+#define ZEND_ACC_USER_ARG_INFO (1 << 22) /* | X | | */
+/* | | | */
+/* method flags (special method detection) | | | */
+#define ZEND_ACC_CTOR (1 << 23) /* | X | | */
+#define ZEND_ACC_DTOR (1 << 24) /* | X | | */
+/* | | | */
+#define ZEND_ACC_DONE_PASS_TWO (1 << 25) /* | X | | */
+/* | | | */
+/* TODO: used only during inheritance ??? | | | */
+#define ZEND_ACC_IMPLEMENTED_ABSTRACT (1 << 26) /* | X | | */
+/* | | | */
+/* TODO: used only by ext/reflection ??? | | | */
+#define ZEND_ACC_IMPLICIT_PUBLIC (1 << 27) /* | ? | ? | ? */
+/* | | | */
+/* op_array uses strict mode types | | | */
+#define ZEND_ACC_STRICT_TYPES (1 << 31) /* | X | | */
-/* method flags (visibility) */
-/* The order of those must be kept - public < protected < private */
-#define ZEND_ACC_PUBLIC 0x100
-#define ZEND_ACC_PROTECTED 0x200
-#define ZEND_ACC_PRIVATE 0x400
-#define ZEND_ACC_PPP_MASK (ZEND_ACC_PUBLIC | ZEND_ACC_PROTECTED | ZEND_ACC_PRIVATE)
-
-#define ZEND_ACC_CHANGED 0x800
-#define ZEND_ACC_IMPLICIT_PUBLIC 0x1000
-
-/* method flags (special method detection) */
-#define ZEND_ACC_CTOR 0x2000
-#define ZEND_ACC_DTOR 0x4000
-
-/* "main" op_array with ZEND_DECLARE_INHERITED_CLASS_DELAYED opcodes */
-#define ZEND_ACC_EARLY_BINDING 0x8000
-
-/* method flag used by Closure::__invoke() */
-#define ZEND_ACC_USER_ARG_INFO 0x80
-
-/* method flag (bc only), any method that has this flag can be used statically and non statically. */
-#define ZEND_ACC_ALLOW_STATIC 0x10000
-/* shadow of parent's private method/property */
-#define ZEND_ACC_SHADOW 0x20000
-
-/* deprecation flag */
-#define ZEND_ACC_DEPRECATED 0x40000
-
-#define ZEND_ACC_CLOSURE 0x100000
-#define ZEND_ACC_FAKE_CLOSURE 0x40
-#define ZEND_ACC_GENERATOR 0x800000
-
-#define ZEND_ACC_NO_RT_ARENA 0x80000
-
-/* call through user function trampoline. e.g. __call, __callstatic */
-#define ZEND_ACC_CALL_VIA_TRAMPOLINE 0x200000
+#define ZEND_ACC_PPP_MASK (ZEND_ACC_PUBLIC | ZEND_ACC_PROTECTED | ZEND_ACC_PRIVATE)
/* call through internal function handler. e.g. Closure::invoke() */
#define ZEND_ACC_CALL_VIA_HANDLER ZEND_ACC_CALL_VIA_TRAMPOLINE
-/* disable inline caching */
-#define ZEND_ACC_NEVER_CACHE 0x400000
-
-#define ZEND_ACC_VARIADIC 0x1000000
-
-#define ZEND_ACC_RETURN_REFERENCE 0x4000000
-#define ZEND_ACC_DONE_PASS_TWO 0x8000000
-
-/* class has magic methods __get/__set/__unset/__isset that use guards */
-#define ZEND_ACC_USE_GUARDS 0x1000000
-
-/* function has typed arguments */
-#define ZEND_ACC_HAS_TYPE_HINTS 0x10000000
-
-/* op_array has finally blocks */
-#define ZEND_ACC_HAS_FINALLY_BLOCK 0x20000000
-
-/* internal function is allocated at arena */
-#define ZEND_ACC_ARENA_ALLOCATED 0x20000000
-
-/* Function has a return type (or class has such non-private function) */
-#define ZEND_ACC_HAS_RETURN_TYPE 0x40000000
-
-/* op_array uses strict mode types */
-#define ZEND_ACC_STRICT_TYPES 0x80000000
-
-/*
- * Class flags
- *
- * Classes also use the ZEND_ACC_FINAL (0x04) flag, otherwise there is no overlap.
- */
-
-/* class flags (types) */
-/* ZEND_ACC_IMPLICIT_ABSTRACT_CLASS is used for abstract classes (since it is set by any abstract method even interfaces MAY have it set, too). */
-/* ZEND_ACC_EXPLICIT_ABSTRACT_CLASS denotes that a class was explicitly defined as abstract by using the keyword. */
-#define ZEND_ACC_IMPLICIT_ABSTRACT_CLASS 0x10
-#define ZEND_ACC_EXPLICIT_ABSTRACT_CLASS 0x20
-#define ZEND_ACC_INTERFACE 0x40
-#define ZEND_ACC_TRAIT 0x80
-#define ZEND_ACC_ANON_CLASS 0x100
-#define ZEND_ACC_ANON_BOUND 0x200
-#define ZEND_ACC_INHERITED 0x400
-
-/* class implement interface(s) flag */
-#define ZEND_ACC_IMPLEMENT_INTERFACES 0x80000
-#define ZEND_ACC_IMPLEMENT_TRAITS 0x400000
-
-/* class constants updated */
-#define ZEND_ACC_CONSTANTS_UPDATED 0x100000
-
-/* user class has methods with static variables */
-#define ZEND_HAS_STATIC_IN_METHODS 0x800000
-
char *zend_visibility_string(uint32_t fn_flags);
typedef struct _zend_property_info {
diff --git a/ext/reflection/tests/ReflectionClass_getMethods_003.phpt b/ext/reflection/tests/ReflectionClass_getMethods_003.phpt
index 885bd908f1..48779de0ff 100644
--- a/ext/reflection/tests/ReflectionClass_getMethods_003.phpt
+++ b/ext/reflection/tests/ReflectionClass_getMethods_003.phpt
@@ -17,9 +17,9 @@ class C {
}
$rc = new ReflectionClass("C");
-$StaticFlag = 0x01;
-$pubFlag = 0x100;
-$privFlag = 0x400;
+$StaticFlag = ReflectionMethod::IS_STATIC;
+$pubFlag = ReflectionMethod::IS_PUBLIC;
+$privFlag = ReflectionMethod::IS_PRIVATE;
echo "No methods:";
var_dump($rc->getMethods(0));
diff --git a/ext/reflection/tests/ReflectionClass_getProperties_003.phpt b/ext/reflection/tests/ReflectionClass_getProperties_003.phpt
index ac16a68349..229e828056 100644
--- a/ext/reflection/tests/ReflectionClass_getProperties_003.phpt
+++ b/ext/reflection/tests/ReflectionClass_getProperties_003.phpt
@@ -17,9 +17,9 @@ class C {
}
$rc = new ReflectionClass("C");
-$StaticFlag = 0x01;
-$pubFlag = 0x100;
-$privFlag = 0x400;
+$StaticFlag = ReflectionProperty::IS_STATIC;
+$pubFlag = ReflectionProperty::IS_PUBLIC;
+$privFlag = ReflectionProperty::IS_PRIVATE;
echo "No properties:";
var_dump($rc->getProperties(0));
@linaori
Copy link

linaori commented Jul 25, 2018

Noticed a small typo: https://gist.github.com/dstogov/3b6ae377c17524b219670960cf98f8c1#file-acc_flags-diff-L26
sahred should be shared I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment