Dylan Garcia dylangarcia

## questions-to-ask.md

      
              1 file
            
          
              0 forks
            
          
              0 comments
            
          
              3 stars
            
          
                dylangarcia
                / questions-to-ask.md
            
            
              Last active
              July 21, 2024 06:36
            
              
                Questions to ask while writing and reviewing code
              
          
    Context

This is a list of thought-provoking questions that Engineers should ask themselves while writing code and reviewing other people's code. This list was created by Senior+ Engineers in an effort to share their experience with others.
Audience


People who are writing code but are not able to get code reviews from tenured engineers (i.e those not in an Engineering organization)
Engineers who are looking to learn from what Senior+ engineers do and apply that to their work

If you're working on a team already, ask them what they look for in Code Reviews so you can add to this list!


All Engineers!


## test.json
{
  "shipments": [
    {
      "shipmentId": 33974374,
      "orderId": 43945660,
      "orderKey": "8061c220f0794a9b92460b8bae6837e4",
      "userId": "123456AB-ab12-3c4d-5e67-89f1abc1defa",
      "orderNumber": "501-c87",
      "createDate": "2014-10-03T06:51:33.6270000",
      "shipDate": "2014-10-03",

## gist:ddf798b991f7fdd472cfe7d5ede341b8
a
	{
	"shipments": [
	{
	"shipmentId": 33974374,
	"orderId": 43945660,
	"orderKey": "8061c220f0794a9b92460b8bae6837e4",
	"userId": "123456AB-ab12-3c4d-5e67-89f1abc1defa",
	"orderNumber": "501-c87",
	"createDate": "2014-10-03T06:51:33.6270000",
	"shipDate": "2014-10-03",