Skip to content

Instantly share code, notes, and snippets.

@eblot
Created August 13, 2018 13:53
Show Gist options
  • Save eblot/cbef897bdee98859c5cc14fc22a5e4d8 to your computer and use it in GitHub Desktop.
Save eblot/cbef897bdee98859c5cc14fc22a5e4d8 to your computer and use it in GitHub Desktop.
Proposed recipe update for latest Homebrew version
$ git diff
diff --git a/pothospython.rb b/pothospython.rb
index e8b4dd4..0c08129 100644
--- a/pothospython.rb
+++ b/pothospython.rb
@@ -10,7 +10,7 @@ class Pothospython < Formula
depends_on "poco"
depends_on "nlohmann/json/nlohmann_json"
depends_on "python2" => :optional
- depends_on "python3" => :recommended
+ depends_on "python" => :recommended
def install
@@ -20,10 +20,10 @@ class Pothospython < Formula
#using --with-python3 to build bindings for python3
#its always one or the other, we cant build for both
- if build.with?("python3")
- args += ["-DPython_ADDITIONAL_VERSIONS=3"]
- else
+ if build.with?("python2")
args += ["-DPython_ADDITIONAL_VERSIONS=2"]
+ else
+ args += ["-DPython_ADDITIONAL_VERSIONS=3"]
end
mkdir "build" do
diff --git a/soapysdr.rb b/soapysdr.rb
index 041cce3..731fa51 100644
--- a/soapysdr.rb
+++ b/soapysdr.rb
@@ -8,20 +8,20 @@ class Soapysdr < Formula
depends_on "cmake" => :build
depends_on "swig" => :build
depends_on "python2" => :optional
- depends_on "python3" => :recommended
+ depends_on "python" => :recommended
def install
args = []
- if build.with?("python")
+ if build.with?("python2")
args += ["-DENABLE_PYTHON=ON"]
args += ["-DUSE_PYTHON_CONFIG=ON"]
else
args += ["-DENABLE_PYTHON=OFF"]
end
- if build.with?("python3")
+ if build.with?("python")
args += ["-DENABLE_PYTHON3=ON"]
else
args += ["-DENABLE_PYTHON3=OFF"]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment