Instantly share code, notes, and snippets.

Embed
What would you like to do?
Fixes the catalog url rewrite indexer in Magento 1.7.x-1.9.x See https://github.com/magento/bugathon_march_2013/issues/265 for details.Update: DexterDee in the ticket above noted that the previous patch had some side effects. This updated patch still feels like duct tape but at least it seems to be free of the mentioned side effects. It also fix…
diff -rupN mage_org/app/code/core/Mage/Catalog/Model/Url.php src_shop/app/code/core/Mage/Catalog/Model/Url.php
--- mage_org/app/code/core/Mage/Catalog/Model/Url.php 2013-11-19 00:48:25.679009391 +0100
+++ src_shop/app/code/core/Mage/Catalog/Model/Url.php 2013-11-19 00:49:24.188005601 +0100
@@ -643,13 +643,24 @@ class Mage_Catalog_Model_Url
$this->_rewrite = $rewrite;
return $requestPath;
}
+
+ // avoid unnecessary creation of new url_keys for duplicate url keys
+ $noSuffixPath = substr($requestPath, 0, -(strlen($suffix)));
+ $regEx = '#^('.preg_quote($noSuffixPath).')(-([0-9]+))?('.preg_quote($suffix).')#i';
+ $currentRewrite = $this->getResource()->getRewriteByIdPath($idPath, $storeId);
+ if ($currentRewrite && preg_match($regEx, $currentRewrite->getRequestPath(), $match)) {
+ $this->_rewrite = $currentRewrite;
+ return $currentRewrite->getRequestPath();
+ }
+
// match request_url abcdef1234(-12)(.html) pattern
$match = array();
$regularExpression = '#^([0-9a-z/-]+?)(-([0-9]+))?('.preg_quote($suffix).')?$#i';
if (!preg_match($regularExpression, $requestPath, $match)) {
return $this->getUnusedPath($storeId, '-', $idPath);
}
- $match[1] = $match[1] . '-';
+ $match[1] = $noSuffixPath . '-'; // always use full prefix of url_key
+ unset($match[3]); // don't start counting with a possible number in the url_key
$match[4] = isset($match[4]) ? $match[4] : '';
$lastRequestPath = $this->getResource()
@nkajic

This comment has been minimized.

nkajic commented Jan 17, 2017

Hi, just to confirm this is still a valid fix for Magento ver. 1.9.3.8. Can't belive this is still a issue in CE Thx!

@tpaaro

This comment has been minimized.

tpaaro commented May 8, 2018

This patch has a problem when the variable $noSuffixPath is empty. Magento will create faulty URL rewrites cause of that. Those faulty rewrites will consist of two elements: a dash (-) and a number. E.g. -12345.

I recommend to modify line 25:
$match[1] = $noSuffixPath . '-'; => $match[1] = ($noSuffixPath ?: $match[1]) . '-';

So incase if the $noSuffixPath variable is empty, it would use default value set in $match[1].

Otherwise this patch works and avoids creating duplicate URL rewrites (CE 1.9.3.8).

@ajbonner

This comment has been minimized.

ajbonner commented Jul 19, 2018

It's worth noting that Magento CE 1.9.3.9 makes some major changes around this code. I'm evaluating if it fixes the underlying issue so that this workaround isn't necessary anymore.

@edannenberg

This comment has been minimized.

Owner

edannenberg commented Aug 16, 2018

@ajbonner, Thanks for the heads up, any update on your findings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment