Skip to content

Instantly share code, notes, and snippets.

@eernstg
Created November 1, 2023 21:46
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save eernstg/7a593d6626af803be58b440cb58225ac to your computer and use it in GitHub Desktop.
Save eernstg/7a593d6626af803be58b440cb58225ac to your computer and use it in GitHub Desktop.
List of locations where `avoid_unstable_final_fields` emitted a warning, with a comment on each location about how to handle it.
dev/conductor/core/test/common.dart:79:11
`String? name;` could just as well be `final String? name;`
dev/conductor/core/test/common.dart:82:15
`command` could just as well be `final`
dev/conductor/core/test/common.dart:88:20
Could return `const <String>[]`.
examples/layers/rendering/src/binding.dart:39:18
Could be `late final RenderView _renderView;``
packages/flutter/lib/src/cupertino/route.dart:391:12
`_page` can be stable if `settings` is stable
`settings` inherited: `PageRoute`, `ModalRoute`, `TransitionRoute`,
`OverlayRoute`, `Route`
`settings` is clearly not stable.
So `_page` needs `@unstableGetter`.
Also, `MaterialPage.fullscreenDialog` needs `@unstableGetter`.
packages/flutter/lib/src/cupertino/slider.dart:579:19
`cursor` needs `@unstableGetter`.
`MouseTrackerAnnotation.cursor` needs `@unstableGetter`.
packages/flutter/lib/src/cupertino/slider.dart:591:30
`MouseTrackerAnnotation.onEnter` needs `@unstableGetter`.
packages/flutter/lib/src/cupertino/slider.dart:596:29
`MouseTrackerAnnotation.onExit` needs `@unstableGetter`.
packages/flutter/lib/src/cupertino/theme.dart:236:30
`NoDefaultCupertinoThemeData.textTheme` needs `@unstableGetter`.
NB: `NoDefaultCupertinoThemeData` is @immutable.
Maybe `ThemeData.textTheme` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/foundation/assertions.dart:906:14
Needs `@stableGetter`.
packages/flutter/lib/src/foundation/diagnostics.dart:2140:12
`showName` probably needs `@stableGetter`, otherwise:
`DiagnosticsNode.showName` needs `@unstableGetter`.
packages/flutter/lib/src/foundation/diagnostics.dart:2350:12
Same as previous.
packages/flutter/lib/src/foundation/diagnostics.dart:2865:28
`style`, otherwise same as previous.
packages/flutter/lib/src/material/action_chip.dart:254:15
`elevation` clearly changes based on `isEnabled`
`ChipThemeData.elevation` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/action_chip.dart:265:38
`color` clearly changes with `states`: `MaterialState.disabled`
`ChipThemeData.color` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/action_chip.dart:276:14
`shadowColor`, otherwise same as previous.
So `ChipThemeData.shadowColor` needs `@unstableGetter`.
packages/flutter/lib/src/material/action_chip.dart:281:14
`surfaceTintColor`: probably possible to keep this stable,
because `ColorScheme` is stable;
otherwise same as the other colors, needs `@unstableGetter`.
packages/flutter/lib/src/material/action_chip.dart:290:19
`ChipThemeData.side` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/action_chip.dart:297:22
`ChipThemeData.iconTheme` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/action_chip.dart:312:27
`ChipThemeData.labelPadding` probably needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/app_bar.dart:2291:14
Looks like `ColorScheme.brightness` could actually be stable,
and `backgroundColor` can be stable (might need `@stableGetter`).
packages/flutter/lib/src/material/app_bar.dart:2294:14
Looks like `ColorScheme.brightness` could actually be stable,
and `foregroundColor` can be stable (might need `@stableGetter`).
packages/flutter/lib/src/material/app_bar.dart:2337:14
`surfaceTintColor`: same as previous `surfaceTintColor`.
packages/flutter/lib/src/material/app_bar.dart:2340:22
`iconTheme` might need `@stableGetter` (or caching)
packages/flutter/lib/src/material/app_bar.dart:2346:22
`actionsIconTheme`: same as `iconTheme`, `@stableGetter` or caching.
packages/flutter/lib/src/material/badge.dart:309:18
`textTheme` no warning if `ThemeData.textTheme` gets `@unstableGetter`.
packages/flutter/lib/src/material/banner.dart:478:14
`surfaceTintColor`: same as previous `surfaceTintColor`.
packages/flutter/lib/src/material/banner.dart:481:14
`dividerColor`: can probably be made stable, if it is correct that
`ColorScheme.outlineVariant` is actually stable (and `ColorScheme`
looks rather stable overall).
packages/flutter/lib/src/material/bottom_app_bar.dart:283:14
`color` probably stable (`@stableGetter`) if `Theme.of(context)` is
immutable, or at least has an immutable `colorScheme`.
packages/flutter/lib/src/material/bottom_app_bar.dart:286:14
`surfaceTintColor` same as `color` line 283.
packages/flutter/lib/src/material/bottom_app_bar.dart:314:14
`surfaceTintColor` probably stable.
packages/flutter/lib/src/material/bottom_sheet.dart:1409:14
`surfaceTintColor` probably stable.
packages/flutter/lib/src/material/bottom_sheet.dart:1415:14
`dragHandleColor` probably needs `@stableGetter`.
packages/flutter/lib/src/material/card.dart:210:14
`color` probably stable if `Theme.of(context)` is, `@stableGetter`.
packages/flutter/lib/src/material/card.dart:213:14
`shadowColor` same as `color` line 210.
packages/flutter/lib/src/material/card.dart:239:14
`shadowColor` probably stable (because `ColorScheme` is).
packages/flutter/lib/src/material/card.dart:242:14
`surfaceTintColor` same as `shadowColor`.
packages/flutter/lib/src/material/checkbox.dart:828:32
`side` clearly unstable,
`CheckboxThemeData.side` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/checkbox.dart:844:36
`fillColor` clearly unstable.
`CheckboxThemeData.fillColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/checkbox.dart:860:36
`checkColor` probably unstable, depends on
`MaterialStateProperty.all<Color>`
`CheckboxThemeData.checkColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/checkbox.dart:865:37
`overlayColor` clearly unstable.
`CheckboxThemeData.overlayColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/checkbox.dart:911:32
`side` clearly unstable, same as previous `side`.
packages/flutter/lib/src/material/checkbox.dart:939:36
`fillColor` clearly unstable, same as `side` line 911.
packages/flutter/lib/src/material/checkbox.dart:958:36
`checkColor` clearly unstable, same as `side` line 911.
packages/flutter/lib/src/material/checkbox.dart:977:36
`overlayColor` clearly unstable, same as `side` line 911.
packages/flutter/lib/src/material/chip.dart:2267:14
`surfaceTintColor` probably stable (`ColorScheme`).
packages/flutter/lib/src/material/chip.dart:2276:19
`side` clearly unstable.
`ChipThemeData.side` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/chip.dart:2281:22
`iconTheme` clearly unstable.
`ChipThemeData.iconTheme` needs `@unstableGetter`, @immutable.
packages/flutter/lib/src/material/chip.dart:2296:27
`labelPadding` might need `@stableGetter`,
uses `MediaQuery.textScalerOf(context)`.
packages/flutter/lib/src/material/choice_chip.dart:267:15
`elevation` clearly unstable.
`ChipThemeData.elevation` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/choice_chip.dart:278:38
`color` clearly unstable.
`ChipThemeData.color` needs `@unstableGetter`.
packages/flutter/lib/src/material/choice_chip.dart:301:14
`shadowColor` might be stable, but this doesn't help:
`ChipThemeData.shadowColor` already needs stable.
packages/flutter/lib/src/material/choice_chip.dart:306:14
`surfaceTintColor` probably stable.
Looks like the `??` bug, will be stable whan that's fixed.
packages/flutter/lib/src/material/choice_chip.dart:309:14
`checkmarkColor` uses `onSecondaryContainer`, could be stable (but
is `get`), uses `??`, bug.
packages/flutter/lib/src/material/choice_chip.dart:312:14
`deleteIconColor` same as line 309, uses `onSecondaryContainer`.
packages/flutter/lib/src/material/choice_chip.dart:315:19
`side` clearly unstable.
`ChipThemeData.side` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/choice_chip.dart:322:22
`iconTheme` clearly unstable.
`ChipThemeData.iconTheme` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/choice_chip.dart:337:27
`labelPadding` can probably be stable, uses
`MediaQuery.textScalerOf(context)`,
might need `@stableGetter`.
packages/flutter/lib/src/material/date_picker_theme.dart:684:19
`cancelButtonStyle` could be stable, but we can't see it:
`DatePickerThemeData.cancelButtonStyle` needs `@stableGetter`.
packages/flutter/lib/src/material/date_picker_theme.dart:689:19
`confirmButtonStyle` needs `@stableGetter`, same reason as line 684.
packages/flutter/lib/src/material/date_picker_theme.dart:703:18
`weekdayStyle` might be stable, would need `@stableGetter`.
packages/flutter/lib/src/material/date_picker_theme.dart:711:38
`dayForegroundColor` clearly unstable.
`DatePickerThemeData.dayForegroundColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/date_picker_theme.dart:722:38
`dayBackgroundColor` clearly unstable.
`DatePickerThemeData.dayBackgroundColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/date_picker_theme.dart:731:38
`dayOverlayColor` clearly unstable.
`DatePickerThemeData.daOverlayColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/date_picker_theme.dart:758:38
`todayForegroundColor` clearly unstable.
`DatePickerThemeData.todayForegroundColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/date_picker_theme.dart:772:19
`todayBorder` unstable, but seems "morally" stable (new object same
state). Could probably have `@stableGetter`.
packages/flutter/lib/src/material/date_picker_theme.dart:799:14
`rangeSelectionBackgroundColor` same: New object, same state.
Could probably have `@stableGetter`.
packages/flutter/lib/src/material/date_picker_theme.dart:802:38
`rangeSelectionOverlayColor` clearly unstable.
`DatePickerThemeData.rangeSelectionOverlayColor` needs
`@unstableGetter`; @immutable.
packages/flutter/lib/src/material/date_picker_theme.dart:854:19
`cancelButtonStyle` could probably be stable, uses
`TextButton.styleFrom`.
Would need `@stableGetter`.
packages/flutter/lib/src/material/date_picker_theme.dart:859:19
`confirmButtonStyle` same, would need `@stableGetter`.
packages/flutter/lib/src/material/date_picker_theme.dart:867:14
`surfaceTintColor` could probably be stable, probably `??` bug.
packages/flutter/lib/src/material/date_picker_theme.dart:873:14
`headerForegroundColor` could probably be stable,
uses `_colors.onSurfaceVariant`, a `get` getter,
but we could use `@stableGetter` on that, too, (but that would
then succeed because it actually has a stable body).
Why not just change `ColorScheme.onSurfaceVariant` to
`late final Color onSurfaceVariant = _onSurfaceVariant ?? onSurface;`
which makes it stable.
Or `late final Color onSurfaceVariant;` and initialize it in constructor,
because this avoids using storage for `_onSurfaceVariant`.
packages/flutter/lib/src/material/date_picker_theme.dart:882:18
`weekdayStyle` could probably be stable,
needs `@stableGetter` because it calls a method.
packages/flutter/lib/src/material/date_picker_theme.dart:890:38
`dayForegroundColor` is clearly unstable.
`DatePickerThemeData.dayForegroundColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/date_picker_theme.dart:901:38
`dayBackgroundColor` is clearly unstable.
`DatePickerThemeData.dayBackgroundColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/date_picker_theme.dart:910:38
`dayOverlayColor` is clearly unstable.
`DatePickerThemeData.dayOverlayColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/date_picker_theme.dart:937:38
`todayForegroundColor` is clearly unstable.
`DatePickerThemeData.todayForegroundColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/date_picker_theme.dart:951:19
`todayBorder` could probably be stable, needs `@stableGetter`.
packages/flutter/lib/src/material/date_picker_theme.dart:957:38
`yearForegroundColor` clearly unstable.
`DatePickerThemeData.yearForegroundColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/date_picker_theme.dart:968:38
`yearBackgroundColor` clearly unstable.
`DatePickerThemeData.yearBackgroundColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/date_picker_theme.dart:977:38
`yearOverlayColor` clearly unstable.
`DatePickerThemeData.yearOverlayColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/date_picker_theme.dart:1010:16
`rangeSelectionBackgroundColor` could probably be stable,
uses `_colors.secondaryContainer`,
which could probably be `late final`, initialized in constructor;
there is no extra storage because `_secondaryContainer` goes away.
packages/flutter/lib/src/material/date_picker_theme.dart:1013:38
`rangeSelectionOverlayColor` clearly unstable.
`DatePickerThemeData.rangeSelectionOverlayColor`
needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/date_picker_theme.dart:1031:14
`rangePickerHeaderForegroundColor` could probably be stable,
uses `_colors.onSurfaceVariant`.
packages/flutter/lib/src/material/dialog.dart:1606:14
`backgroundColor` probably stable, uses `Theme.of(context)`;
would need `@stableGetter`.
packages/flutter/lib/src/material/dialog.dart:1609:14
`shadowColor` same, needs `@stableGetter`.
packages/flutter/lib/src/material/dialog.dart:1650:14
`surfaceTintColor` could probably be stable (`ColorScheme`).
packages/flutter/lib/src/material/dialog.dart:1677:14
`backgroundColor` could probably be stable (`Theme.of(context)`),
would need `@stableGetter`.
packages/flutter/lib/src/material/divider.dart:321:24
`color` could probably be stable (`Theme.of(context)`).
packages/flutter/lib/src/material/divider.dart:341:24
`color` same (`Theme.of(context)`).
packages/flutter/lib/src/material/drawer.dart:795:14
`shadowColor` same (`Theme.of(context)`).
packages/flutter/lib/src/material/drawer.dart:814:14
`backgroundColor` same (`Theme.of(context)`).
packages/flutter/lib/src/material/drawer.dart:817:14
`surfaceTintColor` same (`Theme.of(context)` plus `surfaceTintColor`)
packages/flutter/lib/src/material/drawer.dart:825:20
`shape` not sure, the expression might justify `@stableGetter`.
packages/flutter/lib/src/material/drawer.dart:834:20
`endShape` same as `shape` line 825.
packages/flutter/lib/src/material/elevated_button.dart:554:41
`textStyle` probably unstable, uses `MaterialStatePropertyAll<TextStyle?>`.
Could imply that `ButtonStyle.textStyle`
needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/elevated_button.dart:558:38
`backgroundColor` clearly unstable.
`ButtonStyle.backgroundColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/elevated_button.dart:567:38
`foregroundColor` clearly unstable.
`ButtonStyle.foregroundColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/elevated_button.dart:576:38
`overlayColor` clearly unstable.
`ButtonStyle.overlayColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/elevated_button.dart:591:37
`shadowColor` probably unstable, uses `MaterialStatePropertyAll<Color>`.
Could imply that `ButtonState.shadowColor` needs `@unstableGetter`;
@immutable.
packages/flutter/lib/src/material/elevated_button.dart:595:37
`surfaceTintColor` same (`MaterialStatePropertyAll<Color>`).
Could imply that `ButtonState.surfaceTintColor` needs `@unstableGetter`.
packages/flutter/lib/src/material/elevated_button.dart:599:38
`elevation` clearly unstable,
`ButtonStyle.elevation` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/elevated_button.dart:617:50
`padding` probably unstable
(uses `MaterialStatePropertyAll<EdgeInsetsGeometry>`)
Could imply that `ButtonStyle.padding` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/elevated_button.dart:637:44
`mouseCursor` clearly unstable.
`ButtonStyle.mouseCursor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/elevated_button.dart:646:22
`visualDensity` could be stable, uses `Theme.of(context)`,
would need `@stableGetter`.
packages/flutter/lib/src/material/elevated_button.dart:649:30
`tapTargetSize` same (`Theme.of(context)`).
packages/flutter/lib/src/material/elevated_button.dart:652:37
`splashFactory` same (`Theme.of(context)`).
packages/flutter/lib/src/material/expansion_tile.dart:821:14
`collapsedIconColor` could be stable,
uses `_colors.onSurfaceVariant`, we would fix that one.
packages/flutter/lib/src/material/filled_button.dart:560:41
`textStyle` probably unstable (`MaterialStatePropertyAll<TextStyle?>`).
`ButtonStyle.textStyle` would then need `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/filled_button.dart:564:38
`backgroundColor` clearly unstable.
`ButtonStyle.backgroundColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/filled_button.dart:573:38
`foregroundColor` clearly unstable.
`ButtonStyle.foregroundColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/filled_button.dart:582:38
`overlayColor` clearly unstable.
`ButtonStyle.overlayColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/filled_button.dart:597:37
`shadowColor` probably unstable (`MaterialStatePropertyAll<Color>`).
`ButtonStyle.shadowColor` would then need `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/filled_button.dart:605:38
`elevation` same as previous.
packages/flutter/lib/src/material/filled_button.dart:623:50
`padding` same as previous.
packages/flutter/lib/src/material/filled_button.dart:643:44
`mouseCursor` clearly unstable.
`ButtonStyle.mouseCursor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/filled_button.dart:652:22
`visualDensity` probably stable (`Theme.of(context)`),
would need `@stableGetter`.
packages/flutter/lib/src/material/filled_button.dart:655:30
`tapTargetSize` probably stable (`Theme.of(context)`),
would need `@stableGetter`.
packages/flutter/lib/src/material/filled_button.dart:658:37
`splashFactory` probably stable (`Theme.of(context)`),
would need `@stableGetter`.
packages/flutter/lib/src/material/filled_button.dart:682:41
`textStyle` probably unstable (`MaterialStatePropertyAll<TextStyle?>`).
`ButtonStyle.textStyle` would then need `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/filled_button.dart:686:38
`backgroundColor` clearly unstable.
`ButtonStyle.backgroundColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/filled_button.dart:695:38
`foregroundColor` clearly unstable.
`ButtonStyle.foregroundColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/filled_button.dart:704:38
`overlayColor` clearly unstable.
`ButtonStyle.overlayColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/filled_button.dart:719:37
`shadowColor` probably unstable (`MaterialStatePropertyAll<Color>`).
`ButtonStyle.shadowColor` would then need `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/filled_button.dart:727:38
`elevation` clearly unstable.
`ButtonStyle.elevation` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/filled_button.dart:745:50
`padding` probably unstable (`MaterialStatePropertyAll<EdgeInsetsGeometry>`).
Could imply that `ButtonStyle.padding` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/filled_button.dart:765:44
`mouseCursor` clearly unstable.
`ButtonStyle.mouseCursor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/filled_button.dart:774:22
`visualDensity` same as previous.
packages/flutter/lib/src/material/filled_button.dart:777:30
`tapTargetSize` same as previous.
packages/flutter/lib/src/material/filled_button.dart:780:37
`splashFactory` same as previous.
packages/flutter/lib/src/material/filter_chip.dart:293:15
`elevation` clearly unstable.
`ChipThemeData.elevation` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/filter_chip.dart:304:38
`color` clearly unstable.
`ChipThemeData.color` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/filter_chip.dart:327:14
`shadowColor` might be stable,
but `ChipThemeData.shadowColor` already needs `@unstableGetter`.
packages/flutter/lib/src/material/filter_chip.dart:332:14
`surfaceTintColor` probably stable (`ColorScheme`).
packages/flutter/lib/src/material/filter_chip.dart:335:14
`checkmarkColor` uses `onSecondaryContainer`, could be stable (but
is `get`), uses `??`, bug.
packages/flutter/lib/src/material/filter_chip.dart:338:14
`deleteIconColor` uses `onSecondaryContainer`, could be stable (but
is `get`), uses `??`, bug.
packages/flutter/lib/src/material/filter_chip.dart:341:19
`side` might be stable,
but `ChipThemeData.side` already needs `@unstableGetter`.
packages/flutter/lib/src/material/filter_chip.dart:348:22
`iconTheme` clearly unstable.
`ChipThemeData.iconTheme` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/filter_chip.dart:363:27
`labelPadding` might be stable, same as previous.
packages/flutter/lib/src/material/floating_action_button.dart:761:30
`shape` looks like it could be stable,
The problem is that `_isExtended` and `_isLarge` could be stable,
but are `get` getters. Use `@stableGetter` for this, too!
packages/flutter/lib/src/material/floating_action_button.dart:762:25
`iconSize` could be stable, same issue as line 761.
packages/flutter/lib/src/material/floating_action_button.dart:764:37
`extendedPadding` could probably be `@stableGetter`, uses `_isExtended` but
also function call.
packages/flutter/lib/src/material/floating_action_button.dart:765:28
`extendedTextStyle` could probably be `@stableGetter`, even though it
returns different instances on different invocations.
packages/flutter/lib/src/material/floating_action_button.dart:809:24
`foregroundColor` probably stable, uses `_colors.onPrimaryContainer`,
probably similar to `onSecondaryContainer`.
packages/flutter/lib/src/material/floating_action_button.dart:810:24
`backgroundColor` probably stable, uses `_colors.primaryContainer`,
probably similar to `secondaryContainer`.
packages/flutter/lib/src/material/floating_action_button.dart:811:24
`splashColor` could probably be stable, needs `@stableGetter`.
packages/flutter/lib/src/material/floating_action_button.dart:812:24
`focusColor` could probably be stable, needs `@stableGetter`.
packages/flutter/lib/src/material/floating_action_button.dart:813:24
`hoverColor` could probably be stable, needs `@stableGetter`.
packages/flutter/lib/src/material/floating_action_button.dart:839:37
`extendedPadding` could probably be `@stableGetter`, uses `_isExtended` but
also function call.
packages/flutter/lib/src/material/icon_button.dart:1108:38
`foregroundColor` clearly unstable.
`ButtonStyle.foregroundColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/icon_button.dart:1120:38
`overlayColor` clearly unstable.
`ButtonStyle.overlayColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/icon_button.dart:1183:44
`mouseCursor` clearly unstable.
`ButtonStyle.mouseCursor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/icon_button.dart:1195:30
`tapTargetSize` probably stable with `@stableGetter`,
uses `Theme.of(context)`.
packages/flutter/lib/src/material/icon_button.dart:1198:37
`splashFactory` same as line 1195.
packages/flutter/lib/src/material/icon_button.dart:1225:38
`backgroundColor` clearly unstable.
`ButtonStyle.backgroundColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/icon_button.dart:1240:38
`foregroundColor` clearly unstable.
`ButtonStyle.foregroundColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/icon_button.dart:1255:38
`overlayColor` clearly unstable.
`ButtonStyle.overlayColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/icon_button.dart:1329:44
`mouseCursor` clearly unstable.
`ButtonStyle.mouseCursor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/icon_button.dart:1341:30
`tapTargetSize` same as previous.
packages/flutter/lib/src/material/icon_button.dart:1344:37
`splashFactory` same as previous.
packages/flutter/lib/src/material/icon_button.dart:1371:38
`backgroundColor` same as previous.
packages/flutter/lib/src/material/icon_button.dart:1386:38
`foregroundColor` same as previous.
packages/flutter/lib/src/material/icon_button.dart:1401:38
`overlayColor` same as previous.
packages/flutter/lib/src/material/icon_button.dart:1475:44
`mouseCursor` same as previous.
packages/flutter/lib/src/material/icon_button.dart:1487:30
`tapTargetSize` same as previous.
packages/flutter/lib/src/material/icon_button.dart:1490:37
`splashFactory` same as previous.
packages/flutter/lib/src/material/icon_button.dart:1517:38
`backgroundColor` same as previous.
packages/flutter/lib/src/material/icon_button.dart:1532:38
`foregroundColor` same as previous.
packages/flutter/lib/src/material/icon_button.dart:1544:38
`overlayColor` same as previous.
packages/flutter/lib/src/material/icon_button.dart:1599:43
`side` clearly unstable.
`ButtonStyle.side` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/icon_button.dart:1616:44
`mouseCursor` same as previous.
packages/flutter/lib/src/material/icon_button.dart:1628:30
`tapTargetSize` same as previous.
packages/flutter/lib/src/material/icon_button.dart:1631:37
`splashFactory` same as previous.
packages/flutter/lib/src/material/input_chip.dart:269:38
`color` clearly unstable.
`ChipThemeData.color` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/input_chip.dart:293:14
`deleteIconColor` uses `_colors.onSecondaryContainer`,
would be stable when `onSecondaryContainer` is fixed.
packages/flutter/lib/src/material/input_chip.dart:296:19
`side` clearly unstable.
`ChipThemeData.side` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/input_chip.dart:303:22
`iconTheme` same as previous.
packages/flutter/lib/src/material/input_chip.dart:318:27
`labelPadding` could be stable, needs `@stableGetter`
because it uses `MediaQuery.textScalerOf(context)`.
packages/flutter/lib/src/material/input_decorator.dart:4511:18
`hintStyle` clearly unstable.
`InputDecorationTheme.hintStyle` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/input_decorator.dart:4519:18
`labelStyle` clearly unstable.
`InputDecorationTheme.labelStyle` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/input_decorator.dart:4527:18
`floatingLabelStyle` clearly unstable.
`InputDecorationTheme.floatingLabelStyle` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/input_decorator.dart:4541:18
`helperStyle` clearly unstable.
`InputDecorationTheme.helperStyle` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/input_decorator.dart:4551:18
`errorStyle` clearly unstable.
`InputDecorationTheme.errorStyle` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/input_decorator.dart:4560:14
`fillColor` clearly unstable.
`InputDecorationTheme.fillColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/input_decorator.dart:4580:14
`iconColor` clearly unstable.
`InputDecorationTheme.iconColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/input_decorator.dart:4596:14
`prefixIconColor` clearly unstable.
`InputDecorationTheme.prefixIconColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/input_decorator.dart:4612:14
`suffixIconColor` clearly unstable.
`InputDecorationTheme.suffixIconColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/input_decorator.dart:4645:18
`hintStyle` clearly unstable.
`InputDecorationTheme.hintStyle` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/input_decorator.dart:4653:14
`fillColor` clearly unstable.
`InputDecorationTheme.fillColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/input_decorator.dart:4661:19
`activeIndicatorBorder` is clearly unstable.
`InputDecorationTheme.activeIndicatorBorder` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/input_decorator.dart:4684:19
`outlineBorder` clearly unstable.
`InputDecorationTheme.outlineBorder` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/input_decorator.dart:4707:14
`iconColor` uses `_colors.onSurfaceVariant`, stable when that is fixed.
packages/flutter/lib/src/material/input_decorator.dart:4710:14
`prefixIconColor` might be stable but would need `@stableGetter`,
otherwise `InputDecorationTheme.prefixIconColor` would need
`@unstableGetter`, which would probably be fine.
packages/flutter/lib/src/material/input_decorator.dart:4715:14
`suffixIconColor` clearly unstable.
`InputDecorationTheme.suffixIconColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/input_decorator.dart:4726:18
`labelStyle` clearly unstable.
`InputDecorationTheme.labelStyle` needs @unstableGetter`; @immutable.
packages/flutter/lib/src/material/input_decorator.dart:4750:18
`floatingLabelStyle` clearly unstable.
`InputDecorationTheme.floatingLabelStyle` needs @unstableGetter`; @immutable.
packages/flutter/lib/src/material/input_decorator.dart:4774:18
`helperStyle` might be stable, but would need `@stableGetter`;
but `InputDecorationTheme.helperStyle` needs `@unstableGetter` already.
packages/flutter/lib/src/material/input_decorator.dart:4783:18
`errorStyle` might be stable, but would need `@stableGetter`;
but `InputDecorationTheme.errorStyle` needs `@unstableGetter` already.
packages/flutter/lib/src/material/list_tile.dart:1535:18
`subtitleTextStyle` could perhaps be stable,
but then needs `@stableGetter`.
packages/flutter/lib/src/material/list_tile.dart:1582:18
`titleTextStyle` same as line 1535, needs `@stableGetter`.
packages/flutter/lib/src/material/list_tile.dart:1585:18
`subtitleTextStyle` same as line 1535, needs `@stableGetter`.
packages/flutter/lib/src/material/list_tile.dart:1588:18
`leadingAndTrailingTextStyle` same as line 1535, needs `@stableGetter`.
packages/flutter/lib/src/material/list_tile.dart:1594:14
`iconColor` same as previous.
packages/flutter/lib/src/material/menu_anchor.dart:3715:37
`backgroundColor` uses `MaterialStatePropertyAll<Color?>`, probably unstable.
If so then `MenuStyle.backgroundColor` needs `@unstableGetter`.
packages/flutter/lib/src/material/menu_anchor.dart:3720:38
`shadowColor` uses `MaterialStatePropertyAll<Color?>`, probably unstable.
If so then `MenuStyle.shadowColor` needs `@unstableGetter`.
packages/flutter/lib/src/material/menu_anchor.dart:3725:38
`surfaceTintColor` uses `MaterialStatePropertyAll<Color?>`, probably unstable.
If so then `MenuStyle.surfaceTintColor` needs `@unstableGetter`.
packages/flutter/lib/src/material/menu_anchor.dart:3739:21
`visualDensity` same as previous.
packages/flutter/lib/src/material/menu_anchor.dart:3756:38
`backgroundColor` might be stable,
but `ButtonStyle.backgroundColor` already needs `@unstableGetter`.
packages/flutter/lib/src/material/menu_anchor.dart:3765:38
`elevation` might be stable,
but `ButtonStyle.elevation` already needs `@unstableGetter`.
packages/flutter/lib/src/material/menu_anchor.dart:3770:38
`foregroundColor` clearly unstable.
`ButtonStyle.foregroundColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/menu_anchor.dart:3789:38
`iconColor` clearly unstable.
`ButtonStyle.iconColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/menu_anchor.dart:3810:36
`maximumSize` might be stable, would then need `@stableGetter`.
packages/flutter/lib/src/material/menu_anchor.dart:3815:36
`minimumSize` might be stable, would then need `@stableGetter`.
packages/flutter/lib/src/material/menu_anchor.dart:3820:44
`mouseCursor` same as previous.
packages/flutter/lib/src/material/menu_anchor.dart:3832:38
`overlayColor` clearly unstable.
`ButtonStyle.overlayColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/menu_anchor.dart:3850:50
`padding` probably unstable,
uses `ButtonStyleButton<EdgeInsetsGeometry>`,
Could imply that `ButtonStyle.padding` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/menu_anchor.dart:3857:46
`shape` probably unstable,
uses `ButtonStyleButton.allOrNull<OutlinedBorder>`.
Could imply that `ButtonStyle.shape` needs @unstableGetter`; @immutable.
packages/flutter/lib/src/material/menu_anchor.dart:3862:37
`splashFactory` same as previous.
packages/flutter/lib/src/material/menu_anchor.dart:3865:30
`tapTargetSize` same as previous.
packages/flutter/lib/src/material/menu_anchor.dart:3868:41
`textStyle` probably unstable,
uses `MaterialStatePropertyAll<TextStyle?>`.
Could imply that `ButtonStyle.textStyle` needs @unstableGetter`; @immutable.
packages/flutter/lib/src/material/menu_anchor.dart:3875:22
`visualDensity` same as previous.
packages/flutter/lib/src/material/menu_anchor.dart:3919:37
`backgroundColor` probably unstable,
uses `MaterialStatePropertyAll<Color?>`.
If so then `MenuStyle.backgroundColor` needs `@unstableGetter`.
packages/flutter/lib/src/material/menu_anchor.dart:3924:38
`surfaceTintColor` probably unstable,
uses `MaterialStatePropertyAll<Color?>`.
If so then `MenuStyle.surfaceTintColor` needs `@unstableGetter`.
packages/flutter/lib/src/material/menu_anchor.dart:3929:38
`shadowColor` probably unstable,
uses `MaterialStatePropertyAll<Color?>`.
If so then `MenuStyle.shadowColor` needs `@unstableGetter`.
packages/flutter/lib/src/material/menu_anchor.dart:3941:21
`visualDensity` same as previous.
packages/flutter/lib/src/material/navigation_bar.dart:1309:24
`backgroundColor` probably stable, needs `@stableGetter`.
packages/flutter/lib/src/material/navigation_bar.dart:1311:56
`iconTheme` probably unstable,
uses `MaterialStatePropertyAll<IconThemeData>`.
If so then `NavigationBarThemeData.iconTheme`
needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/navigation_bar.dart:1318:24
`indicatorColor` probably stable, but needs `@stableGetter`.
packages/flutter/lib/src/material/navigation_bar.dart:1320:52
`labelTextStyle` probably unstable,
uses `MaterialStatePropertyAll<TextStyle?>`.
If so then `NavigationBarThemeData.labelTextStyle`
needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/navigation_bar.dart:1346:24
`surfaceTintColor` probably stable (`ColorScheme`).
packages/flutter/lib/src/material/navigation_bar.dart:1348:56
`iconTheme` clearly unstable.
`NavigationBarThemeData.iconTheme` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/navigation_bar.dart:1361:24
`indicatorColor` probably stable (`ColorScheme`), needs `@stableGetter`.
packages/flutter/lib/src/material/navigation_bar.dart:1364:52
`labelTextStyle` clearly unstable.
`NavigationBarThemeData.labelTextStyle` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/navigation_drawer.dart:711:14
`surfaceTintColor` probably stable, uses `_colors.surfaceTint`
that we will fix first:
final Color? _surfaceTint;
Color get surfaceTint => _surfaceTint ?? primary;
could become:
late final Color surfaceTint;
constructor then does
this.surfaceTint = surfaceTint ?? primary;
packages/flutter/lib/src/material/navigation_drawer.dart:717:14
`indicatorColor` probably stable, uses `_colors.secondaryContainer`.
To be fixed, same changes as with `surfaceTint`.
packages/flutter/lib/src/material/navigation_drawer.dart:720:46
`iconTheme` clearly unstable.
`NavigationDrawerThemeData.iconTheme` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/navigation_drawer.dart:734:42
`labelTextStyle` clearly unstable.
`NavigationDrawerThemeData.labelTextStyle` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/navigation_rail.dart:1058:28
`unselectedLabelTextStyle` probably stable, but needs `@stableGetter`.
packages/flutter/lib/src/material/navigation_rail.dart:1062:28
`selectedLabelTextStyle` probably stable, but needs @stableGetter`.
packages/flutter/lib/src/material/navigation_rail.dart:1066:32
`unselectedIconTheme` probably stable, but needs `@stableGetter`.
packages/flutter/lib/src/material/navigation_rail.dart:1074:32
`selectedIconTheme` probably stable, but needs @stableGetter`.
packages/flutter/lib/src/material/navigation_rail.dart:1107:28
`unselectedLabelTextStyle` probably stable, but needs `@stableGetter`.
packages/flutter/lib/src/material/navigation_rail.dart:1111:28
`selectedLabelTextStyle` probably stable, but needs @stableGetter`.
packages/flutter/lib/src/material/navigation_rail.dart:1115:32
`unselectedIconTheme` probably stable, but needs @stableGetter`.
packages/flutter/lib/src/material/navigation_rail.dart:1122:32
`selectedIconTheme` probably stable, but needs `@stableGetter`.
packages/flutter/lib/src/material/navigation_rail.dart:1129:24
`indicatorColor` probably stable,
uses `_colors.secondaryContainer`.
To be fixed as described above.
packages/flutter/lib/src/material/outlined_button.dart:485:41
`textStyle` probably unstable,
uses `MaterialStatePropertyAll<TextStyle?>`.
If so then `ButtonStyle.textStyle` would need `@unstableGetter`.
packages/flutter/lib/src/material/outlined_button.dart:493:38
`foregroundColor` clearly unstable.
But `ButtonStyle.foregroundColor` already needs `@unstableGetter`.
packages/flutter/lib/src/material/outlined_button.dart:502:38
`overlayColor` clearly unstable.
But `ButtonStyle.overlayColor` already needs `@unstableGetter`.
packages/flutter/lib/src/material/outlined_button.dart:529:50
`padding` probably unstable,
uses `MaterialStatePropertyAll<EdgeInsetsGeometry>`.
If so then `ButtonStyle.padding` will need `@unstableGetter`.
packages/flutter/lib/src/material/outlined_button.dart:543:42
`side` clearly unstable.
But `ButtonStyle.side` already needs `@unstableGetter`.
packages/flutter/lib/src/material/outlined_button.dart:556:44
`mouseCursor` clearly unstable.
But `ButtonStyle.mouseCursor` already needs `@unstableGetter`.
packages/flutter/lib/src/material/outlined_button.dart:565:22
`visualDensity` same as previous.
packages/flutter/lib/src/material/outlined_button.dart:568:30
`tapTargetSize` same as previous.
packages/flutter/lib/src/material/outlined_button.dart:571:37
`splashFactory` same as previous.
packages/flutter/lib/src/material/page.dart:199:12
`fullscreenDialog` is unstable because `_page` is unstable,
as noted earlier.
`MaterialPage.fullscreenDialog` needs `@unstableGetter`.
packages/flutter/lib/src/material/popup_menu.dart:1440:18
`textStyle` should be OK, but uses `subtitle1` which is deprecated.
TODO: What's going on here?
packages/flutter/lib/src/material/popup_menu.dart:1461:52
`labelTextStyle` clearly unstable.
`PopupMenuThemeData.labelTextStyle` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/popup_menu.dart:1475:14
`shadowColor` should be stable (`ColorScheme`).
packages/flutter/lib/src/material/popup_menu.dart:1478:14
`shadowColor` should be stable (`ColorScheme`), but
`shadow` needs to be fixed (like `surfaceTint`).
packages/flutter/lib/src/material/progress_indicator.dart:1081:13
`linearTrackColor` should be stable, uses `_colors.surfaceVariant`,
which needs to be fixed (like `surfaceTint`).
packages/flutter/lib/src/material/radio.dart:590:36
`fillColor` clearly unstable.
`RadioThemeData.fillColor` needs @unstableGetter; @immutable.
packages/flutter/lib/src/material/radio.dart:603:36
`overlayColor` clearly unstable.
`RadioThemeData.overlayColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/radio.dart:640:36
`fillColor` same as previous.
packages/flutter/lib/src/material/radio.dart:674:36
`overlayColor` same as previous.
packages/flutter/lib/src/material/search_anchor.dart:1339:38
`backgroundColor` probably unstable,
uses `MaterialStatePropertyAll<Color>`.
If so then `SearchBarThemeData.backgroundColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/search_anchor.dart:1347:37
`shadowColor` probably unstable,
uses `MaterialStatePropertyAll<Color>`.
If so then `SearchBarThemeData.shadowColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/search_anchor.dart:1351:37
`surfaceTintColor` probably unstable,
uses `MaterialStatePropertyAll<Color>`.
If so then `SearchBarThemeData.surfaceTintColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/search_anchor.dart:1355:38
`overlayColor` clearly unstable.
`SearchBarThemeData.overlayColor` needs `@unstableGetter`.
packages/flutter/lib/src/material/search_anchor.dart:1380:41
`textStyle` probably unstable,
uses `MaterialStatePropertyAll<Color>`.
If so then `SearchBarThemeData.textStyle` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/search_anchor.dart:1384:41
`hintStyle` probably unstable,
uses `MaterialStatePropertyAll<TextStyle?>`.
If so then `SearchBarThemeData.hintStyle` needs `@unstableGetter`.
packages/flutter/lib/src/material/search_anchor.dart:1421:14
`surfaceTintColor` probably stable, uses `_colors.surfaceTint`,
which should be fixed.
packages/flutter/lib/src/material/search_anchor.dart:1431:18
`headerTextStyle` probably stable, needs `@stableGetter`.
packages/flutter/lib/src/material/search_anchor.dart:1434:18
`headerHintStyle` probably stable, needs `@stableGetter`.
packages/flutter/lib/src/material/search_anchor.dart:1440:14
`dividerColor` probably stable, uses `_colors.outline`,
which needs to be fixed.
packages/flutter/lib/src/material/segmented_button.dart:766:30
`style` clearly unstable.
`SegmentedButtonThemeData.style` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/slider.dart:1928:14
`inactiveTrackColor` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/slider.dart:1931:14
`secondaryActiveTrackColor` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/slider.dart:1934:14
`disabledActiveTrackColor` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/slider.dart:1937:14
`disabledInactiveTrackColor` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/slider.dart:1940:14
`disabledSecondaryActiveTrackColor` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/slider.dart:1943:14
`activeTickMarkColor` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/slider.dart:1946:14
`inactiveTickMarkColor` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/slider.dart:1949:14
`disabledActiveTickMarkColor` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/slider.dart:1952:14
`disabledInactiveTickMarkColor` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/slider.dart:1958:14
`disabledThumbColor` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/slider.dart:1961:14
`overlayColor` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/slider.dart:1964:18
`valueIndicatorTextStyle` looks stable (`Theme.of(context)`),
needs `@stableGetter`.
packages/flutter/lib/src/material/slider.dart:1990:14
`inactiveTrackColor` looks stable, uses `_colors.surfaceVariant`
which needs to be fixed.
packages/flutter/lib/src/material/slider.dart:1993:14
`secondaryActiveTrackColor` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/slider.dart:1996:14
`disabledActiveTrackColor` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/slider.dart:1999:14
`disabledInactiveTrackColor` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/slider.dart:2002:14
`disabledSecondaryActiveTrackColor` looks stable,
needs `@stableGetter`.
packages/flutter/lib/src/material/slider.dart:2005:14
`activeTickMarkColor` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/slider.dart:2008:14
`inactiveTickMarkColor` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/slider.dart:2011:14
`disabledActiveTickMarkColor` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/slider.dart:2014:14
`disabledInactiveTickMarkColor` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/slider.dart:2020:14
`disabledThumbColor` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/slider.dart:2023:14
`overlayColor` clearly unstable.
`SliderThemeData.overlayColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/slider.dart:2038:18
`valueIndicatorTextStyle` looks stable, uses `Theme.of(context)`,
needs `@stableGetter`.
packages/flutter/lib/src/material/snack_bar.dart:856:13
`backgroundColor` could be stable, needs `@stableGetter`.
packages/flutter/lib/src/material/snack_bar.dart:861:18
`contentTextStyle` could be stable, needs `@stableGetter`.
packages/flutter/lib/src/material/snack_bar.dart:873:13
`actionTextColor` looks stable, uses `_colors.secondary`,
which is stable.
TODO: What's going on here?
packages/flutter/lib/src/material/snack_bar.dart:876:13
`disabledActionTextColor` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/snack_bar.dart:893:13
`closeIconColor` looks stable, uses `_colors.onSurface`,
which is stable.
TODO: What's going on here?
packages/flutter/lib/src/material/snack_bar.dart:914:13
`backgroundColor` looks stable, uses `_colors.inverseSurface`,
which needs to be fixed.
packages/flutter/lib/src/material/snack_bar.dart:917:13
`actionTextColor` clearly unstable.
`SnackBarThemeData.actionTextColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/snack_bar.dart:934:13
`disabledActionTextColor` looks stable, uses `_colors.inversePrimary`,
which needs to be fixed.
packages/flutter/lib/src/material/snack_bar.dart:939:17
`contentTextStyle` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/snack_bar.dart:960:14
`closeIconColor` looks stable, uses `_colors.onInverseSurface`,
which needs to be fixed.
packages/flutter/lib/src/material/switch.dart:1698:36
`thumbColor` clearly unstable.
`SwitchThemeData.thumbColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/switch.dart:1713:36
`trackColor` clearly unstable.
`SwitchThemeData.trackColor` needs `@unstableGetter`.
packages/flutter/lib/src/material/switch.dart:1736:42
`mouseCursor` very probably unstable.
`SwitchThemeData.mouseCursor` needs `@unstableGetter`.
packages/flutter/lib/src/material/switch.dart:1740:37
`overlayColor` clearly unstable.
`SwitchThemeData.overlayColor` needs `@unstableGetter`.
packages/flutter/lib/src/material/switch.dart:1773:36
`thumbColor` same as previous.
packages/flutter/lib/src/material/switch.dart:1807:36
`trackColor` same as previous.
packages/flutter/lib/src/material/switch.dart:1841:37
`trackOutineColor` clearly unstable.
`SwitchThemeData.trackOutineColor` needs `@unstableGetter`.
packages/flutter/lib/src/material/switch.dart:1854:37
`overlayColor` clearly unstable.
`SwitchThemeData.overlayColor` needs `@unstableGetter`.
packages/flutter/lib/src/material/tabs.dart:2230:14
`indicatorColor` probably stable (`Theme.of(context)`),
needs `@stableGetter`.
packages/flutter/lib/src/material/tabs.dart:2233:14
`labelColor` same as line 2230, needs `@stableGetter`.
packages/flutter/lib/src/material/tabs.dart:2236:18
`labelStyle` same as line 2230, needs `@stableGetter`.
packages/flutter/lib/src/material/tabs.dart:2239:18
`unselectedLabelStyle` same as line 2230, needs `@stableGetter`.
packages/flutter/lib/src/material/tabs.dart:2242:37
`splashFactory` same as line 2230, needs `@stableGetter`.
packages/flutter/lib/src/material/tabs.dart:2265:14
`dividerColor` looks stable, uses `_colors.surfaceVariant`,
which needs to be fixed.
packages/flutter/lib/src/material/tabs.dart:2280:14
`unselectedLabelColor` looks stable, uses `_colors.onSurfaceVariant`,
which needs to be fixed.
packages/flutter/lib/src/material/tabs.dart:2286:37
`overlayColor` clearly unstable.
`TabBarTheme.overlayColor` needs `@unstableGetter`.
packages/flutter/lib/src/material/tabs.dart:2314:37
`splashFactory` probably stable, uses `Theme.of(context)`,
needs `@stableGetter`.
packages/flutter/lib/src/material/tabs.dart:2332:14
`dividerColor` looks stable, uses `_colors.surfaceVariant`,
which needs to be fixed.
packages/flutter/lib/src/material/tabs.dart:2347:14
`unselectedLabelColor` looks stable, uses `_colors.onSurfaceVariant`,
which needs to be fixed.
packages/flutter/lib/src/material/tabs.dart:2353:37
`overlayColor` clearly unstable.
`TabBarTheme.overlayColor` needs `@unstableGetter`.
packages/flutter/lib/src/material/tabs.dart:2381:37
`splashFactory` looks stable, uses `Theme.of(context)`,
needs `@stableGetter`.
packages/flutter/lib/src/material/text_button.dart:546:41
`textStyle` probably unstable,
uses `MaterialStatePropertyAll<TextStyle?>`.
If so then `ButtonStyle.textStyle` would need `@unstableGetter`.
packages/flutter/lib/src/material/text_button.dart:554:38
`foregroundColor` clearly unstable.
But `ButtonStyle.foregroundColor` already needs `@unstableGetter`.
packages/flutter/lib/src/material/text_button.dart:563:38
`overlayColor` ..
But `ButtonStyle.overlayColor` already needs `@unstableGetter`.
packages/flutter/lib/src/material/text_button.dart:590:50
`padding` probably unstable,
uses `MaterialStatePropertyAll<EdgeInsetsGeometry>`.
If so then `ButtonStyle.padding` would need `@unstableGetter`.
packages/flutter/lib/src/material/text_button.dart:610:44
`mouseCursor` clearly unstable.
But `ButtonStyle.mouseCursor` already needs `@unstableGetter`.
packages/flutter/lib/src/material/text_button.dart:619:22
`visualDensity` looks stable, uses `Theme.of(context)`,
needs `@stableGetter`.
packages/flutter/lib/src/material/text_button.dart:622:30
`tapTargetSize` looks stable, uses `Theme.of(context)`,
needs `@stableGetter`.
packages/flutter/lib/src/material/text_button.dart:625:37
`splashFactory` looks stable, uses `Theme.of(context)`,
needs `@stableGetter`.
packages/flutter/lib/src/material/text_selection_theme.dart:159:14
`child` looks stable, creates new object,
needs `@stableGetter`.
packages/flutter/lib/src/material/theme_data.dart:2273:18
`brightness` looks stable,
could be the `??` bug.
packages/flutter/lib/src/material/time_picker.dart:3143:19
`cancelButtonStyle` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/time_picker.dart:3148:19
`confirmButtonStyle` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/time_picker.dart:3153:18
`dayPeriodBorderSide` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/time_picker.dart:3160:13
`dayPeriodColor` clearly unstable.
`TimePickerThemeData.dayPeriodColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/time_picker.dart:3193:13
`dayPeriodTextColor` clearly unstable.
`TimePickerThemeData.dayPeriodTextColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/time_picker.dart:3200:17
`dayPeriodTextStyle` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/time_picker.dart:3205:13
`dialBackgroundColor` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/time_picker.dart:3235:13
`dialTextColor` clearly unstable.
`TimePickerThemeData.dialTextColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/time_picker.dart:3255:13
`entryModeIconColor` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/time_picker.dart:3265:13
`hourMinuteColor` clearly unstable.
`TimePickerThemeData.hourMinuteColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/time_picker.dart:3299:13
`hourMinuteTextColor` clearly unstable.
`TimePickerThemeData.hourMinuteTextColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/time_picker.dart:3319:28
`inputDecorationTheme` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/time_picker.dart:3378:19
`cancelButtonStyle` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/time_picker.dart:3383:19
`confirmButtonStyle` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/time_picker.dart:3388:18
`dayPeriodBorderSide` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/time_picker.dart:3393:13
`dayPeriodColor` clearly unstable.
`TimePickerThemeData.dayPeriodColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/time_picker.dart:3406:22
`dayPeriodShape` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/time_picker.dart:3428:13
`dayPeriodTextColor` clearly unstable.
`TimePickerThemeData.dayPeriodTextColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/time_picker.dart:3456:17
`dayPeriodTextStyle` looks stable, needs `@stableGetter`.
packages/flutter/lib/src/material/time_picker.dart:3461:13
`dialBackgroundColor` looks stable, uses `_colors.surfaceVariant`
which must be fixed first.
packages/flutter/lib/src/material/time_picker.dart:3491:13
`dialTextColor` clearly unstable.
`TimePickerThemeData.dialTextColor` needs `@unstableGetter`; @immutable.
packages/flutter/lib/src/material/time_picker.dart:3516:17
`helpTextStyle` probably unstable,
uses `MaterialStateTextStyle.resolveWith(states).
`TimePickerThemeData.helpTextStyle` needs `@unstableGetter`.
packages/flutter/lib/src/material/time_picker.dart:3529:13
`hourMinuteColor` clearly unstable.
`TimePickerThemeData.hourMinuteColor` needs `@unstableGetter`.
packages/flutter/lib/src/material/time_picker.dart:3589:13
`hourMinuteTextColor` clearly unstable.
`TimePickerThemeData.hourMinuteTextColor` needs `@unstableGetter`.
packages/flutter/lib/src/material/time_picker.dart:3625:17
`hourMinuteTextStyle` probably unstable,
uses `MaterialStateTextStyle.resolveWith(states).
`TimePickerThemeData.hourMinuteTextStyle` needs `@unstableGetter`.
packages/flutter/lib/src/material/time_picker.dart:3635:28
`inputDecorationTheme` looks stable, certainly needs `@stableGetter`.
packages/flutter/lib/src/rendering/proxy_box.dart:3212:30
`onEnter` is mutable, is that really necessary?
packages/flutter/lib/src/rendering/proxy_box.dart:3221:29
`onExit` is mutable, is that really necessary?
packages/flutter/lib/src/rendering/proxy_box.dart:3224:19
`cursor` is clearly unstable.
`MouseTrackerAnnotation.cursor` needs `@unstableGetter`.
packages/flutter/lib/src/rendering/proxy_box.dart:3236:12
`validForMouseTracker` clearly unstable.
`MouseTrackerAnnotation.validForMouseTracker` needs `@unstableGetter`.
packages/flutter/lib/src/widgets/focus_scope.dart:500:13
`_descendantsAreTraversable` is clearly unstable,
is
`Focus._descendantsAreTraversable` needs `@unstableGetter`.
packages/flutter/lib/src/widgets/list_wheel_scroll_view.dart:387:11
`itemIndex` I think this one might be stable, but it would
certainly need `@stableGetter`.
packages/flutter/lib/src/widgets/page_view.dart:349:14
`viewportFraction` clearly unstable.
`PageMetrics.viewportFraction` needs `@unstableGetter`.
packages/flutter_driver/lib/src/common/fuchsia_compat.dart:41:14
`address` can certainly be implemented in a stable manner.
packages/flutter_tools/lib/src/commands/devices.dart:41:17
`deviceDiscoveryTimeout` looks stable, needs `@stableGetter`.
packages/flutter_tools/lib/src/isolated/devfs_web.dart:952:19
`shaderPathsToEvict`, seems that the set could be `const`?
packages/flutter_tools/lib/src/isolated/devfs_web.dart:955:19
`scenePathsToEvict`, seems that the set could be `const`?
packages/flutter_tools/lib/src/proxied_devices/devices.dart:252:30
`dds` probbaly stable, needs `@stableGetter`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment