Skip to content

Instantly share code, notes, and snippets.

@einnor
Last active June 8, 2020 10:17
Show Gist options
  • Save einnor/56615de4a00dd86dc04bd7ffbddfcd5b to your computer and use it in GitHub Desktop.
Save einnor/56615de4a00dd86dc04bd7ffbddfcd5b to your computer and use it in GitHub Desktop.
Pull Request Template

Pull Request Template

PR Status

  • WIP (Work In Progress)
  • RFR (Ready For Review)
  • RFM (Ready For Merging)

Summary of what this PR does

This PR implements the login flow

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Chore (non-breaking change which updates/refactors existing code, tunes performance e.t.c)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Breakdown of tasks in this PR

  • Implement login design
  • Email validation
  • Password validation
  • Handle login error
  • Handle login success

Link to Designs

Figma

Where should the reviewer start?

  • git checkout [feature/123]-bug fix
  • npm install
  • npm run test or jest tests/integration/login.test.js
  • Browse to localhost:5400/login

Any new dependencies.

Link to the related issue(s)

  • Closes #(issue)

To close an issue in another repository, use the username/repository#issue_number syntax

e.g. Closes example_user/example_repo#76

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Additional Notes

N|A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment