Skip to content

Instantly share code, notes, and snippets.

@emopers

emopers/Improvement of ByteArrayOutputStream_FlushBeforeRetreive

Last active April 26, 2016 05:32
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save emopers/356a0814dcad73e036511d5880fbdeeb to your computer and use it in GitHub Desktop.
Save emopers/356a0814dcad73e036511d5880fbdeeb to your computer and use it in GitHub Desktop.
Download ZIP
Raw
Improvement of ByteArrayOutputStream_FlushBeforeRetreive
Hi, we have an improvement to this property in order to reduce the false positives it could trigger.
This problem was found when we submitted the bug reports for this project (link: https://github.com/threerings/playn/pull/82/files).
The developer rejected our PR as `bytes`(link: https://github.com/threerings/playn/blob/98c012474b82e4cf6cb56f9ffd837f8777ab8eea/core/src/playn/core/json/JsonAppendableWriter.java#L35)
here was actually flushed after it's been casted into Flushable.
This is because JavaMOP only catches OutputStream object, while missing on the superclass Flushable of OutputStream.
We'd suggest to improve this property by also considering the supertype of the monitored object to avoid false positives triggered by type casting.
Furthermore, though this is the improvement of this specific property since we found false positives associated with it,
the formation of other properties could also consider the supertype to reduce potential false positives.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment