2018-02-25 cppcheck results for Eressea 3.15

cppcheck.txt

[src/creport.c:1090]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'.
[src/creport.c:1519]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'.
[src/gmtool.c:83]: (information) Skipping configuration 'STDIO_CP' since the value of 'STDIO_CP' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly.
[src/kernel/order.c:137]: (style) The scope of the variable 'obuf' can be reduced.
[src/kernel/save.c:1191] -> [src/kernel/save.c:1192]: (style) Variable 'sz' is reassigned a value before the old one has been used.
[src/kernel/save.c:278]: (style) The scope of the variable 'f' can be reduced.
[src/kernel/save.c:904]: (style) The scope of the variable 'line' can be reduced.
[src/kernel/save.c:1397]: (style) The scope of the variable 'bp' can be reduced.
[src/kernel/save.c:1398]: (style) The scope of the variable 'shp' can be reduced.
[src/kernel/terrain.c:74]: (style) The scope of the variable 'n' can be reduced.
[src/kernel/unit.c:935]: (style) The scope of the variable 'sn' can be reduced.
[src/kernel/unit.c:1143]: (style) The scope of the variable 'sv' can be reduced.
[src/keyword.c:55]: (style) The scope of the variable 'buffer' can be reduced.
[src/laws.c:2728]: (style) The scope of the variable 'effect' can be reduced.
[src/laws.c:3450]: (style) The scope of the variable 'token' can be reduced.
[src/magic.c:2686] -> [src/magic.c:2134]: (warning) Either the condition 'familiar' is redundant or there is possible null pointer dereference: familiar.
[src/magic.c:595]: (style) The scope of the variable 'i' can be reduced.
[src/magic.c:1391]: (style) The scope of the variable 'rc_toad' can be reduced.
[src/magic.c:1685]: (style) The scope of the variable 'i' can be reduced.
[src/magic.c:2163]: (style) The scope of the variable 'co2' can be reduced.
[src/magic.c:2246]: (style) The scope of the variable 'smd' can be reduced.
[src/main.c:105]: (style) The scope of the variable 'path' can be reduced.
[src/modules/autoseed.c:862]: (style) The scope of the variable 'n' can be reduced.
[src/modules/autoseed.c:862]: (style) The scope of the variable 'nland' can be reduced.
[src/modules/museum.c:311]: (style) The scope of the variable 'unit_cookie' can be reduced.
[src/move.c:703] -> [src/move.c:704]: (style) Variable 'harbourmaster' is reassigned a value before the old one has been used.
[src/move.c:292]: (style) The scope of the variable 'wagen_ohne_pferde' can be reduced.
[src/move.c:292]: (style) The scope of the variable 'wagen_mit_trollen' can be reduced.
[src/move.c:690]: (style) The scope of the variable 'c' can be reduced.
[src/move.c:1067]: (style) The scope of the variable 'pause' can be reduced.
[src/move.c:1678]: (style) The scope of the variable 'owner' can be reduced.
[src/move.c:330]: (style) Variable 'wagen_ohne_pferde' is assigned a value that is never used.
[src/names.c:368]: (style) Variable 'sz' is assigned a value that is never used.
[src/piracy.c:130]: (style) The scope of the variable 'saff' can be reduced.
[src/prefix.c:40]: (style) The scope of the variable 'i' can be reduced.
[src/races/zombies.c:46]: (style) The scope of the variable 'n' can be reduced.
[src/randenc.c:624]: (style) The scope of the variable 'rc' can be reduced.
[src/report.c:2277] -> [src/report.c:2283]: (warning) Either the condition 'herb' is redundant or there is possible null pointer dereference: herb.
[src/report.c:449]: (style) The scope of the variable 'itemanz' can be reduced.
[src/report.c:449]: (style) The scope of the variable 'costtyp' can be reduced.
[src/report.c:568]: (style) The scope of the variable 'buf' can be reduced.
[src/report.c:891]: (style) The scope of the variable 'dh' can be reduced.
[src/report.c:1095]: (style) The scope of the variable 'msg' can be reduced.
[src/report.c:1858]: (style) The scope of the variable 'msg' can be reduced.
[src/report.c:2015]: (style) The scope of the variable 'buf' can be reduced.
[src/report.c:2087]: (style) The scope of the variable 'subject' can be reduced.
[src/report.c:673]: (style) Variable 'indent' is assigned a value that is never used.
[src/report.c:1192]: (style) Variable 'dh' is assigned a value that is never used.
[src/reports.c:291]: (style) Assignment of function parameter has no effect outside the function.
[src/reports.c:323]: (style) The scope of the variable 'ishow' can be reduced.
[src/reports.c:578]: (style) The scope of the variable 'maxskill' can be reduced.
[src/reports.c:926]: (style) The scope of the variable 'i' can be reduced.
[src/reports.c:1864]: (style) The scope of the variable 'ref' can be reduced.
[src/reports.c:1865]: (style) The scope of the variable 's' can be reduced.
[src/reports.c:2279]: (style) The scope of the variable 'i' can be reduced.
[src/reports.c:2279]: (style) The scope of the variable 'end' can be reduced.
[src/reports.c:2279]: (style) The scope of the variable 'begin' can be reduced.
[src/skill.c:95]: (style) The scope of the variable 'buffer' can be reduced.
[src/spells.c:1886] -> [src/spells.c:1889]: (style) Variable 'rt' is reassigned a value before the old one has been used.
[src/spells.c:1994] -> [src/spells.c:2003]: (style) Variable 'ctype' is reassigned a value before the old one has been used.
[src/spells.c:540]: (style) The scope of the variable 'dh' can be reduced.
[src/spells.c:2334]: (style) The scope of the variable 'a' can be reduced.
[src/spells.c:2399]: (style) The scope of the variable 'nr' can be reduced.
[src/spells.c:5603]: (style) The scope of the variable 'sd' can be reduced.
[src/spells.c:6131]: (style) The scope of the variable 'ap' can be reduced.
[src/spells/combatspells.c:359]: (style) The scope of the variable 'du' can be reduced.
[src/spy.c:223]: (style) The scope of the variable 'level' can be reduced.
[src/study.c:478]: (style) The scope of the variable 'learnweeks' can be reduced.
[src/study.c:479]: (style) The scope of the variable 'i' can be reduced.
[src/study.c:791]: (style) Variable 'mage' is assigned a value that is never used.
[src/summary.c:80]: (style) The scope of the variable 'i' can be reduced.
[src/tools/gethash.c:10]: (style) The scope of the variable 'rot' can be reduced.
[src/triggers/changerace.c:114]: (warning) Conversion of string literal "!changerace-triggers cannot stack!" to bool always evaluates to true.
[src/util/attrib.c:186]: (style) The scope of the variable 'translate' can be reduced.
[src/util/language.c:261]: (warning) Conversion of string literal "you have to increase MAXLOCALES and recompile" to bool always evaluates to true.
[src/util/log.c:217]: (error) va_list 'copy' used before va_start() was called.
[src/util/log.c:218]: (error) va_list 'copy' used before va_start() was called.
[src/util/log.c:219]: (error) va_list 'copy' used before va_start() was called.
[src/util/log.c:28]: (information) Skipping configuration 'STDIO_CP' since the value of 'STDIO_CP' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly.
[src/util/mt19937ar.c:103]: (style) The scope of the variable 'mag01' can be reduced.
[src/util/unicode.c:111]: (style) Checking if unsigned variable 'outlen' is less than zero.
[src/vortex.c:131]: (style) The scope of the variable 'd' can be reduced.
[src/xmlreader.c:806]: (style) The scope of the variable 'appearance' can be reduced.
[src/xmlreader.c:928]: (style) The scope of the variable 'fun' can be reduced.
[src/xmlreader.c:1190]: (style) The scope of the variable 'modes' can be reduced.
[src/kernel/save.c:939]: (style) The function '_test_read_password' is never used.
[src/kernel/save.c:947]: (style) The function '_test_write_password' is never used.
[src/kernel/ally.c:45]: (style) The function 'ally_find' is never used.
[src/kernel/ally.c:67]: (style) The function 'ally_remove' is never used.
[src/tests.c:569]: (style) The function 'assert_int_parameter' is never used.
[src/tests.c:556]: (style) The function 'assert_message' is never used.
[src/tests.c:564]: (style) The function 'assert_pointer_parameter' is never used.
[src/tests.c:574]: (style) The function 'assert_string_parameter' is never used.
[src/economy.c:1151]: (style) The function 'attrib_allocation' is never used.
[src/modules/museum.c:195]: (style) The function 'create_museum' is never used.
[src/teleport.c:218]: (style) The function 'create_teleport_plane' is never used.
[src/creport.c:1755]: (style) The function 'creport_cleanup' is never used.
[src/creport.c:1702]: (style) The function 'crwritemap' is never used.
[src/attributes/dict.c:165]: (style) The function 'dict_set' is never used.
[src/tests.c:579]: (style) The function 'disabled_test' is never used.
[src/modules/autoseed.c:123]: (style) The function 'fix_all_demand' is never used.
[src/util/variant.c:78]: (style) The function 'frac_div' is never used.
[src/util/variant.c:37]: (style) The function 'frac_equal' is never used.
[src/kernel/building.c:438]: (style) The function 'free_buildings' is never used.
[src/kernel/ship.c:263]: (style) The function 'free_ships' is never used.
[src/util/mt19937ar.c:144]: (style) The function 'genrand_real1' is never used.
[src/util/mt19937ar.c:158]: (style) The function 'genrand_real3' is never used.
[src/util/mt19937ar.c:165]: (style) The function 'genrand_res53' is never used.
[src/magic.c:2489]: (style) The function 'get_clone_mage' is never used.
[src/battle.c:3333]: (style) The function 'get_fighter' is never used.
[src/kernel/item.c:571]: (style) The function 'get_item' is never used.
[src/attributes/moved.c:55]: (style) The function 'get_moved' is never used.
[src/battle.c:3007]: (style) The function 'get_side' is never used.
[src/util/base36.c:129]: (style) The function 'i10toi36' is never used.
[src/util/mt19937ar.c:74]: (style) The function 'init_by_array' is never used.
[src/study.c:822]: (style) The function 'inject_learn' is never used.
[src/kernel/curse.c:675]: (style) The function 'is_cursed_internal' is never used.
[src/kernel/config.c:523]: (style) The function 'join_path' is never used.
[src/economy.c:1073]: (style) The function 'leveled_allocation' is never used.
[src/util/log.c:306]: (style) The function 'log_level' is never used.
[src/util/log.c:266]: (style) The function 'log_printf' is never used.
[src/util/message.c:32]: (style) The function 'mt_name' is never used.
[src/util/nrmessage.c:164]: (style) The function 'nr_level' is never used.
[src/util/password.c:8]: (style) The function 'password_is_implemented' is never used.
[src/kernel/order.c:493]: (style) The function 'push_order' is never used.
[src/listbox.c:57]: (style) The function 'push_selection' is never used.
[src/kernel/race.c:243]: (style) The function 'racelist_clear' is never used.
[src/util/rand.c:128]: (style) The function 'random_source_inject_array' is never used.
[src/kernel/faction.c:169]: (style) The function 'random_unit_in_faction' is never used.
[src/kernel/rules.c:8]: (style) The function 'read_rules' is never used.
[src/jsreport.c:87]: (style) The function 'register_jsreport' is never used.
[src/items/speedsail.c:74]: (style) The function 'register_speedsail' is never used.
[src/battle.c:964]: (style) The function 'rel_dam' is never used.
[src/util/event.c:255]: (style) The function 'remove_triggers' is never used.
[src/laws.c:1709]: (style) The function 'rename_building' is never used.
[src/report.c:2406]: (style) The function 'report_cleanup' is never used.
[src/kernel/connection.c:92]: (style) The function 'resolve_borderid' is never used.
[src/move.c:2020]: (style) The function 'run_to' is never used.
[src/gmtool.c:1515]: (style) The function 'seed_players' is never used.
[src/kernel/item.c:578]: (style) The function 'set_item' is never used.
[src/attributes/moved.c:60]: (style) The function 'set_moved' is never used.
[src/attributes/movement.c:61]: (style) The function 'set_movement' is never used.
[src/util/strings.c:114]: (style) The function 'set_string' is never used.
[src/spells/combatspells.c:541]: (style) The function 'sp_mindblast' is never used.
[src/tests.c:540]: (style) The function 'test_clear_messagelist' is never used.
[src/tests.c:279]: (style) The function 'test_create_building' is never used.
[src/tests.c:365]: (style) The function 'test_create_castorder' is never used.
[src/tests.c:147]: (style) The function 'test_create_faction' is never used.
[src/tests.c:74]: (style) The function 'test_create_ocean' is never used.
[src/tests.c:80]: (style) The function 'test_create_plain' is never used.
[src/tests.c:293]: (style) The function 'test_create_ship' is never used.
[src/tests.c:403]: (style) The function 'test_create_silver' is never used.
[src/tests.c:374]: (style) The function 'test_create_spell' is never used.
[src/tests.c:155]: (style) The function 'test_create_unit' is never used.
[src/tests.c:426]: (style) The function 'test_create_world' is never used.
[src/tests.c:535]: (style) The function 'test_find_messagetype' is never used.
[src/tests.c:492]: (style) The function 'test_get_last_message' is never used.
[src/tests.c:245]: (style) The function 'test_inject_messagetypes' is never used.
[src/tests.c:168]: (style) The function 'test_log_start' is never used.
[src/tests.c:172]: (style) The function 'test_log_stop' is never used.
[src/tests.c:250]: (style) The function 'test_setup_test' is never used.
[src/tests.c:262]: (style) The function 'test_teardown' is never used.
[src/triggers/gate.c:106]: (style) The function 'trigger_gate' is never used.
[src/modules/xmas.c:68]: (style) The function 'trigger_xmasgate' is never used.
[src/reports.c:1085]: (style) The function 'ucansee' is never used.
[src/util/unicode.c:80]: (style) The function 'unicode_utf8_tolower' is never used.
[src/kernel/unit.c:571]: (style) The function 'usettarget' is never used.
[src/kernel/unit.c:561]: (style) The function 'utarget' is never used.
[src/util/strings.c:228]: (style) The function 'wang_hash' is never used.
[src/modules/museum.c:141]: (style) The function 'warden_add_give' is never used.
(information) Cppcheck cannot find all the include files (use --check-config for details)