Skip to content

Instantly share code, notes, and snippets.

View epidemian's full-sized avatar

Demian Ferreiro epidemian

View GitHub Profile
@epidemian
epidemian / speed.md
Last active October 23, 2019 02:42 — forked from scvsoft-marianovicente/speed.md
How to speed up PRs Approves.

How to speed up PR approvals

Since GitHub became popular, so did the concept of pull request (PR) for shipping code. In order to get the benefits of code review we use PRs as a way to review what we deliver.

In this process at least 2 humans are involved[1]:

A requester (who asks for the code review), and a reviewer (who does the code review).

But sometimes a reviewer can have a lot to review, or a requester can ask for something that requieres significant effort to understand and round trips between the two parts. So it ends up costing a lot of human time and effort.

@epidemian
epidemian / authenticated.rb
Last active August 14, 2018 01:50 — forked from jc00ke/authenticated.rb
Using RSpec mocks instead of a dynamic module and module prepend
# spec/support/authenticated.rb
RSpec.shared_context "authenticated", shared_context: :metadata do
before do
allow_any_instance_of(described_class).to receive(:current_user) { current_uset }
end
end