Last active
March 13, 2020 06:40
-
-
Save ericjeker/a63e87d3f5536f33b0250f183338eff7 to your computer and use it in GitHub Desktop.
Example of a bad Angular component
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @Component({ | |
| selector: 'app-page-list', | |
| templateUrl: 'page-list.component.html', | |
| stylesUrl: 'page-list.component.scss' | |
| }) | |
| class PageList { | |
| title: string; | |
| actions: []; | |
| dataset: []; | |
| // that's too many booleans | |
| diplayFilters: boolean; | |
| displaySearch: boolean; | |
| displaySort: boolean; | |
| displayPagination: boolean; | |
| canEditRow: boolean; | |
| canDeleteRow: boolean; | |
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <app-page-list title="" actions="" dataset="" | |
| displayFilters="" displaySearch="" canEditRow="" ...></app-page-list> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment