ericoporto

.\test\runner browser.test_sdl2_mixer_music_mp3
Test suites:
['test_browser']
Running test_browser: (1 tests)
(checking sanity from test runner)
shared:INFO: (Emscripten: Running sanity checks)
[Browser harness server on process 19864]
common:INFO: Launching browser: ['C:\\Program Files\\Google\\Chrome\\Application\\chrome.exe']

Running the browser tests. Make sure the browser allows popups from localhost.

ericoporto

.\test\runner browser.test_sdl2_*
Test suites:
['test_browser']
Running test_browser: (48 tests)
(checking sanity from test runner)
shared:INFO: (Emscripten: Running sanity checks)
[Browser harness server on process 17704]
common:INFO: Launching browser: ['C:\\Program Files\\Google\\Chrome\\Application\\chrome.exe']

Running the browser tests. Make sure the browser allows popups from localhost.

ericoporto

.\test\runner browser.test_sdl2_*
Test suites:
['test_browser']
Running test_browser: (48 tests)
(checking sanity from test runner)
shared:INFO: (Emscripten: Running sanity checks)
[Browser harness server on process 6876]
common:INFO: Launching browser: ['C:\\Program Files\\Google\\Chrome\\Application\\chrome.exe']

Running the browser tests. Make sure the browser allows popups from localhost.

ericoporto

[82/107] Compiling C object tests/checkasm.exe.p/checkasm_checkasm.c.obj
FAILED: tests/checkasm.exe.p/checkasm_checkasm.c.obj
"cc" "-Itests/checkasm.exe.p" "-Itests" "-I../tests" "-I." "-I.." "-Iinclude/dav1d" "-I../include/dav1d" "-Iinclude" "-I../include" "-fdiagnostics-color=always" "-DNDEBUG" "-D_FILE_OFFSET_BITS=64" "-Wall" "-Winvalid-pch" "-Wextra" "-std=c99" "-O3" "-fvisibility=hidden" "-Wundef" "-Werror=vla" "-Wno-maybe-uninitialized" "-Wno-missing-field-initializers" "-Wno-unused-parameter" "-Wstrict-prototypes" "-Werror=missing-prototypes" "-fomit-frame-pointer" "-ffast-math" -MD -MQ tests/checkasm.exe.p/checkasm_checkasm.c.obj -MF "tests/checkasm.exe.p/checkasm_checkasm.c.obj.d" -o tests/checkasm.exe.p/checkasm_checkasm.c.obj "-c" ../tests/checkasm/checkasm.c
../tests/checkasm/checkasm.c: In function ΓÇÿsignal_handlerΓÇÖ:
../tests/checkasm/checkasm.c:504:29: error: variable ΓÇÿdefault_saΓÇÖ has initializer but incomplete type
  504 |         static const struct sigaction default_sa = { .sa_handler 

ericoporto

Describe the problem

The Dialog Scripts are great for writing dialog lines. But sometimes one wants to handle the logic of which dialog to run from elsewhere, like a Room Script. For a character that only exists in a room, or for a particular scene, it's useful to hold all dialogs in the same dialog script, so one doesn't have to open many different dialog scripts.

---

Suggested change

If possible to either add a parameter in dialog start or create a new dialog.Run(int x).

ericoporto

cd Android && ./and-build.sh build_debug
building debug library and runtime...
/tmp/cirrus-ci-build/Android /tmp/cirrus-ci-build/Android
/tmp/cirrus-ci-build/Android/agsplayer /tmp/cirrus-ci-build/Android /tmp/cirrus-ci-build/Android
Downloading https://services.gradle.org/distributions/gradle-8.3-bin.zip
............10%............20%.............30%............40%.............50%............60%.............70%............80%.............90%............100%

Welcome to Gradle 8.3!

Here are the highlights of this release:

ericoporto

The following part of jjsat commit here https://github.com/jjsat/ags/commit/22221b6d3ebffdd7c7e32e5ccb95a590e5a8307a#diff-4db3d150dec6fcd9180c42130e5d06d6f11649403d1a1d46700564785284e0dbR1456-R1481

We see that load.sp.offs was used to load the value of the stack pointer (SP) with an offset, moving the stack pointer up or down.

But then, after the commit, it changed from

case SCMD_LOADSPOFFS:
  inst->registers[SREG_MAR] = inst->registers[SREG_SP] - arg1;

ericoporto

Error: Object reference not set to an instance of an object.
Version: AGS 3.6.0.48

System.NullReferenceException: Object reference not set to an instance of an object.
   at WeifenLuo.WinFormsUI.Docking.DockContentHandler.SetDockState(Boolean isHidden, DockState visibleState, DockPane oldPane)
   at WeifenLuo.WinFormsUI.Docking.DockContent.Hide()
   at AGS.Editor.WindowsMenuManager.DockPane_CheckedChanged(Object sender, EventArgs e)
   at System.Windows.Forms.ToolStripMenuItem.OnCheckedChanged(EventArgs e)
   at System.Windows.Forms.ToolStripMenuItem.set_CheckState(CheckState value)
   at System.Windows.Forms.ToolStripMenuItem.set_Checked(Boolean value)

ericoporto

#include "pch.h"
#include <iostream>
#include <map>
#include <string>


// virtual CPU registers
#define SREG_SP           1     // stack pointer
#define SREG_MAR          2     // memory address register
#define SREG_AX           3     // general purpose

ericoporto

inline bool FixupArgument(char fixup, ScriptOperation& codeOp, int argIndex, ccInstance* codeInst, ccInstance& c_this, int pc_at) {
    using FixupFunc = std::function<bool(ScriptOperation&, int, ccInstance*, ccInstance&, int)>;

    // #define FIXUP_GLOBALDATA  1     // code[fixup] += &globaldata[0]
    // #define FIXUP_FUNCTION    2     // code[fixup] += &code[0]
    // #define FIXUP_STRING      3     // code[fixup] += &strings[0]
    // #define FIXUP_IMPORT      4     // code[fixup] = &imported_thing[code[fixup]]
    // #define FIXUP_DATADATA    5     // globaldata[fixup] += &globaldata[0]
    // #define FIXUP_STACK       6     // code[fixup] += &stack[0]