Skip to content

Instantly share code, notes, and snippets.

Avatar
💭
I may be slow to respond.

Eunsoo Park (Evan) esevan

💭
I may be slow to respond.
View GitHub Profile
@esevan
esevan / pr_etiquette.md
Created Sep 29, 2020 — forked from mikepea/pr_etiquette.md
Pull Request Etiquette
View pr_etiquette.md

Pull Request Etiquette

Why do we use a Pull Request workflow?

PRs are a great way of sharing information, and can help us be aware of the changes that are occuring in our codebase. They are also an excellent way of getting peer review on the work that we do, without the cost of working in direct pairs.

Ultimately though, the primary reason we use PRs is to encourage quality in the commits that are made to our code repositories

Done well, the commits (and their attached messages) contained within tell a story to people examining the code at a later date. If we are not careful to ensure the quality of these commits, we silently lose this ability.

@esevan
esevan / pr_etiquette.md
Created Sep 29, 2020 — forked from mikepea/pr_etiquette.md
Pull Request Etiquette
View pr_etiquette.md

Pull Request Etiquette

Why do we use a Pull Request workflow?

PRs are a great way of sharing information, and can help us be aware of the changes that are occuring in our codebase. They are also an excellent way of getting peer review on the work that we do, without the cost of working in direct pairs.

Ultimately though, the primary reason we use PRs is to encourage quality in the commits that are made to our code repositories

Done well, the commits (and their attached messages) contained within tell a story to people examining the code at a later date. If we are not careful to ensure the quality of these commits, we silently lose this ability.

@esevan
esevan / prepull.yaml
Created Feb 28, 2019 — forked from itaysk/prepull.yaml
Kubernetes: Pre-pull images into node
View prepull.yaml
apiVersion: apps/v1
kind: DaemonSet
metadata:
name: prepull
annotations:
source: "https://gist.github.com/itaysk/7bc3e56d69c4d72a549286d98fd557dd"
spec:
selector:
matchLabels:
name: prepull