Skip to content

Instantly share code, notes, and snippets.

@eshacker
Last active March 2, 2016 07:24
  • Star 1 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
Star You must be signed in to star a gist
Save eshacker/be153d852b9b995f42dd to your computer and use it in GitHub Desktop.
Wrong versus right way to do OO in JS
/* Reading https://drboolean.gitbooks.io/mostly-adequate-guide/content/ch1.html
* I have a differing opinion. Please help in sorting it out.
*/
// Original code : or I think wrong way to to Object Oriented code.
var Flock = function(n) {
this.seagulls = n;
};
Flock.prototype.conjoin = function(other) {
this.seagulls += other.seagulls;
return this;
};
Flock.prototype.breed = function(other) {
this.seagulls = this.seagulls * other.seagulls;
return this;
};
var flock_a = new Flock(4);
var flock_b = new Flock(2);
var flock_c = new Flock(0);
var result = flock_a.conjoin(flock_c)
.breed(flock_b).conjoin(flock_a.breed(flock_b)).seagulls;
console.log(result); // 32
// --------------------------------------------------------------------//
// My code or the way I think to right way to do OOC
var Flock = function(n) {
this.seagulls = n;
};
Flock.prototype.conjoin = function(other) {
return new Flock(this.seagulls + other.seagulls);
};
Flock.prototype.breed = function(other) {
return new Flock(this.seagulls * other.seagulls);
};
var flock_a = new Flock(4);
var flock_b = new Flock(2);
var flock_c = new Flock(0);
var result = flock_a.conjoin(flock_c)
.breed(flock_b).conjoin(flock_a.breed(flock_b)).seagulls;
console.log(result); //16
@eshacker
Copy link
Author

Though I might be completely wrong about OO and might be pursuing immutability.

@DrBoolean
Copy link

Yes, that's in favor of immutibilty and good code. The example is supposed to be as unreasonable as possible - not good OO by any means. It's supposed to show a very, very common style of programming, not an OO vs FP thing.

@eshacker
Copy link
Author

@DrBoolean Since you are here, If we make objects immutable, aren't we halfway functional? and, I understand that it shouldn't be an OO vs FP thing.

@eshacker
Copy link
Author

I'd have better OO example that really throws light on problems OO solve, and then reason why we need functional way of thinking. Think, if villain in Terminator 2 was weaker, would we have loved the heroic acts that much?

@eshacker
Copy link
Author

Flock.prototype.conjoin = function(other) {
  return new Flock(this.seagulls + other.seagulls);
};

Flock.prototype.breed = function(other) {
  return new Flock(this.seagulls * other.seagulls);
};

For the incessant optimizer in me.

@ananthhh
Copy link

conjoin and breed are not pure functions. They depend on mutable variable this.seagulls
flock_a.confoin(flock_b) don't always return same result. If value of seagulls in flock_a is changed, then return value will differ.

Check chapter 3 in the book. Author clearly explained this scenario. He recommends you to use Object.freeze.

@sleepyfox
Copy link

Yes the problem with Object.freeze is that a) things can get to the Object before it is frozen and b) attempts to modify the frozen object silently succeed, even without changing anything and without generating any error condition/exception or similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment