If a program needs to make an API call, it is very likely that there is an ApiClient class to make http requests.
let api = new ApiClient('https://api.bank.com')
let bank = new BankFacade(api)
Since I consider an http request as something very basic in any app, I like having this in my runtime
$runtime.services.httpRequest()
The ApiClient has a static dependecy on that global dependency.
Originally I thought it was a great idea becase that way I knew if any part of my code had to make an http request, sooner or later it would go through that point.
Having that point makes easy mocking http requests. However I realized later one should not be mocking http calls. Instead I should mock the objects from those calls.
Despite the code smell I keep using this strategy for two reasons
- I like being able to mock http calls when I prototype code
- I have a way to throw an error if a test makes an unexpected API call to the outside request.
Nowdays I enforce some light 'test' awareness in my code.
- Outside world actions (http request, shell, filesystem access...) will fail if the code runs in a testing environment
- Each service can encode some fake/mock factory with common testing needs