Skip to content

Instantly share code, notes, and snippets.

@flav

flav/code_review.md

Last active January 4, 2019 13:48
Show Gist options
  • Save flav/9a594a9326633ce81c82bcfba763852e to your computer and use it in GitHub Desktop.
Save flav/9a594a9326633ce81c82bcfba763852e to your computer and use it in GitHub Desktop.
Download ZIP
Raw
code_review.md

This is a set of ‘statuses’ that pull request comments should be marked with to help explain intent.

via Scaling Square Register on objc.io

  • Required: this must be fixed before merge
  • Nice to have: this should be fixed eventually
  • A personal preference: I would do this, but you don’t have to.
  • A question: What does this do?
  • A change: I have pushed a set of changes that I want to call out
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment