Skip to content

Instantly share code, notes, and snippets.

View foxwellm's full-sized avatar

Matthew Foxwell foxwellm

View GitHub Profile
@foxwellm
foxwellm / code-review-checklist.md
Last active December 10, 2018 18:42 — forked from JustinD85/code-review-checklist.md
Code Review Checklist

Would like reviewed:

  • https://github.com/JustinD85/jeopardy
  • How can we improve transitioning from clue -> wager -> answer -> answered when someone clicks a clue

    Make sure max value aligns to spec, consider popups instead of creatind it inside the squares.

  • Does the flow of the game make sense?

    Not applicable at the current state of the game. Testing functionality is their current position.

  • Suggestions for next steps

    Clear answered questions/ implement rounds/ create more visually appealing UI/UX.

  • Improvements where we could possibly use a utility function to shorten overall code length, maintaining readability

Consider using class inheretence rather than utility functions to better achieve learning objectives.

@foxwellm
foxwellm / code-review-checklist.md
Last active December 10, 2018 18:43 — forked from thatPamIAm/code-review-checklist.md
Code Review Checklist

What we would like reviewed

where would you see places where JQuery would help? How's our classes looking, planning on using DailyDouble Class and then Round3 as a sub class. Any unintuitive gameplay that glares out.

5 mins

  • Get together with your group and send a link of your team's GitHub Repo to the pair that is reviewing your project.
  • Look over this guide with your project partner and highlight the pieces where your team can use assistance/you would like your reviewers to take a closer look. Fork this gist and send the forked copy over to the pair reviewing your code.

45 mins