Skip to content

Instantly share code, notes, and snippets.

Embed
What would you like to do?
Performance patch for ruby 1.9.3-p385
@stefan-mees

This comment has been minimized.

Copy link

stefan-mees commented Feb 26, 2013

please be aware of https://gist.github.com/funny-falcon/4136519/#comment-782869, the same applies for this patch version

@johnl

This comment has been minimized.

Copy link

johnl commented Mar 6, 2013

I can reproduce this memory leak with version of the patch going back to 1.9.3-p327 (it definitely isn't present in builds without the patch)

@funny-falcon

This comment has been minimized.

Copy link
Owner Author

funny-falcon commented Mar 11, 2013

@johnl could you try again? @tmm1 just found memory leak which affects #methods #instance_methods , I've updated patches (sparse_array, st_opt_sparse_array, falcon and falcon-gc, for this version only)

@funny-falcon

This comment has been minimized.

Copy link
Owner Author

funny-falcon commented Mar 11, 2013

@johnl if memory leak remains, tell me the way to reproduce it.

@skaes

This comment has been minimized.

Copy link

skaes commented Mar 14, 2013

I found two memleaks in class.c, introduced by the sparse array patch:

Here's a fix: skaes/rvm-patchsets@1f94ce6

@skaes

This comment has been minimized.

Copy link

skaes commented Mar 14, 2013

Ah, sorry, you already found these, I think.

@funny-falcon

This comment has been minimized.

Copy link
Owner Author

funny-falcon commented Mar 14, 2013

@skaes, excuse me that I'm not pushes it for you. I was busy at work and didn't found time to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.