FreeCAD new stylesheet issues

stylesheet-issues.md

Tested with Qt6 and Fusion as Qt Style.

• Disappearing down arrow icon in toolbars:
• Unnecessary padding for toolbar icons:
• Hard to read text in hovered menu entries due to low contrast:
• No padding for tool buttons in the status area:

• Unnecessary border for toolbars in QStatusBar and QMenuBar:
• hovering over table rows highlights only cell:

• Unreadable Combo Box list due to low contrast:

• Controls could use a bit more horizontal padding to look better and be more readable (https://medium.com/@manonpiette.pro/margins-and-padding-e4e9d0efa65d):

• Checkboxes are quite small - it would be wise to make them a bit bigger.

• Radio buttons are not rendered well:

![image](https://private-user-images.githubusercontent.com/747404/340444754-a74b17da-d6d5-417a-8efe-bda439699d95.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk5Nzc5MjYsIm5iZiI6MTcxOTk3NzYyNiwicGF0aCI6Ii83NDc0MDQvMzQwNDQ0NzU0LWE3NGIxN2RhLWQ2ZDUtNDE3YS04ZWZlLWJkYTQzOTY5OWQ5NS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcwM1QwMzMzNDZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01ZjNjMDM3MGRhNDA4MWQ2NWJiNWY4NjMyZWIxMjJjYWQ2MTE1NTBmMmU0YTY4NjAxMWFlMDBlNjJjMmJkMmNhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.rBXUhXXh8L3x5FwkZjdrJz6TZdjteR-A_olTB802WOg)

• Spacing for buttons in spinboxes is uneven:

![image](https://private-user-images.githubusercontent.com/747404/340444894-24b4c4cd-efa8-4c7d-b728-cc9fc7252755.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk5Nzc5MjYsIm5iZiI6MTcxOTk3NzYyNiwicGF0aCI6Ii83NDc0MDQvMzQwNDQ0ODk0LTI0YjRjNGNkLWVmYTgtNGM3ZC1iNzI4LWNjOWZjNzI1Mjc1NS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcwM1QwMzMzNDZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xMGVjZjRlMDYxYTY1ZDg1ODU4YjJhMWRiOGIyZmQwNzE0M2E0MjJlZjZiMWEzYTk0YTA0NjJmOTFlNzZlNjE3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.fQgOICW7ldHMbvSIiMp3QhWeKE7eYNrceSTZG17d1jg)

• Hovering over treeview in overlay mode hovers whole row (probably Qt6 issue, see: Qt6: Rendering of overlay TreeView is broken  #13760):

![image](https://private-user-images.githubusercontent.com/747404/340445114-65219087-3965-4030-ab90-f51fbcd0a367.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk5Nzc5MjYsIm5iZiI6MTcxOTk3NzYyNiwicGF0aCI6Ii83NDc0MDQvMzQwNDQ1MTE0LTY1MjE5MDg3LTM5NjUtNDAzMC1hYjkwLWY1MWZiY2QwYTM2Ny5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcwM1QwMzMzNDZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05NTgyYWM3ODMxNzkxZjYwZTg2NDVkYTE3YzZiMDZiZDMyYmQ0NGE1Nzc3MGQwNDQ4YWZhZjc3OWE2MGFjYmU0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.e1dLJc8YuVYXQhGjMrUpqKSP76Sm1pr3fJp6mfMMFvQ)

• Buttons in task panel have broken laoyut:

![image](https://private-user-images.githubusercontent.com/747404/340445353-d65fc4a9-27ed-43a1-b4aa-30fd28f990e5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk5Nzc5MjYsIm5iZiI6MTcxOTk3NzYyNiwicGF0aCI6Ii83NDc0MDQvMzQwNDQ1MzUzLWQ2NWZjNGE5LTI3ZWQtNDNhMS1iNGFhLTMwZmQyOGY5OTBlNS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcwM1QwMzMzNDZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00YTk1YmEwZDkxNmZhYzg0MGNjNTc1MTI4ZTUzZWYyYmFiN2Y2NmRiZGZiMGQxODFjZTBlY2U0Zjk4OGJlODcyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.mrL3KRjgHVX4-MuxWFHcldHzUo7CI88AnPUymjEEMtE)

• Expression icon is not aligned vertically:

![image](https://private-user-images.githubusercontent.com/747404/340445446-427a3e32-1056-4d7a-a5ef-0d51ad957817.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk5Nzc5MjYsIm5iZiI6MTcxOTk3NzYyNiwicGF0aCI6Ii83NDc0MDQvMzQwNDQ1NDQ2LTQyN2EzZTMyLTEwNTYtNGQ3YS1hNWVmLTBkNTFhZDk1NzgxNy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcwM1QwMzMzNDZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iNDIyNDQ3OTk2ZTE1ZDFkYjZmYTk3YTVmOTRkMGUyZTczYmQyYjk3MGYxZjBmMWNjYTFkN2M4NzlhNzA0MTU3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.hzaEDv4ly5RuKKH9FGPvjJu0nVrHfPrWIK5hKFcz4oI)

• Scrollbar border is uneven (look at top button):

![image](https://private-user-images.githubusercontent.com/747404/340445578-382c3ed4-601c-44d3-a5a9-8a1637a8262a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk5Nzc5MjYsIm5iZiI6MTcxOTk3NzYyNiwicGF0aCI6Ii83NDc0MDQvMzQwNDQ1NTc4LTM4MmMzZWQ0LTYwMWMtNDRkMy1hNWE5LThhMTYzN2E4MjYyYS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcwM1QwMzMzNDZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05ZTY3YzQ1MmRhNzYzNWY5ZjAyOTdhYTBmMDZiM2E5NmFlYjBmZTYxZmUyM2E2YTdiZDVhYWUyMjQxOGY2NWU0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.7YxxcijzUps_WQifCeUWDR90bMGgSywWbPlbXbypbEw)

• Yellow for marking "clicked" button in overlay panels seems very odd:

![image](https://private-user-images.githubusercontent.com/747404/340445791-895bef58-6393-440d-b794-87e8bb960582.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk5Nzc5MjYsIm5iZiI6MTcxOTk3NzYyNiwicGF0aCI6Ii83NDc0MDQvMzQwNDQ1NzkxLTg5NWJlZjU4LTYzOTMtNDQwZC1iNzk0LTg3ZThiYjk2MDU4Mi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcwM1QwMzMzNDZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03NmY5ZTY5ZDg0NTQxMGFiODM1YmE0MmYxMmQ5Mjg4OWE5YTkwNmJlNDNmOTIwM2QwNDk5YmU1NjI1YWM5ZmM2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.LTlCBvwug0YV9WTv9_vAH1gu80a2nYVJFkAdbmshS74)

• Icon for expanding tree branch is too big:

![image](https://private-user-images.githubusercontent.com/747404/340446421-6e79ccde-bd1e-42a0-931a-5fc07bba0fba.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk5Nzc5MjYsIm5iZiI6MTcxOTk3NzYyNiwicGF0aCI6Ii83NDc0MDQvMzQwNDQ2NDIxLTZlNzljY2RlLWJkMWUtNDJhMC05MzFhLTVmYzA3YmJhMGZiYS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcwM1QwMzMzNDZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04ZTVkN2YyNGI3ZjNiZWRjMGZkMGVkZWEzMGE4NGEyOGNkOGM1OGI2MzA2NzBjNzkxMzQ4OTQ2OTA1MmJkOWQxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.w-BIyuJ61P2Or75aEQLrfAJc5om5PAlrciuvCyvhnMg)

• Images for theme selection buttons are not centered:

![image](https://private-user-images.githubusercontent.com/747404/340446710-09574c83-5af9-48b0-a47b-c7353b991564.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk5Nzc5MjYsIm5iZiI6MTcxOTk3NzYyNiwicGF0aCI6Ii83NDc0MDQvMzQwNDQ2NzEwLTA5NTc0YzgzLTVhZjktNDhiMC1hNDdiLWM3MzUzYjk5MTU2NC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcwM1QwMzMzNDZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01OGY1ZjViMjg3MjQyNjFkNzczZmUyNmIzNDY3ZjYxMjViNTMxNTM0ZTVhNTJiODM1OGUwMDU3ZTQ0YmVjZmU2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.kovSFXZGlI5_gEmT1Ltzwv5Q9P2RERk4bx_jQu58168)

• Strange black bar close to few drop-down toolbar buttons:

![image](https://private-user-images.githubusercontent.com/747404/340447165-af0aa44c-8a93-4e14-bc33-9c0f3df8a16c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk5Nzc5MjYsIm5iZiI6MTcxOTk3NzYyNiwicGF0aCI6Ii83NDc0MDQvMzQwNDQ3MTY1LWFmMGFhNDRjLThhOTMtNGUxNC1iYzMzLTljMGYzZGY4YTE2Yy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcwM1QwMzMzNDZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05ZjBmM2RiMTg5NTNmNjEzZjhjYWNhMDg0MWY5YTYxZDg3NTY0Zjc3MGViZTg3NWJmNWYzYTkxYmJkNzdlZGUxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.YAJEnMJdbtXxIBpG8jN8UIdaiIfKAFToB11X9q_aXq8)

• Toolbar separators are too dark on the Light theme. They might also need some horizontal padding (this might be the same as @kadet1090's point no. 19):
• Notification window is clipped horizontally:
• Active button highlight is nearly invisible. In this example, Cancel is active. The default Qt theme overlays a transparent color over the button's body to make it more clear:
• Unnecessarily colored checkbox when using keyboard navigation and highlighting the active checkbox. This also applies to checking a checkbox (the checkbox itself is blue when clicking on it):
• Misplaced downward chevron on the TabBar's "plus" button:
• I got this error on the Tasks panel when unfolding one of the widgets: Could not create pixmap from qss:images_classic/Qsint_header_UnfoldOver_Blue-light.png
• To be consistent with the "Classic" naming, the new themes should drop the "Theme" suffix from their name, resulting in "Light" and "Dark". It is clear that they are themes by the "Theme:" label next to them.
• Active toggle button's background color in the commands toolbar makes icons less legible. It also raises visual attention unnecessarily. The Classic theme's dark gray is more neutral and addresses both issues (for the light theme at least)
  
• When pressing a toggle button to make it checked, its right padding increases, displacing all subsequent buttons to the right:
• Toggle buttons in the status toolbar (e.g. for the Draft Workbench) move when hovering over them:
• Toggle buttons in the status toolbar (e.g. for the Draft Workbench, snap lock commands) with a chevron to expand have the chevron misplaced:
• Unnecessary horizontal bar underneath buttons in the status toolbar:
• Tooltips are surrounded by a (light gray? white?) frame that makes up for a strange effect in the transition between tooltip background color and tooltip shadow