Skip to content

Instantly share code, notes, and snippets.

@furusiyya

furusiyya/DragonSecondAudit.md

Created December 20, 2017 05:54
Show Gist options
  • Save furusiyya/989696ea56cd8d5a613af69c04857080 to your computer and use it in GitHub Desktop.
Save furusiyya/989696ea56cd8d5a613af69c04857080 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
DragonSecondAudit.md

Some changes have been made in result of first audit. Following points mentioned in previous audit report are still need to be addressed.

7.3. Unresolved, Low: Use of throw

7.4. Unresolved, Low: Possible, Code is subjected to gas optimization.

7.6. Unresolved, Low: Possible, Redundent Code

7.10. Unresolved, Medium: No use of visibility of visibility modifiers

7.11. Unresolved, Medium: Lack of Sanity Checks

This issue doesn't exist in previous version.

1.0. Bad Inheritance

DragonLock.sol There is duplicate code in parent class and child class. onlyOwner modifier is already declared in Ownable.sol so there is no need to write this again in DragonLock.sol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment