Skip to content

Instantly share code, notes, and snippets.

@g1stavo
Last active July 1, 2019 20:57
Show Gist options
  • Save g1stavo/c0d0a6bb4da692e3141abd609a8c969b to your computer and use it in GitHub Desktop.
Save g1stavo/c0d0a6bb4da692e3141abd609a8c969b to your computer and use it in GitHub Desktop.

Task Info

Title: Adaptar mail para suportar https

Link: https://app.asana.com/0/24457451196652/542003220566791/f

Tags: ATD CC:Mail T1

Description: Verificar se todos os links são protocol free ou https (atenção da reconstrução de cart), se todas as funções e os CSS são protocol free ou https e estão disponíveis em https.

Solution

I search for all http:// inside .vm files, since all of them generate the campaigns templates, and replace them for //, except cartUrl inside macros.vm. That was replaced for https:// as it is used to build a second url.

Obs:

The images in the e-mail sent from Renderer MAX are not showing. Probably because QDB didn't switch to https yet.

#mail #https #protocol

Asana task

https://app.asana.com/0/24457451196652/542003220566791/f

Solution

I search for all http:// inside .vm files, since all of them generate the campaigns templates, and replace them for //, except cartUrl inside macros.vm. That was replaced for https:// as it is used to build a second url.

Observations

  • The images in the e-mail sent from Renderer MAX are not showing. Probably because QDB didn't switch to https yet.

#mail #https #protocol

Task Info

Title: Adaptar mail para suportar https

Link: https://app.asana.com/0/24457451196652/542003220566791/f

Tags: ATD CC:Mail T1

Description: Verificar se todos os links são protocol free ou https (atenção da reconstrução de cart), se todas as funções e os CSS são protocol free ou https e estão disponíveis em https.

Solution

I search for all http:// inside .vm files, since all of them generate the campaigns templates, and replace them for //, except cartUrl inside macros.vm. That was replaced for https:// as it is used to build a second url.

Observation

  • The images in the e-mail sent from Renderer MAX are not showing. Probably because QDB didn't switch to https yet.

#mail #https #protocol

@ericp3reira
Copy link

ericp3reira commented Feb 14, 2018

template-4.md

Task Info

Title: Adaptar mail para suportar https
Link: https://app.asana.com/0/24457451196652/542003220566791/f
Tags: ATD CC:Mail T1
Description: Verificar se todos os links são protocol free ou https (atenção da reconstrução de cart), se todas as funções e os CSS são protocol free ou https e estão disponíveis em https.

Solution:

✅ Change
⬜ Enhancement
⬜ Fix
⬜ Implementation

I search for all http:// inside .vm files, since all of them generate the campaigns templates, and replace them for //, except cartUrl inside macros.vm. That was replaced for https:// as it is used to build a second url.

Obs:

The images in the e-mail sent from Renderer MAX are not showing. Probably because QDB didn't switch to https yet.

#mail #https #protocol

@munizart
Copy link

munizart commented Feb 14, 2018

template-5.md


Task title (English)

https://app.asana.com/0/24457451196652/542003220566791/f

Problem

Describe here the problem found or the actual status. (e.g. the actual behaivour that this PR alters)

Disered outcome

Describe here the disered outcome or the implementation that should be done. (e.g. what the task is asking for to be done)

Solution

Describe here what you did in this PR.

Observations (optional)

  • Anotate here any useful observations

Checklist

  • Wash hands properly
  • Review diff before opening PR
  • Created code review task (if applicable)
  • Created QA task (if applicable)
  • JSDoc/PHPDoc (if applicable)
  • Minify (if applicable)
  • Hydrated yourself
  • Another usefull checklist item

@munizart
Copy link

Side-note: instead of generating hashtags, it would be nicer using github's label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment