Working with exceptions in Java

A_Correct.java

public String getUnreadMessages() {
    List<Message> messages = service.getMessage().getUnreadMessage();

    String result = convert( messages );
    
    markMessagesUpdated( messages );
    
    return result;
}

A_Wrong.java

public String getUnreadMessages() {
    boolean readSuccessful = true;
    List<Message> messages = null;
    try {
        messages = service.getMessage().getUnreadMessage();

        return convert( messages );
    } catch ( Throwable t ) {
        readSuccessful = false;

        logger.fatal("Exception during processing messages", t);
    } finally {
        if ( readSuccessful ) {
            markMessagesUpdated( messages );
        }
    }
}

B_Correct.java

public ResultClass getOptimalSale( long id ) {
    Map<Long, ResultClass> intermediateResult = new HashMap<Long, ResultClass>();

    try {
        Query query = getCurrentSession().createQuery( "from SomeEntityClass e where e.parentId=:parentId" ).
                setParameter( "parentId", id );
        
        //... really long algorithm
    } catch ( Exception e ) {
        logger.error( e.getMessage(), e );
        throw new SalesCalculationException( e );
    }

    return intermediateResult.get( id );
}

B_Wrong.java

public ResultClass getOptimalSale( long id ) {
    Map<Long, ResultClass> intermediateResult = new HashMap<Long, ResultClass>();

    try {
        Query query = getCurrentSession().createQuery( "from SomeEntityClass e where e.parentId=:parentId" ).
                setParameter( "parentId", id );
        
        //... really long algorithm
    } catch ( Exception e ) {
        logger.error( e.getMessage(), e );
        throw new RuntimeException( e );
    }

    return intermediateResult.get( id );
}

C_Correct.java

try {
 Session session = getCurrentSession();
 
 return session.createQuery( "from SomeEntityClass" ).list();
} catch ( HibernateException e ) {
 logger.error( getClass().getName() + " findAll()", e );
 
 throw e;
}

C_Wrong.java

Session session = null;
ArrayList<SomeEntityClass> result = null;
try {
 session = getCurrentSession();
 
 result = session.createQuery( "from SomeEntityClass" ).list();
} catch ( HibernateException e ) {
 logger.error( getClass().getName() + " findAll()", e );
} finally {
 session.close();
}
return result;

D_Correct.java

try {
 session = getCurrentSession();
 for ( SomeEntityClass entity : entities ) {
  session.saveOrUpdate( entity );
 }

 session.flush();
} catch ( NonUniqueObjectException e ) {
 try {
  session.merge( entities );
 } catch ( HibernateException ex ) {
  logger.error( getClass().getName() + " merge non unique object ", e );
  throw e;
 }
} catch ( HibernateException e ) {
 logger.error( getClass().getName() + " save ", e );
 throw e;
}

D_Wrong.java

try {
 session = getCurrentSession();
 for ( SomeEntityClass entity : entities ) {
  session.saveOrUpdate( entity );
 }

 session.flush();
} catch ( Exception e ) {
 logger.error( getClass().getName() + " save ", e );
}