Skip to content

Instantly share code, notes, and snippets.

@geowurster
Last active October 30, 2015 17:11
Show Gist options
  • Save geowurster/f97981ee9c6799652aa5 to your computer and use it in GitHub Desktop.
Save geowurster/f97981ee9c6799652aa5 to your computer and use it in GitHub Desktop.
Towards a libais v1.16

Towards a 1.16

  • Close PR #119
  • Close PR #117
  • Convert readme to RST
  • Convert changelog to Markdown
  • Move send_data.py -> utils
  • Move VERSION -> ais/__init__.py
  • Move ais_lut.py -> ais/enums|lut.py (or something similar? looks like they're not in use)
  • Move maritime_id_codes.py -> utils
  • Move nagios_pg_ais.py -> utils
  • Move nais2pg.py -> utils
  • Apache 2.0 in ais.__license__
  • Delete create.sql
  • Delete TODO.org (unlessn needed)
  • Add deprecation warning to bin/aisdecode
  • Add deprecation warning to ais.stream and ais.compatibility
  • Update readme with ais.open() example
  • Update MANIFEST.in
  • Update setup.py
@schwehr
Copy link

schwehr commented Oct 27, 2015

Initial thoughts...

I just killed send_data.py, nagios_pg_ais.py, nais2pg.py, create.sql, and TODO.org.

I'm okay with the conversion to RST or Markdown. I'm more comfortable with org-mode, but it doesn't matter and the rest of the world (except github) is typically surprised by org-mode.

I'm good with the move of ais_lut.py or maybe we just remove it.

Good with the move of maritime_id_codes to utils.

I'm not sure about the AUTHOR and license move. Why should those be in __init__.py?

I think the move of the VERSION file to ais/__init__.py is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment