Created
May 8, 2018 23:53
-
-
Save geraldke/5d836e22724092a8015e708e77cdc4cd to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engines/businesses/app/controllers/businesses/admin_utilities_controller.rb:36 W: Assignment Branch Condition size for pay_now_price is too high. [16.06/15] | |
engines/businesses/app/controllers/businesses/admin_utilities_controller.rb:37 W: Use `if active_membership.repeat_payments.blank?` instead of `unless active_membership.repeat_payments.present?`. | |
engines/businesses/app/controllers/businesses/admin_utilities_controller.rb:43 W: Space inside } missing. | |
engines/businesses/app/controllers/businesses/admin_utilities_controller.rb:233 W: Extra empty line detected at class body end. | |
engines/products/app/concepts/products/pay_now/operations/charge.rb:13 W: Extra blank line detected. | |
engines/products/app/concepts/products/pay_now/operations/charge.rb:20 W: Do not prefix writer method names with `set_`. | |
engines/products/app/concepts/products/pay_now/operations/charge.rb:25 W: Use `contract.pay_now_price.to_i.zero?` instead of `contract.pay_now_price.to_i == 0`. | |
engines/products/app/concepts/products/pay_now/operations/charge.rb:27 W: Redundant curly braces around a hash parameter. | |
engines/products/app/concepts/products/pay_now/operations/charge.rb:33 W: Assignment Branch Condition size for create_payment_record! is too high. [16.06/15] | |
engines/products/app/concepts/products/pay_now/operations/charge.rb:34 W: Use `contract.pay_now_price.to_i.zero?` instead of `contract.pay_now_price.to_i == 0`. | |
engines/products/app/concepts/products/pay_now/operations/charge.rb:47 W: Unused method argument - `exception`. If it's necessary, use `_` or `_exception` as an argument name to indicate that it won't be used. | |
engines/products/spec/concepts/products/pay_now/operations/charge_spec.rb:3 W: Block has too many lines. [42/25] | |
engines/products/spec/concepts/products/pay_now/operations/charge_spec.rb:5 W: Avoid using `{...}` for multi-line blocks. | |
engines/products/spec/concepts/products/pay_now/operations/charge_spec.rb:10 W: Prefer single-quoted strings when you don't need string interpolation or special symbols. | |
engines/products/spec/concepts/products/pay_now/operations/charge_spec.rb:17 W: Space inside { missing. | |
engines/products/spec/concepts/products/pay_now/operations/charge_spec.rb:17 W: Redundant curly braces around a hash parameter. | |
engines/products/spec/concepts/products/pay_now/operations/charge_spec.rb:17 W: Space inside } missing. | |
engines/products/spec/concepts/products/pay_now/operations/charge_spec.rb:43 W: Space inside { missing. | |
engines/products/spec/concepts/products/pay_now/operations/charge_spec.rb:43 W: Redundant curly braces around a hash parameter. | |
engines/products/spec/concepts/products/pay_now/operations/charge_spec.rb:43 W: Space inside } missing. | |
engines/products/spec/concepts/products/pay_now/operations/charge_spec.rb:49 W: Parenthesize the param `not_change { membership.payments.count }` to make sure that the block will be associated with the `not_change` method call. | |
engines/products/spec/concepts/products/pay_now/operations/charge_spec.rb:49 W: Space missing to the left of {. | |
engines/products/spec/concepts/products/pay_now/operations/charge_spec.rb:49 W: Space missing inside {. | |
engines/products/spec/concepts/products/pay_now/operations/charge_spec.rb:49 W: Do not use semicolons to terminate expressions. | |
engines/products/spec/concepts/products/pay_now/operations/charge_spec.rb:49 W: Space missing inside }. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment