Skip to content

Instantly share code, notes, and snippets.

@gkatsev
Last active June 3, 2019 16:02
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save gkatsev/61ad41be1c68a409fe73b11e1a4acf84 to your computer and use it in GitHub Desktop.
Save gkatsev/61ad41be1c68a409fe73b11e1a4acf84 to your computer and use it in GitHub Desktop.

Incomplete tests

API tests

VTTCue

region

Safari Tech Preview is failing due to its non-standard region implementation. It can pass if accounting for it. Firefox is failing due to throwing an error when cue.region is set to a value other than a VTTRegion or null. An error is not supposed to be thrown.

VTTRegion

lines

Browsers implemented this field as an int but it is specced as a long.

Parsing tests

cue text parsing

entities

This refers to HTML character entities, a standard set of HTML character entities is available in all browsers and an older version of the spec only included a couple of allowed characters. Currently, all HTML character entities are allowed. There is an oustanding bug against Safari for implementing this and there is a POC for vtt.js.

file parsing

region edge cases

This is failing in Firefox because it ends up stopping parsing the regions at the first edge case so only the first region is available. Safari fails due to its non-standard region implementation. It can pass if accounting for it.

region ids

This is failing in Safari due to its non-standard region implementation. It can pass if accounting for it.

region lines

Both Safari and Firefox are failing here due to implementation dependent versions of "interpret value as integer". Safari is clamping the value to the max integer value while Firefox returns a 0. Also, Firefox's very strict parser and Safari's non-standard region implementation is making this test fail.

settings line

Chrome and Safari fail because it is parsing .5 and 5., which are explicitly disallowed, as 0.5 and 5.0. Chrome and Safari do not support line align. Safari defaults to the value -1 rather than auto. Safari also sets a really small value to zero rather than Number.MIN_VALUE.

settings position

Chrome and Safari don't support position align, excluding that piece from the test makes it pass.

Rendering Tests

top level tests

align center wrapped

This is failing because text-wrap: balance; isn't available in any browser.

bidi tests

vertical lr and vertical rl

There's a bug for vertical handling where lr and rl cues are swapped. There's a fix in progress on Safari's side.

cue function, class object

Text combine upright

These are all implementation issues. The text-combine-upright CSS property hasn't been whitelisted by them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment