Do I understand what the change is about? – if no, I do not proceed further and ask the person sending the review for clarifications. Do I understand what is the added value of the change? – if no, I do not proceed further and ask the person sending the review for clarifications. Was the change tested? – there should be at least some degree of an empirical justification that the change works. If there is none, I usually do not proceed further and ask the person sending the review for clarifications. Do I recognise any logical errors? – in my experience those are relatively rarely present, nevertheless good to watch out for. Is the code readable and maintainable in general? – code is written once and it might be read thousands of times. To be efficient in the long run code readability is essential. Can I spot some problems with non-functional requirements e.g. scalability, performance, security? Do I want to own this code? Is it compliant with the code style of the code base? – consistency helps readability.
Created
December 23, 2021 02:12
-
-
Save gladiatorAsh/29af771ca4c4d96669358b92c8e58c7a to your computer and use it in GitHub Desktop.
Code Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment