Skip to content

Instantly share code, notes, and snippets.

View gorzell's full-sized avatar

Greg Orzell gorzell

View GitHub Profile
@gorzell
gorzell / Makefile
Last active May 4, 2017 08:53
Circle 2.0 Integration Tests With Docker Compose
compose-it: #: Compose dependencies for integration tests.
docker-compose -f docker-compose.yaml up -d
# Give the services a chance to start up.
sleep 45
it: #: Run integration tests
sbt ci:test
it-ci: #: Setup up and run integration tests in ci.
docker create --name it \
@gorzell
gorzell / code_review_comments.md
Last active November 9, 2017 09:54
Code Review Comments Blog

The suggested convention is to start a comment with one of the tags in bold. In markdown that would look like this: **Concern:** If you think there is a more useful format, go for it and let me know how it turns out.

Tag Implication Expectation
[Default] i.e. no tag specified Free form, interpret it as you will. Context dependent.
Bug Reviewer is concerned that the code in question could cause problems in production. Reviewer’s expectation is that the bug will be acknowledged, corrected or explained in some form.
Question Reviewer has general questions that may warrant addressing before a merge. Reviewer’s expectation is that the question will be acked or answered in some form.
Concern This is something to consider an important issue and a response would be appreciated. Reviewer’s expectation is that there will be a response most of the time.
Suggestion Reviewer thinks code could be improved, but change is not necessary. Reviewer expects subm
@gorzell
gorzell / ammoniteCacheCleanIvyCache.txt
Last active December 18, 2015 00:46
Loading Transitive Dependencies
Welcome to the Ammonite Repl 0.5.1
(Scala 2.11.7 Java 1.8.0_66)
@ load.ivy("com.amazonaws" % "aws-java-sdk-iam" % "1.10.+")
:: loading settings :: url = jar:file:/usr/local/Cellar/ammonite-repl/0.5.1/bin/amm!/org/apache/ivy/core/settings/ivysettings.xml
:: resolving dependencies :: com.amazonaws#aws-java-sdk-iam-caller;working
confs: [default]
found com.amazonaws#aws-java-sdk-iam;1.10.41 in central
[1.10.41] com.amazonaws#aws-java-sdk-iam;1.10.+
found com.amazonaws#aws-java-sdk-core;1.10.41 in central
found commons-logging#commons-logging;1.1.3 in central