Skip to content

Instantly share code, notes, and snippets.

Last active February 9, 2023 05:09
Show Gist options
  • Save grantland/cd70814fe4ac369e3e92 to your computer and use it in GitHub Desktop.
Save grantland/cd70814fe4ac369e3e92 to your computer and use it in GitHub Desktop.
RecyclerView item onClick

RecyclerView item onClick

RecyclerView does not have an OnItemClickListener like it's predecessor, ListView. However, detecting item clicks is pretty simple.

Set an OnClickListener in your ViewHolder creation:

private class MyAdapter extends RecyclerView.Adapter<MyAdapter.ViewHolder>  {

    public static class ViewHolder extends RecyclerView.ViewHolder
            implements View.OnClickListener {
        private String mItem;
        private TextView mTextView;

        public ViewHolder(View view) {
            mTextView = (TextView) view;

        public void setItem(String item) {
            mItem = item;

        public void onClick(View view) {
            Log.d(TAG, "onClick " + getPosition() + " " + mItem);

    private String[] mDataset;

    public MyAdapter(String[] dataset) {
        mDataset = dataset;

    public ViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {
        View v = LayoutInflater.from(parent.getContext())
                .inflate(R.layout.list_item, parent, false);
        ViewHolder vh = new ViewHolder(v);
        return vh;

    public void onBindViewHolder(ViewHolder holder, int position) {

    public int getItemCount() {
        return mDataset.length;

Add touch feedback to your item layout:

<?xml version="1.0" encoding="utf-8"?>
<TextView xmlns:android=""
Copy link

where did you add touch feedback to item layout

Copy link

How do you implement onClickListener on GridLayout using the RecyclerView

Copy link

This code doesn't work, but this does work

Copy link

the base class doesn't have any on click method???

Copy link

SkymanOne commented Dec 6, 2016

but can use int item instead of String item and it's easier work with items

Copy link

JSila commented Feb 15, 2017

getPosition is deprecated, use getAdapterPosition instead.

Copy link

thanks, this save me from item clicklistener mess.
Though this is what i use...
int itemPosition = getLayoutPosition();
Products products = productsArrayList.get(itemPosition);
Thanks for the clue

Copy link

👍 👍 👍 👍

Thanks! This is by far the cleanest solution I have seen for this. Helped a lot!

Copy link

Short and concise. Thanks!

Copy link


Copy link

thanks for the code, you saved my lot of time.

Copy link

how to get startactivity in onclick()


Copy link

how to implement onItemClickListener on individual items/icons of viewHolder in a recyclerView and perform actions on them inside fragment/activity, but not inside the adapter

Copy link

You should not couple your ViewHolders and ItemClickListeners. Please see a better solution here.

how is this better? You don't need a gesture detector to handle clicks.

Just set a setOnClickListener(). The original gist is significantly better than what you linked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment