Skip to content

Instantly share code, notes, and snippets.

@gregpardo
Last active June 14, 2017 15:46
Show Gist options
  • Star 6 You must be signed in to star a gist
  • Fork 1 You must be signed in to fork a gist
  • Save gregpardo/93420647700d31e2a9b10ed7b309cf96 to your computer and use it in GitHub Desktop.
Save gregpardo/93420647700d31e2a9b10ed7b309cf96 to your computer and use it in GitHub Desktop.
Realm+CascadingDeletions
import Foundation
import RealmSwift
protocol CascadingDeletable {
var cascadingDeletions: [AnyObject?] { get }
}
extension Realm {
func delete<T: AnyObject>(cascading: List<T>) where T: CascadingDeletable {
let o = cascading
cascading.removeAll()
delete(o)
}
func delete<T: AnyObject>(cascading: Results<T>) where T: CascadingDeletable {
let o = cascading
delete(o)
}
func delete<T: AnyObject>(cascading: [T]) where T: CascadingDeletable {
for c in cascading {
delete(c as! Object)
}
}
func delete<T: AnyObject>(cascading: T) where T: Object, T: CascadingDeletable {
for child in cascading.cascadingDeletions {
if let object = child as? Object {
delete(object)
}
if let cascade = child as? CascadingDeletable {
delete(cascade as! Object)
}
}
delete(cascading)
}
}
@anfriis
Copy link

anfriis commented Sep 26, 2016

Looks nice with extension methods!

But I am having trouble compiling it with Swift 3 and RealmSwift 1.1.0, but I receive the following error in line 11 and 15:
"Extra argument 'cascade' in call"

Do you know what could be wrong?

@anfriis
Copy link

anfriis commented Nov 9, 2016

?

@fishfisher
Copy link

@Anders123f: I was able to compile by changing from objects.toArray() to Array(objects)

@orangeince
Copy link

Hi
First, this extension looks very cool. Thanks for shared this
But, I found maybe you lost something.
If object is realmObject and CascadingDeletable, the object should be deleted too.
I add some code to the delete method:

 func delete<T: AnyObject>(_ object: T, cascade: Bool = true) where T: CascadingDeletable {
    ....
    if let object = object as? Object {
        delete(object)
    }
}

@AnthonyMDev
Copy link

When I call delete(_:) in Swift, it is being dispatched to the original delete(_:) function on Realm, not the cascading one from your extension. Not sure how to make this work...

@YoamFarges
Copy link

I would advise you not to use this solution.
Even after:

  • adapting the code to Swift 3,
  • fixing the algorithm with @orangeince answer
  • adding some function definitions for the delete(_:, cascade:) method to be called for Object instance not conforming to the protocol

I've found issues with the fact that the method will not be called recursively, as let cascadingChild = child as? T will not work if the child is not the same type as its parent.

Removing this check and just using the child as a regular Object won't work either, as the where clause is not recognized if we do not pass a type that conforms to the type in its definition.

@ndizazzo
Copy link

@AnthonyMDev - Realm provides initializers for an array of Realm Object<T>. The compiler can't infer the correct object type if you use .toArray().

func delete<T: AnyObject>(_ objects: List<T>, cascade: Bool = true) where T: CascadingDeletable {
    delete(Array(objects), cascade: cascade)
}

func delete<T: AnyObject>(_ objects: Results<T>, cascade: Bool = true) where T: CascadingDeletable {
    delete(Array(objects), cascade: cascade)
}

@Montrazul
Copy link

I tested this code today but it does not fullfill the requirements of a full cascading delete.

All my model classes are impelmenting the CascadingDeletable protocoll and are returning all childs that should be deleted in the cascadingDeletions array. Lets say you have the following structure:

Object A
   Sub 1
   Sub 2
      SubSub 2.1
      SubSub 2.2
   Sub 3
   ...

Sub 1, Sub 2, Sub 3 are getting deleted but SubSub 2.1, SubSub 2.2 and the Object A itself are not getting deleted with current Realm 2.4.0 version and your extensions. Tested on XCode 8 with Swift 3.0 and Realm 2.4.0.

@chrux
Copy link

chrux commented May 3, 2017

Same issue here, I haven't been able to remove the a List attribute.

@anfriis
Copy link

anfriis commented May 24, 2017

Any solutions to this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment