Skip to content

Instantly share code, notes, and snippets.

@guileen
Created June 15, 2012 10:28
Show Gist options
  • Save guileen/2935761 to your computer and use it in GitHub Desktop.
Save guileen/2935761 to your computer and use it in GitHub Desktop.
bad style?
// ------------
// config.js
module.exports = {mongo: 'mongo://localhost/test'};
// -----------
// index.js
var mongoskin = require('mongoskin');
// init config
var config = require('./config');
config.db = mongoskin.db(config.db);
exports.user = require('./user');
exports.book = require('./book');
// ----------
// user.js
var config = require('./config');
var db = config.db;
var User = db.collection('user');
exports.get = function(id, callback) {
User.findById(id, callback);
}
@fengmk2
Copy link

fengmk2 commented Jun 15, 2012

这样写配置有什么不好吗?

@guileen
Copy link
Author

guileen commented Jun 16, 2012

@fengmk2 我觉得问题是缺少“依赖注入”。我很讨厌依赖注入,不过在把数据访问层独立出来的时候,似乎又需要它。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment