Skip to content

Instantly share code, notes, and snippets.

@hansemannn
Last active March 1, 2016 10:07
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save hansemannn/4d1a3de809606599acf7 to your computer and use it in GitHub Desktop.
Save hansemannn/4d1a3de809606599acf7 to your computer and use it in GitHub Desktop.

Hey there!

Thank you for the interest in contributing to Titanium Mobile. We are happy to review your code as soon as possible. To achieve this, please make sure to comply with the following guidelines:

  • Sign the CLA for open source contributions (only necessary for your first contribution)
  • Follow the instructions stated in "Contributing to Titanium"
  • If you are fixing an issue that already has a JIRA ticket, link the ticket inside your pull request
  • If you are fixing an issue that has no JIRA ticket, yet, create a new ticket and link it inside your pull request

That's it, you are good to go! If you have any further questions or problems, feel free to ask us on Stack Overflow or TiSlack.

Code strong! 🚀

@FokkeZB
Copy link

FokkeZB commented Mar 1, 2016

Some ideas:

Hey there! 

Thank you for the interest in contributing. We'd like to review and possibly merge as soon as possible. For this to happen, please make sure the following is in order:

- [ ] Sign the [CLA](https://cla.appcelerator.com) for open source contributions (only required for your first contribution)
- [ ] Follow the instructions stated in [Contributing to Titanium](https://wiki.appcelerator.org/display/guides2/Contributing+to+Titanium), including the request to squash commits, include unit tests and use clear commit titles (this will be your legacy!)
- [ ] If you are fixing an issue that already has a [JIRA ticket](http://jira.appcelerator.org), include the URL in your PR description
- [ ] If you are fixing an issue that has no JIRA ticket, yet, create a [new ticket](https://jira.appcelerator.org/secure/CreateIssue!default.jspa) and include the URL in your PR description
- [ ] Use a clear title.
- [ ] Prefix the  PR title with the JIRA ticket number (`[ABC-123] My clear title`)

That's it, you are good to go! If you have any further questions or problems, feel free to ask us on [TiSlack](https://tislack.org).

Code strong! :rocket:

@hansemannn
Copy link
Author

So you want to uncheck the checkboxes by default? The rest is fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment