Skip to content

Instantly share code, notes, and snippets.

@hashseed
Created January 15, 2018 14:06
Show Gist options
  • Save hashseed/074be0c9c2889813ad92f95bdef266c7 to your computer and use it in GitHub Desktop.
Save hashseed/074be0c9c2889813ad92f95bdef266c7 to your computer and use it in GitHub Desktop.
V8 ABI checking build config patch
diff --git a/BUILD.gn b/BUILD.gn
index 98e035fc6a..161e81a183 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -568,6 +568,10 @@ config("v8_gcov_coverage_ldflags") {
ldflags = [ "-fprofile-arcs" ]
}
+config("v8_dump") {
+ cflags = [ "-Og", "-g" ]
+}
+
###############################################################################
# Actions
#
diff --git a/gni/v8.gni b/gni/v8.gni
index ce9953ac68..2613bb3e2d 100644
--- a/gni/v8.gni
+++ b/gni/v8.gni
@@ -80,7 +80,7 @@ v8_add_configs = [
if (is_debug && !v8_optimized_debug) {
v8_remove_configs += [ "//build/config/compiler:default_optimization" ]
- v8_add_configs += [ "//build/config/compiler:no_optimize" ]
+ v8_add_configs += [ "//build/config/compiler:no_optimize", v8_path_prefix + ":v8_dump" ]
} else {
v8_remove_configs += [ "//build/config/compiler:default_optimization" ]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment