checkstyle

/home/hschmiedehausen/code/mesos/Singularity/SingularityBase/src/main/java/com/hubspot/singularity/SingularityPendingTaskId.java:72: Line has trailing spaces.
/home/hschmiedehausen/code/mesos/Singularity/SingularityBase/src/main/java/com/hubspot/singularity/SingularityPendingTaskId.java:90: Line has trailing spaces.
/home/hschmiedehausen/code/mesos/Singularity/SingularityBase/src/main/java/com/hubspot/singularity/SingularityDeployMarker.java:52: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityBase/src/main/java/com/hubspot/singularity/SingularityDeployMarker.java:54: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityBase/src/main/java/com/hubspot/singularity/SingularityDeployMarker.java:56: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityBase/src/main/java/com/hubspot/singularity/SingularityDeployMarker.java:60: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityBase/src/main/java/com/hubspot/singularity/SingularityDeployMarker.java:62: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityBase/src/main/java/com/hubspot/singularity/SingularityDeployMarker.java:65: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityBase/src/main/java/com/hubspot/singularity/SingularityDeployMarker.java:67: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityBase/src/main/java/com/hubspot/singularity/SingularityPendingTask.java:51: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityBase/src/main/java/com/hubspot/singularity/SingularityPendingTask.java:53: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityBase/src/main/java/com/hubspot/singularity/SingularityPendingTask.java:55: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityBase/src/main/java/com/hubspot/singularity/SingularityPendingTask.java:59: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityBase/src/main/java/com/hubspot/singularity/SingularityPendingTask.java:61: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityBase/src/main/java/com/hubspot/singularity/SingularityId.java:23: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityBase/src/main/java/com/hubspot/singularity/SingularityId.java:25: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityBase/src/main/java/com/hubspot/singularity/SingularityId.java:27: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityBase/src/main/java/com/hubspot/singularity/SingularityTaskRequest.java:50: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityBase/src/main/java/com/hubspot/singularity/SingularityTaskRequest.java:52: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityBase/src/main/java/com/hubspot/singularity/SingularityTaskRequest.java:54: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityBase/src/main/java/com/hubspot/singularity/SingularityTaskRequest.java:58: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityBase/src/main/java/com/hubspot/singularity/SingularityTaskRequest.java:60: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityBase/src/main/java/com/hubspot/mesos/JavaUtils.java:99: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityBase/src/main/java/com/hubspot/mesos/JavaUtils.java:104: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityBase/src/main/java/com/hubspot/mesos/JavaUtils.java:126:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityRunnerBase/src/main/java/com/hubspot/singularity/runner/base/shared/SingularityRunner.java:12:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityRunnerBase/src/main/java/com/hubspot/singularity/runner/base/shared/TailMetadata.java:48: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityRunnerBase/src/main/java/com/hubspot/singularity/runner/base/shared/TailMetadata.java:50: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityRunnerBase/src/main/java/com/hubspot/singularity/runner/base/shared/TailMetadata.java:52: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityRunnerBase/src/main/java/com/hubspot/singularity/runner/base/shared/TailMetadata.java:56: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityRunnerBase/src/main/java/com/hubspot/singularity/runner/base/shared/TailMetadata.java:58: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityRunnerBase/src/main/java/com/hubspot/singularity/runner/base/shared/S3UploadMetadata.java:53: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityRunnerBase/src/main/java/com/hubspot/singularity/runner/base/shared/S3UploadMetadata.java:55: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityRunnerBase/src/main/java/com/hubspot/singularity/runner/base/shared/S3UploadMetadata.java:57: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityRunnerBase/src/main/java/com/hubspot/singularity/runner/base/shared/S3UploadMetadata.java:61: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityRunnerBase/src/main/java/com/hubspot/singularity/runner/base/shared/S3UploadMetadata.java:63: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityRunnerBase/src/main/java/com/hubspot/singularity/runner/base/shared/S3UploadMetadata.java:66: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityRunnerBase/src/main/java/com/hubspot/singularity/runner/base/shared/S3UploadMetadata.java:68: 'if' construct must use '{}'s.
/home/hschmiedehausen/code/mesos/Singularity/SingularityRunnerBase/src/main/java/com/hubspot/singularity/runner/base/shared/WatchServiceHelper.java:22:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityRunnerBase/src/main/java/com/hubspot/singularity/runner/base/shared/SingularityDriver.java:5:3: warning: Redundant 'public' modifier.
/home/hschmiedehausen/code/mesos/Singularity/SingularityRunnerBase/src/main/java/com/hubspot/singularity/runner/base/shared/SingularityDriver.java:7:3: warning: Redundant 'public' modifier.
/home/hschmiedehausen/code/mesos/Singularity/SingularityMesosClient/src/main/java/com/hubspot/mesos/client/MesosClient.java:22:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityMesosClient/src/main/java/com/hubspot/mesos/client/MesosClient.java:24:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityMesosClient/src/main/java/com/hubspot/mesos/client/MesosClient.java:25:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityMesosClient/src/main/java/com/hubspot/mesos/client/MesosClient.java:26:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityClient/src/main/java/com/hubspot/singularity/client/SingularityClient.java:34:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/RequestManager.java:31:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/RequestManager.java:37:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/RequestManager.java:39:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/RequestManager.java:40:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/RequestManager.java:41:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/history/SingularityHistoryPersister.java:19:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/history/SingularityTaskHistoryPersister.java:21:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/history/SingularityDeployHistoryPersister.java:19:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/DeployManager.java:39:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/DeployManager.java:49:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/DeployManager.java:51:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/DeployManager.java:52:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/DeployManager.java:54:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/DeployManager.java:56:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/DeployManager.java:57:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/DeployManager.java:59:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/DeployManager.java:60:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/DeployManager.java:61:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/DeployManager.java:62:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/StateManager.java:34:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/TaskRequestManager.java:22:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/AbstractMachineManager.java:23:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/transcoders/StringTranscoder.java:7:16: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/transcoders/Transcoder.java:7:3: warning: Redundant 'public' modifier.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/transcoders/Transcoder.java:9:3: warning: Redundant 'public' modifier.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/TaskManager.java:49:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/TaskManager.java:51:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/TaskManager.java:52:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/TaskManager.java:53:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/TaskManager.java:54:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/TaskManager.java:55:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/TaskManager.java:57:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/TaskManager.java:59:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/TaskManager.java:60:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/TaskManager.java:61:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/TaskManager.java:63:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/TaskManager.java:65:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/TaskManager.java:66:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/TaskManager.java:383: Line has trailing spaces.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/TaskManager.java:387: Line has trailing spaces.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/CuratorManager.java:25:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/data/CuratorAsyncManager.java:26:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/SingularityServiceModule.java:67:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/SingularityLeaderController.java:18:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/SingularityCloseable.java:5:3: warning: Redundant 'public' modifier.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/scheduler/SingularityCleaner.java:43:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/scheduler/SingularityCleanupPoller.java:20:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/scheduler/SingularityDeployPoller.java:21:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/scheduler/SingularityCooldownPoller.java:21:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/scheduler/SingularityHealthchecker.java:32:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/scheduler/SingularityNewTaskChecker.java:40:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/scheduler/SingularityDeployHealthHelper.java:24:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/scheduler/SingularityCooldownChecker.java:21:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/scheduler/SingularityDeployChecker.java:49:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/scheduler/SingularityScheduler.java:57:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/scheduler/SingularityCooldown.java:15:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/scheduler/SingularityHealthcheckAsyncHandler.java:18:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/hooks/LoadBalancerClientImpl.java:38:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/hooks/LoadBalancerClient.java:13:3: warning: Redundant 'public' modifier.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/hooks/LoadBalancerClient.java:15:3: warning: Redundant 'public' modifier.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/hooks/LoadBalancerClient.java:17:3: warning: Redundant 'public' modifier.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/SingularityCloser.java:24:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/SingularityAbort.java:21:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/SingularityStatePoller.java:18:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/resources/S3LogResource.java:56:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/resources/TaskResource.java:80: Line has trailing spaces.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/resources/TaskResource.java:86: Line has trailing spaces.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/resources/TaskResource.java:88: Line has trailing spaces.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/resources/TaskResource.java:92: Line has trailing spaces.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/resources/TaskResource.java:95: Line has trailing spaces.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/mesos/SingularityStartup.java:44:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/mesos/SingularityMesosTaskBuilder.java:37:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/mesos/SingularityMesosScheduler.java:41:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/mesos/SingularityLogSupport.java:29:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/mesos/SingularityRackManager.java:34:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/mesos/SingularityOfferHolder.java:21:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/mesos/SingularityMesosSchedulerDelegator.java:33:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/mesos/SingularityDriver.java:20:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/sentry/SingularityExceptionNotifier.java:17:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/sentry/NotifyingUncaughtExceptionManager.java:9:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/sentry/SingularityExceptionNotifierManaged.java:11:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/smtp/SMTPAppenderBundle.java:22:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityService/src/main/java/com/hubspot/singularity/smtp/SingularityMailer.java:57:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityExecutor/src/main/java/com/hubspot/singularity/executor/SingularityExecutorMonitor.java:36:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityExecutor/src/main/java/com/hubspot/singularity/executor/SingularityExecutor.java:21:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityExecutor/src/main/java/com/hubspot/singularity/executor/config/SingularityExecutorLogging.java:15:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityExecutor/src/main/java/com/hubspot/singularity/executor/task/SingularityExecutorTaskCleanup.java:32: Line has trailing spaces.
/home/hschmiedehausen/code/mesos/Singularity/SingularityExecutor/src/main/java/com/hubspot/singularity/executor/task/SingularityExecutorTaskCleanup.java:37: Line has trailing spaces.
/home/hschmiedehausen/code/mesos/Singularity/SingularityExecutor/src/main/java/com/hubspot/singularity/executor/task/SingularityExecutorTaskCleanup.java:49: Line has trailing spaces.
/home/hschmiedehausen/code/mesos/Singularity/SingularityExecutor/src/main/java/com/hubspot/singularity/executor/task/SingularityExecutorArtifactFetcher.java:30:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityExecutor/src/main/java/com/hubspot/singularity/executor/SingularityExecutorRunner.java:20:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityExecutorCleanup/src/main/java/com/hubspot/singularity/executor/cleanup/SingularityExecutorCleanupRunner.java:23:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityExecutorCleanup/src/main/java/com/hubspot/singularity/executor/cleanup/SingularityExecutorCleanup.java:36:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityLogWatcher/src/main/java/com/hubspot/singularity/logwatcher/SimpleStore.java:32:3: warning: Redundant 'public' modifier.
/home/hschmiedehausen/code/mesos/Singularity/SingularityLogWatcher/src/main/java/com/hubspot/singularity/logwatcher/SimpleStore.java:34:3: warning: Redundant 'public' modifier.
/home/hschmiedehausen/code/mesos/Singularity/SingularityLogWatcher/src/main/java/com/hubspot/singularity/logwatcher/SimpleStore.java:36:3: warning: Redundant 'public' modifier.
/home/hschmiedehausen/code/mesos/Singularity/SingularityLogWatcher/src/main/java/com/hubspot/singularity/logwatcher/SimpleStore.java:38:3: warning: Redundant 'public' modifier.
/home/hschmiedehausen/code/mesos/Singularity/SingularityLogWatcher/src/main/java/com/hubspot/singularity/logwatcher/SimpleStore.java:40:3: warning: Redundant 'public' modifier.
/home/hschmiedehausen/code/mesos/Singularity/SingularityLogWatcher/src/main/java/com/hubspot/singularity/logwatcher/SimpleStore.java:42:3: warning: Redundant 'public' modifier.
/home/hschmiedehausen/code/mesos/Singularity/SingularityLogWatcher/src/main/java/com/hubspot/singularity/logwatcher/SimpleStore.java:44:3: warning: Redundant 'public' modifier.
/home/hschmiedehausen/code/mesos/Singularity/SingularityLogWatcher/src/main/java/com/hubspot/singularity/logwatcher/tailer/SingularityLogWatcherTailer.java:30:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityLogWatcher/src/main/java/com/hubspot/singularity/logwatcher/config/test/LogLogForwarder.java:11:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityLogWatcher/src/main/java/com/hubspot/singularity/logwatcher/config/test/MemoryStore.java:18:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityLogWatcher/src/main/java/com/hubspot/singularity/logwatcher/LogForwarder.java:12:3: warning: Redundant 'public' modifier.
/home/hschmiedehausen/code/mesos/Singularity/SingularityLogWatcher/src/main/java/com/hubspot/singularity/logwatcher/driver/SingularityLogWatcherDriver.java:29:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityLogWatcher/src/main/java/com/hubspot/singularity/logwatcher/impl/FileBasedSimpleStore.java:30:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityLogWatcher/src/main/java/com/hubspot/singularity/logwatcher/TailMetadataListener.java:7:3: warning: Redundant 'public' modifier.
/home/hschmiedehausen/code/mesos/Singularity/SingularityS3Uploader/src/main/java/com/hubspot/singularity/s3uploader/SingularityS3Uploader.java:26:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityS3Uploader/src/main/java/com/hubspot/singularity/s3uploader/SingularityS3Uploader.java:64: Line has trailing spaces.
/home/hschmiedehausen/code/mesos/Singularity/SingularityS3Uploader/src/main/java/com/hubspot/singularity/s3uploader/SingularityS3Uploader.java:66: Line has trailing spaces.
/home/hschmiedehausen/code/mesos/Singularity/SingularityS3Uploader/src/main/java/com/hubspot/singularity/s3uploader/SingularityS3Uploader.java:71: Line has trailing spaces.
/home/hschmiedehausen/code/mesos/Singularity/SingularityS3Uploader/src/main/java/com/hubspot/singularity/s3uploader/SingularityS3Uploader.java:132: Line has trailing spaces.
/home/hschmiedehausen/code/mesos/Singularity/SingularityS3Uploader/src/main/java/com/hubspot/singularity/s3uploader/SingularityS3UploaderDriver.java:52:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityS3Uploader/src/main/java/com/hubspot/singularity/s3uploader/SingularityS3UploaderDriver.java:91: Line has trailing spaces.
/home/hschmiedehausen/code/mesos/Singularity/SingularityS3Uploader/src/main/java/com/hubspot/singularity/s3uploader/SingularityS3UploaderDriver.java:92: Line has trailing spaces.
/home/hschmiedehausen/code/mesos/Singularity/SingularityOOMKiller/src/main/java/com/hubspot/singularity/oomkiller/SingularityProcessKiller.java:12:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityOOMKiller/src/main/java/com/hubspot/singularity/oomkiller/SingularityOOMKiller.java:26:17: 'static' modifier out of order with the JLS suggestions.
/home/hschmiedehausen/code/mesos/Singularity/SingularityOOMKiller/src/main/java/com/hubspot/singularity/oomkiller/SingularityOOMKillerDriver.java:20:17: 'static' modifier out of order with the JLS suggestions.
A

findbugs

[INFO] com.hubspot.deploy.EmbeddedArtifact.getContent() may expose internal representation by returning EmbeddedArtifact.content ["com.hubspot.deploy.EmbeddedArtifact"] At EmbeddedArtifact.java:[lines 16-26]
[INFO] new com.hubspot.deploy.EmbeddedArtifact(String, String, Optional, byte[]) may expose internal representation by storing an externally mutable object into EmbeddedArtifact.content ["com.hubspot.deploy.EmbeddedArtifact"] At EmbeddedArtifact.java:[lines 16-26]
[INFO] com.hubspot.singularity.SingularityDeployHistory defines compareTo(SingularityDeployHistory) and uses Object.equals() ["com.hubspot.singularity.SingularityDeployHistory"] At SingularityDeployHistory.java:[lines 10-57]
[INFO] com.hubspot.singularity.SingularityDeployKey.fromPendingDeployToDeployKey isn't final but should be ["com.hubspot.singularity.SingularityDeployKey"] At SingularityDeployKey.java:[lines 16-80]
[INFO] input must be nonnull but is marked as nullable ["com.hubspot.singularity.SingularityDeployKey$1"] At SingularityDeployKey.java:[lines 28-31]
[INFO] input must be nonnull but is marked as nullable ["com.hubspot.singularity.SingularityDeployKey$2"] At SingularityDeployKey.java:[lines 37-40]
[INFO] input must be nonnull but is marked as nullable ["com.hubspot.singularity.SingularityDeployKey$3"] At SingularityDeployKey.java:[lines 49-52]
[INFO] input must be nonnull but is marked as nullable ["com.hubspot.singularity.SingularityPendingTask$1"] At SingularityPendingTask.java:[lines 14-18]
[INFO] input must be nonnull but is marked as nullable ["com.hubspot.singularity.SingularityPendingTask$2"] At SingularityPendingTask.java:[lines 25-29]
[INFO] input must be nonnull but is marked as nullable ["com.hubspot.singularity.SingularityPendingTaskId$1"] At SingularityPendingTaskId.java:[lines 19-23]
[INFO] input must be nonnull but is marked as nullable ["com.hubspot.singularity.SingularityPendingTaskId$2"] At SingularityPendingTaskId.java:[lines 30-34]
[INFO] com.hubspot.singularity.SingularityTaskHealthcheckResult defines compareTo(SingularityTaskHealthcheckResult) and uses Object.equals() ["com.hubspot.singularity.SingularityTaskHealthcheckResult"] At SingularityTaskHealthcheckResult.java:[lines 13-76]
[INFO] com.hubspot.singularity.SingularityTaskHistoryUpdate defines compareTo(SingularityTaskHistoryUpdate) and uses Object.equals() ["com.hubspot.singularity.SingularityTaskHistoryUpdate"] At SingularityTaskHistoryUpdate.java:[lines 13-90]
[INFO] input must be nonnull but is marked as nullable ["com.hubspot.singularity.SingularityTaskHistoryUpdate$1"] At SingularityTaskHistoryUpdate.java:[lines 32-35]
[INFO] input must be nonnull but is marked as nullable ["com.hubspot.singularity.SingularityTaskId$1"] At SingularityTaskId.java:[lines 24-28]
[INFO] input must be nonnull but is marked as nullable ["com.hubspot.singularity.SingularityTaskId$2"] At SingularityTaskId.java:[lines 35-39]
[INFO] com.hubspot.singularity.SingularityTaskIdHistory defines compareTo(SingularityTaskIdHistory) and uses Object.equals() ["com.hubspot.singularity.SingularityTaskIdHistory"] At SingularityTaskIdHistory.java:[lines 11-59]
[INFO] Found reliance on default encoding in com.hubspot.singularity.runner.base.shared.SimpleProcessExecutor.consumeStreamAsLines(InputStream): new java.io.InputStreamReader(InputStream) ["com.hubspot.singularity.runner.base.shared.SimpleProcessExecutor"] At SimpleProcessExecutor.java:[lines 10-36]
[INFO] com.hubspot.singularity.runner.base.shared.SingularityRunner.run(Iterable) invokes System.exit(...), which shuts down the entire virtual machine ["com.hubspot.singularity.runner.base.shared.SingularityRunner"] At SingularityRunner.java:[lines 10-39]
[INFO] com.hubspot.singularity.mesos.SingularityStartup.enqueueHealthAndNewTaskchecks() makes inefficient use of keySet iterator instead of entrySet iterator ["com.hubspot.singularity.mesos.SingularityStartup"] At SingularityStartup.java:[lines 44-184]
[INFO] Possible null pointer dereference of history in com.hubspot.singularity.resources.S3LogResource.getS3PrefixesForRequest(String) ["com.hubspot.singularity.resources.S3LogResource"] At S3LogResource.java:[lines 54-237]
[INFO] Switch statement found in com.hubspot.singularity.scheduler.SingularityCleaner.checkLbState(SingularityTaskId) where one case falls through to the next case ["com.hubspot.singularity.scheduler.SingularityCleaner"] At SingularityCleaner.java:[lines 43-435]
[INFO] Format-string method String.format(String, Object[]) called with format string "Deploy had state %s but failed to persist it correctly" wants 1 arguments but is given 3 in com.hubspot.singularity.scheduler.SingularityDeployChecker.checkDeploy(SingularityPendingDeploy, List, Map, Map) ["com.hubspot.singularity.scheduler.SingularityDeployChecker"] At SingularityDeployChecker.java:[lines 49-403]
[INFO] com.hubspot.singularity.smtp.JadeHelper.JADE_LOADER isn't final but should be ["com.hubspot.singularity.smtp.JadeHelper"] At JadeHelper.java:[lines 19-48]
[INFO] Found reliance on default encoding in com.hubspot.singularity.smtp.JadeHelper$1.getReader(String): new java.io.InputStreamReader(InputStream) ["com.hubspot.singularity.smtp.JadeHelper$1"] At JadeHelper.java:[lines 21-30]
[INFO] com.hubspot.singularity.smtp.SingularityMailer.getTaskLogFile(SingularityTaskId, String) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead ["com.hubspot.singularity.smtp.SingularityMailer"] At SingularityMailer.java:[lines 57-408]
[INFO] com.hubspot.singularity.executor.SingularityExecutorMonitor.submit(SingularityExecutorTask) does not release lock on all exception paths ["com.hubspot.singularity.executor.SingularityExecutorMonitor"] At SingularityExecutorMonitor.java:[lines 34-428]
[INFO] com.hubspot.singularity.executor.SingularityExecutorMonitor$2.onSuccessThrows(ProcessBuilder) does not release lock on all exception paths ["com.hubspot.singularity.executor.SingularityExecutorMonitor$2"] At SingularityExecutorMonitor.java:[lines 242-291]
[INFO] com.hubspot.singularity.executor.config.SingularityExecutorConfiguration.getLogrotateExtrasFiles() may expose internal representation by returning SingularityExecutorConfiguration.logrotateExtrasFiles ["com.hubspot.singularity.executor.config.SingularityExecutorConfiguration"] At SingularityExecutorConfiguration.java:[lines 93-274]
[INFO] com.hubspot.singularity.executor.utils.ExecutorUtils.sendStatusUpdate(ExecutorDriver, Protos$TaskInfo, Protos$TaskState, String, Logger) invokes System.exit(...), which shuts down the entire virtual machine ["com.hubspot.singularity.executor.utils.ExecutorUtils"] At ExecutorUtils.java:[lines 15-38]
[INFO] com.hubspot.singularity.logwatcher.driver.SingularityLogWatcherDriver.markShutdown() does not release lock on all paths ["com.hubspot.singularity.logwatcher.driver.SingularityLogWatcherDriver"] At SingularityLogWatcherDriver.java:[lines 27-222]
[INFO] Found reliance on default encoding in com.hubspot.singularity.logwatcher.tailer.SingularityLogWatcherTailer.processByteBufferAndReturnRemainingBytes(): String.getBytes() ["com.hubspot.singularity.logwatcher.tailer.SingularityLogWatcherTailer"] At SingularityLogWatcherTailer.java:[lines 30-178]
[INFO] com.hubspot.singularity.s3uploader.SingularityS3UploaderDriver.processEvent(WatchEvent$Kind, Path) does not release lock on all paths ["com.hubspot.singularity.s3uploader.SingularityS3UploaderDriver"] At SingularityS3UploaderDriver.java:[lines 50-363]
[INFO] Integral division result cast to double or float in com.hubspot.singularity.oomkiller.SingularityOOMKiller.getOverageRatio(MesosTaskMonitorObject) ["com.hubspot.singularity.oomkiller.SingularityOOMKiller"] At SingularityOOMKiller.java:[lines 26-121]