Aurelia ValueConverter - Array Sort & Filter

filter.js

export class FilterValueConverter {
  toView(array, property, query) {
    if (query === void 0 || query === null || query === "" || !Array.isArray(array)) {
      return array;
    }

    let properties = (Array.isArray(property) ? property : [property]),
      term = String(query).toLowerCase();

    return array.filter((entry) =>
      properties.some((prop) =>
        String(entry[prop]).toLowerCase().indexOf(term) >= 0));
  }
}

page.html

repeat.for="s of surveys | filter: ['name','description']: searchterm | sort: 'name':'ascending'"

sort.js

export class SortValueConverter {
  toView(array, property, direction) {
    if (!array)
      return array;
    let pname = property;
    let factor = direction.match(/^desc*/i) ? 1 : -1;
    var retvalue = array.sort((a, b) => {
      var textA = a.toUpperCase ? a[property].toUpperCase() : a[property];
      var textB = b.toUpperCase ? b[property].toUpperCase() : b[property];
      return (textA < textB) ? factor : (textA > textB) ? -factor : 0;
    });
    return retvalue;
  }
}

I believe there is an error here, the items sorted probably wont have a "toUpperCase" method. I changed those rows to

var textA: string = a[property] && a[property].toUpperCase ? a[property].toUpperCase() : a[property];
var textB: string = b[property] && a[property].toUpperCase ? b[property].toUpperCase() : b[property];

• You can drop let pname = property; because it is not used