bad_practices

bad_practices.php

<?php
// wrong
$entityConfig = new EntityConfigId('security', $entityClass);
$shareScopes = $this->configManager->getConfig($entityConfig)->get('share_scopes');
// correct
$shareScopes = $this->configManager->getProvider('security')->getConfig($entityClass)->get('share_scopes');
// or
$shareScopes = $this->securityConfigProvider->getConfig($entityClass)->get('share_scopes');

//

// wrong
<?php
namespace OroPro\Bundle\OrganizationBundle\Migrations\Data\ORM;
use Doctrine\Common\DataFixtures\AbstractFixture;
use Doctrine\Common\Persistence\ObjectManager;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\DependencyInjection\ContainerAwareInterface;
use Oro\Bundle\EntityConfigBundle\Config\ConfigManager;
class SetOrganizationShareGridConfig extends AbstractFixture implements ContainerAwareInterface
{}
// migration for update, data fixture for initialization