Skip to content

Instantly share code, notes, and snippets.

@iezer
Last active September 13, 2018 09:31
Show Gist options
  • Save iezer/33b0f6f502cea8c109bcdaf2e7cb7dc9 to your computer and use it in GitHub Desktop.
Save iezer/33b0f6f502cea8c109bcdaf2e7cb7dc9 to your computer and use it in GitHub Desktop.
router service qp error
import Ember from 'ember';
export default Ember.Component.extend({
router: Ember.inject.service(),
actions: {
qpPage(page) {
this.router.transitionTo('qp-route', { queryParams: { page: page } });
}
}
});
import Ember from 'ember';
export default Ember.Controller.extend({
appName: 'Ember Twiddle'
});
import Ember from 'ember';
export default Ember.Controller.extend({
page: 1,
queryParams: [ 'page']
});
import EmberRouter from '@ember/routing/router';
import config from './config/environment';
const Router = EmberRouter.extend({
location: 'none',
rootURL: config.rootURL
});
Router.map(function() {
this.route('qp-route')
});
export default Router;
import Ember from 'ember';
export default Ember.Route.extend({
actions: {
qpPage(page) {
this.transitionTo('qp-route', { queryParams: { page: page } });
}
}
});
import Ember from 'ember';
export default Ember.Route.extend({
});
import Ember from 'ember';
export default Ember.Route.extend({
});
<h1>Welcome to {{appName}}</h1>
<p>
Summary: Transitioning to a route using the router service will put default query params in the location bar when they should not be there.
</p>
<p>
Default page query param is 1.
Clicking these links for a router action (not service) will set the page query param, and will not put the default value in the URL.
</p>
<button {{action 'qpPage' 1}}>Page 1</button>
<button {{action 'qpPage' 2}}>Page 2</button>
<p>
Clicking page 1 within a component that uses the router service will put the default query param in the URL (only if you click this button first).
</p>
<p style="color: red;">Click red button first</p>
{{qp-changer}}
{{outlet}}
<br>
<br>
<button {{action 'qpPage' 1}} style="color: red;">Page 1</button>
<button {{action 'qpPage' 2}}>Page 2</button>
{
"version": "0.15.0",
"EmberENV": {
"FEATURES": {}
},
"options": {
"use_pods": false,
"enable-testing": false
},
"dependencies": {
"jquery": "https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.js",
"ember": "3.2.2",
"ember-template-compiler": "3.2.2",
"ember-testing": "3.2.2"
},
"addons": {
"ember-data": "3.2.0"
}
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment