Skip to content

Instantly share code, notes, and snippets.

@ijuma
Last active Aug 29, 2015
Embed
What would you like to do?
git
object SolrClient {
object Response {
// This was fine in 2.10, but had to be renamed in 2.11
def apply[T](queryResponse: QueryResponse, page: Page)(documentsMapper: SolrDocument => T = identity[SolrDocument] _): Response[T] = ...
}
case class Response[T](
documents: Seq[T],
page: Page,
spellCheck: Option[SpellCheckResponse] = None
)
}
@adriaanm
Copy link

adriaanm commented Apr 23, 2014

Seems like some kind of separate compilation problem, because I can't repro with:

trait Page
trait SolrDocument
trait QueryResponse
trait SpellCheckResponse

object Response {

  // This was fine in 2.10, but had to be renamed in 2.11  
  def apply[T](queryResponse: QueryResponse, page: Page)(documentsMapper: SolrDocument => T = identity[SolrDocument] _): Response[T] = ???

  case class Response[T](
    documents: Seq[T],
    page: Page,
    spellCheck: Option[SpellCheckResponse] = None
  )

}

@ijuma
Copy link
Author

ijuma commented Apr 23, 2014

Sorry, I just fixed it. My initial version was wrong. :)

@adriaanm
Copy link

adriaanm commented Apr 23, 2014

No prob. Can repro now. Looking into it.

@ijuma
Copy link
Author

ijuma commented Apr 23, 2014

Thanks!

@adriaanm
Copy link

adriaanm commented Apr 23, 2014

This was due to the fix for SI-8157 Make overloading, defaults restriction PolyType aware.
I'll included it in the important changes section

@ijuma
Copy link
Author

ijuma commented Apr 23, 2014

Great, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment