Created
February 1, 2016 08:19
-
-
Save imbalind/672d727c3677ea7f6eea to your computer and use it in GitHub Desktop.
Performance test on ui-grid-digest-performance branch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thread for performance test |
Thanks for the thorough check.
This particular change was meant to deal mainly with load time. In my app it is quite critical, since "loading" occurs a lot - my users move/hide/show the grids constantly, and the app is HUGE, so every digest triggered by timeouts is a major event, so this improvement is mainly app-wide rather than grid-alone.
With the grid alone, I don't know how much it will improve speed.
I checked again focusing on load time and I can confirm it's quite faster. I guess that's what gave me the "things are smoother" feeling 😄
I'm still using it my development environment and found no problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I tried scrolling through circa 1200 rows, 40+ columns (all columns rendered) with the old branch as well as the new one.
I was using up to date FF, local app, local data (json).
I had the feeling that things were smoother with the new branch but, when I started tracking the execution time the difference were actually less visible.
To test it, I have a grid showing the data, I navigated through and back to the grid three times with the new branch and three times with the old one and recorded using FF's built-in profiler. Here's what I found:
Master
ui-grid-digest-performance
It seems to me a slight improvement is visible but I don't know if it's statistically significant.
The good thing, although I did no deep functional test, is I didn't notice any error or misbehaviour.
I'll keep on testing through the week.