phpBB Development Meeting #4 IRC Log

gistfile1.irclog

[13:00:45] <imkingdavid> so short meeting today I guess
[13:00:47] <imkingdavid> two items
[13:00:48] <brunoais> here
[13:00:50] <naderman> not too many people said they can make it anyway
[13:00:57] <imkingdavid> yeah
[13:01:15] <imkingdavid> first item: status of migrations and template events
[13:01:39] <naderman> on template events you made a post about how it should work
[13:01:44] <naderman> but the key bit there is actually missing
[13:01:52] <naderman> it's not just piriority of files within an extension
[13:02:08] <naderman> but it's actually important to consider what happens when multiple extensions provide the same file
[13:02:22] <imkingdavid> true
[13:02:24] <naderman> which I don't believe we have a solution to yet
[13:02:32] <imkingdavid> that should come down to event priority
[13:02:36] <naderman> also can one extension overwrite another?
[13:02:57] <naderman> cause it'd be kind of neat if you can just create a separate extension which ships the specialized template hooks for a style for another extension
[13:02:59] <imkingdavid> i'm not sure about overwriting... but I know that two extensions working on the same event can specify a priority
[13:03:20] <imkingdavid> so one is called before the other
[13:03:22] <naderman> e.g. extension foo only has all/foo.html, but extension bar could provide mystyle/foo.html
[13:03:58] <imkingdavid> as far as I know, when a template event is reached, all files of that name in all template folders are called
[13:04:03] <imkingdavid> theoretically, of course
[13:04:16] <naderman> well we're talking about whether that is how it shold work
[13:04:19] <naderman> *should work
[13:04:25] <naderman> and whether there aren't other use cases
[13:04:29] <naderman> and how to do it correctly
[13:04:38] <naderman> and I wonder if my above example shouldn't be an option too
[13:04:51] <naderman> so an extension can actually ship template specializations
[13:04:56] <naderman> rather than just additional templates
[13:05:13] <imkingdavid> i think that would work fine
[13:05:27] <naderman> it's not trivial
[13:05:34] <naderman> I mean what if two extensions provide the same specialization?
[13:05:48] <naderman> then you suddenly have the file twice and don't know which one to use
[13:06:05] <brunoais> that problem already exists with MODs :)
[13:06:13] <naderman> and how do you distinguish between it trying to provide a specialization and it wanting to just add a template hook?
[13:06:13] <brunoais> I don't know if it's actaully fixable...
[13:06:14] <imkingdavid> i'm not sure of a good way to specify which is preferred
[13:06:33] <naderman> brunoais: there are no MODs in 3.1
[13:06:40] <brunoais> YEah
[13:06:47] <brunoais> I'm talking about MODs for 3.0
[13:06:59] <naderman> well not relevant here now
[13:07:14] <naderman> imkingdavid: so basically I wonder if we need to come up with a different way of defining how and where a template hook is applied
[13:07:17] <naderman> rather than just by file name
[13:07:19] <imkingdavid> naderman: maybe that's up to the ext author. define a template constant like <!-- DEFINE $EXT_FILE_INCLUDED = true --> and then in the other one do <!-- IF $EXt_FILE_INCLUDED -->
[13:07:33] <naderman> no that is really bad
[13:07:35] <naderman> total chaos
[13:07:39] <rxu> as for the same named files provided by different extensions, extension manager should through a warning at least, if it doesn't do it now
[13:07:43] <naderman> we should have a decent mechanism for this built in
[13:07:50] <naderman> rxu: huh?
[13:07:54] <naderman> same named files?
[13:08:02] <naderman> rxu: the point here is that it should be possible to do that intentionally
[13:08:05] <naderman> it shouldn't warn
[13:08:11] <naderman> we should have a mechanism to use them correctly
[13:08:21] <naderman> ok anyway I don't think we'll get anywhere with this here today
[13:08:25] <imkingdavid> rxu: extensions should each be allowed to provide a template file for any template event. so there will potentially be more than one template inject for an event
[13:08:28] <naderman> this really needs a lot more though put into it
[13:08:31] <imkingdavid> naderman: probbably not
[13:08:31] <imkingdavid> yeah
[13:08:43] <naderman> and we do need to come up with some real examples
[13:08:53] <imkingdavid> :D
[13:09:12] <imkingdavid> alright, well we can discuss this more in the template events RFC i guess
[13:09:15] <imkingdavid> next item: Using Symfony's HttpKernel for new controllers and extensions
[13:09:18] <naderman> yeah
[13:09:32] <naderman> well did you get to look into that at all so far?
[13:09:35] <imkingdavid> https://github.com/phpbb/phpbb3/pull/995
[13:09:39] <naderman> was just really just curious if that got anywhere
[13:09:53] <naderman> oh ok
[13:09:55] <imkingdavid> note sure if I got on the right track
[13:09:58] <imkingdavid> but it's something
[13:10:00] <naderman> I guess I should look at that then
[13:10:02] <naderman> missed it so far
[13:10:06] <imkingdavid> and the most recent commit is not tested (just commited)
[13:11:50] <naderman> alright
[13:11:55] <naderman> I'll take a look at that then
[13:11:59] <naderman> and give you some feedback
[13:12:02] <imkingdavid> alright
[13:12:13] <imkingdavid> oh yeah, almost forgot
[13:12:16] <imkingdavid> status of migrations?
[13:12:23] <naderman> oh right that was part of the first one
[13:12:40] <naderman> well same as before with me not having been here for a while now and having been sick earlier this week
[13:12:55] <imkingdavid> alright
[13:12:55] <naderman> so no news on that front
[13:13:25] <imkingdavid> okay... anything else anyone wants to discuss?
[13:13:33] <imkingdavid> if not, the meeting's pretty much over
[13:13:57] <naderman> nope that's it for today I think
[13:14:04] <naderman> hopefully more to discuss next time ;-)
[13:14:06] <imkingdavid> yeah