imkingdavid

[16:21] <imkingdavid> http://tracker.phpbb.com/browse/PHPBB3-10539
[16:21] <imkingdavid> odd
[16:22] <imkingdavid> no clue why it only happens sometimes
[16:22] <imkingdavid> but it's consistent when it does happen
[16:22] <unknownbliss> its bizarre
[16:22] <unknownbliss> indeed
[16:23] <imkingdavid> maybe something to do with the reverse loading of topics https://github.com/phpbb/phpbb3/blob/develop/phpBB/viewforum.php#L444
[16:23] <imkingdavid> but i haven't had time to look too far into it
[16:23] <imkingdavid> since I can't get it to happen locally
[16:23] <unknownbliss> i got it to happen locally

imkingdavid

	static function get_blog_data($blog_id)
	{
		global $db;
		if(!$blog_id)
		{
			return false;
		}
		$sql_ary = array(
			'SELECT'    => 'b.*,c.*,u.*',
		

imkingdavid

[11:16] <@imkingdavid> naderman: to use templates in extensions, is there a $template->set_extension_filenames or something? How does it know to look in the ext/x/styles/prosilver/template/ folder rather than the main styles/prosilver/template folder?
[11:19] <@imkingdavid> should I be using $template->set_ext_dir_prefix($phpbb_root_path . 'ext/x/'); ?
[11:25] <@nn-> imkingdavid i don't know if that has been implemented yet
[11:26] <@imkingdavid> nn-: lovely
[11:26] <@imkingdavid> nn-: what about adding language from the ext/x/language/en/ directory? $user->add_lang_ext() ? or is that for something else?
[11:26] <@nn-> isn't it one of those things that i asked for a decision on?
[11:26] <@imkingdavid> ?
[11:27] * imkingdavid will have a hard time making a good example extension without such things
[11:27] <@nn-> https://github.com/p/phpbb3-ext-overall-header-addition/tree/master/ext/phpbb3-ext-overall-header-addition/styles
[11:27] <@nn-> note "universal"

imkingdavid

[20:23] == imkingdavid [ad4242aa@phpbb/developer/imkingdavid] has joined #phpBB-dev
[20:23] == mode/#phpBB-dev [+o imkingdavid] by ChanServ
[20:25] <@imkingdavid> can another developer review https://github.com/phpbb/phpbb3/pull/545 ? it's pretty much ready (I tested it some time ago and it worked) but I'd like a second opinion before I merge it
[20:30] == nw- [~pie@72.245.42.19] has joined #phpBB-dev
[20:48] <nw-> imkingdavid: rfc for http://tracker.phpbb.com/browse/PHPBB3-10576 ?
[20:51] <nw-> we can have a prosilver/lang/en.php.sample possibly regarding comments in https://github.com/phpbb/phpbb3/pull/530
[20:53] == Marshalrusty [~Marshalru@phpbb/manager/pdpc.21for7.marshalrusty] has quit [Disconnected by services]
[20:53] == YuriyRusko [~Marshalru@phpbb/manager/pdpc.21for7.marshalrusty] has joined #phpBB-dev
[20:53] == mode/#phpBB-dev [+o YuriyRusko] by ChanServ
[20:54] <nw-> &$lang = array() - that looks very suspicious

imkingdavid

<?php
/**
*
* @package testing
* @copyright (c) 2011 phpBB Group
* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
*
*/

/**

imkingdavid

[17:37:26] <nn-> imkingdavid: i am aware of that but i believe what i said remains true
[17:37:26] <igorw> nn-: please reply to event dispatcher PR
[17:37:34] <igorw> about PHPBB_NO_AUTOLOAD naming
[17:37:51] <nn-> do you have some issue with keeping both constants at top level?
[17:38:10] <nn-> i'm probably ok with renaming to no composer autoload
[17:39:09] --> unknownbliss1 (~unknownbl@phpbb/website/Unknown-Bliss) has joined #phpBB-dev
[17:39:09] *** Mode #phpBB-dev +o unknownbliss1 by ChanServ
[17:39:16] <imkingdavid> nn-: the first reason to hit the button is met by the second reason. So what is the issue with using the patch as is, or even with keeping the "Full Editor" text but making the button go to the preview page?
[17:39:39] <nn-> which reason is first again?
[17:39:58] <imkingdavid> first: getting to posting screen, second: preview what you have written, imo?

imkingdavid

[13:00:04] <imkingdavid> alright, meeting starts now. First item on the agenda is the status of events since last week's meeting.
[13:00:21] <nickvergessen> I updated some of the events with docs
[13:00:32] <nickvergessen> but need to finish the rest
[13:00:58] <imkingdavid> alright
[13:01:04] <nickvergessen> progress is here https://github.com/phpbb/phpbb3/compare/develop...nickvergessen:feature/php-events-4
[13:01:30] <nickvergessen> will try to fix the rest over the weekend
[13:01:39] <imkingdavid> alright
[13:01:40] <nickvergessen> so that oleg or anyone else can merge it
[13:01:57] <imkingdavid> does anyone have questions about events?
[13:02:04] <nickvergessen> then next step is to document the stuff correctly

imkingdavid

[11:00:11] <imkingdavid> alright, let's get this started
[11:00:15] <imkingdavid> ping: unknownbliss
[11:00:27] <imkingdavid> first item is 'Attachment Improvements needs a final review and dependencies need to be reviewed and merged."
[11:00:35] <unknownbliss> imkingdavid: thanks
[11:00:59] <imkingdavid> bantu was the one that brought that up, I think
[11:01:33] <imkingdavid> Fyorl: if you're around, do you have anything to say about it?
[11:01:45] <bantu> Dependency is https://github.com/phpbb/phpbb3/pull/881
[11:01:52] <bantu> I don't know what to do with that.
[11:02:07] <naderman> I guess I need to do that?
[11:02:09] <bantu> Plupload / Attachment Improvements is https://github.com/phpbb/phpbb3/pull/833

imkingdavid

[13:00:45] <imkingdavid> so short meeting today I guess
[13:00:47] <imkingdavid> two items
[13:00:48] <brunoais> here
[13:00:50] <naderman> not too many people said they can make it anyway
[13:00:57] <imkingdavid> yeah
[13:01:15] <imkingdavid> first item: status of migrations and template events
[13:01:39] <naderman> on template events you made a post about how it should work
[13:01:44] <naderman> but the key bit there is actually missing
[13:01:52] <naderman> it's not just piriority of files within an extension
[13:02:08] <naderman> but it's actually important to consider what happens when multiple extensions provide the same file

imkingdavid

<naderman> state needs to be kept properly, database_update.php needs to be rewritten to run the migrations, rollbacks need to be implemented
<naderman> extensions stuff needs to be integrated with it
<naderman> proper error handling needs to be added
<naderman> and auto rollback for partially applied migrations on error
<naderman> and we need to very thorougly test that our conversion of databse_update contents to migrations still works correctly