Skip to content

Instantly share code, notes, and snippets.

@ioggstream
Created November 7, 2017 13:08
Show Gist options
  • Save ioggstream/8f380d398aef989ac455b93b92d42048 to your computer and use it in GitHub Desktop.
Save ioggstream/8f380d398aef989ac455b93b92d42048 to your computer and use it in GitHub Desktop.
Disable broken xhci device before suspend and avoid freeze.
#!/bin/sh
#
# This script should prevent the following suspend errors
# which freezes the Dell Inspiron laptop.
#
# Put it in /usr/lib/systemd/system-sleep/xhci.sh
#
# The PCI 00:14.0 device is the usb xhci controller.
#
# kernel: [67445.560610] pci_pm_suspend(): hcd_pci_suspend+0x0/0x30 returns -16
# kernel: [67445.560619] dpm_run_callback(): pci_pm_suspend+0x0/0x150 returns -16
# kernel: [67445.560624] PM: Device 0000:00:14.0 failed to suspend async: error -16
# kernel: [67445.886961] PM: Some devices failed to suspend, or early wake event detected
if [ "${1}" == "pre" ]; then
# Do the thing you want before suspend here, e.g.:
echo "Disable broken xhci module before suspending at $(date)..." > /tmp/systemd_suspend_test
grep XHC.*enable /proc/acpi/wakeup && echo XHC > /proc/acpi/wakeup
elif [ "${1}" == "post" ]; then
# Do the thing you want after resume here, e.g.:
echo "Enable broken xhci module at wakeup from $(date)" >> /tmp/systemd_suspend_test
grep XHC.*disable /proc/acpi/wakeup && echo XHC > /proc/acpi/wakeup
fi
@psychonaut
Copy link

One thing: it should be bash in shebang not sh.

@ptrcnull
Copy link

One thing: it should be bash in shebang not sh.

why would it need to be bash? it's a perfectly valid posix sh script

@psychonaut
Copy link

interesting... with sh I've got:

./xhci: 15: [: pre: unexpected operator
./xhci: 19: [: pre: unexpected operator

It's debian, so sh is dash.

$ ls -la /bin/sh
lrwxrwxrwx 1 root root 4 Jun 21 13:28 /bin/sh -> dash

When I change to bash it works perfectly fine.

@ptrcnull
Copy link

ah, i was wrong; the test utility specification doesn't require == to be supported, only = or -eq

for maximum compatibility, the script could be edited to use = instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment